Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-09-13 Thread Alan Mikhak
On Fri, Sep 13, 2019 at 5:11 AM Kishon Vijay Abraham I wrote: > > + Haotian Wang > > On 03/06/19 11:12 PM, Alan Mikhak wrote: > > On Sun, Jun 2, 2019 at 9:43 PM Kishon Vijay Abraham I wrote: > >> Hi Alan, > >> On 31/05/19 11:46 PM, Alan Mikhak wrote: > >>> On Thu, May 30, 2019 at 10:08 PM Kishon

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-09-13 Thread Kishon Vijay Abraham I
+ Haotian Wang On 03/06/19 11:12 PM, Alan Mikhak wrote: > On Sun, Jun 2, 2019 at 9:43 PM Kishon Vijay Abraham I wrote: >> Hi Alan, >> On 31/05/19 11:46 PM, Alan Mikhak wrote: >>> On Thu, May 30, 2019 at 10:08 PM Kishon Vijay Abraham I >>> wrote: Hi Alan, > Hi Kishon, I still

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-06-03 Thread Alan Mikhak
On Sun, Jun 2, 2019 at 9:43 PM Kishon Vijay Abraham I wrote: > Hi Alan, > On 31/05/19 11:46 PM, Alan Mikhak wrote: > > On Thu, May 30, 2019 at 10:08 PM Kishon Vijay Abraham I > > wrote: > >> Hi Alan, > >>> Hi Kishon, > >> > >> I still have to look closer into your DMA patch but linked-list mode

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-06-02 Thread Kishon Vijay Abraham I
Hi Alan, On 31/05/19 11:46 PM, Alan Mikhak wrote: > On Thu, May 30, 2019 at 10:08 PM Kishon Vijay Abraham I wrote: >> Hi Alan, >>> >>> Hi Kishon, >>> >>> I have some improvements in mind for a v2 patch in response to >>> feedback from Gustavo Pimentel that the current implementation is HW >>> spe

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-06-02 Thread Vinod Koul
Hi Kishon, On 03-06-19, 09:54, Kishon Vijay Abraham I wrote: > right. For the endpoint case, drivers/pci/controller should register with the > dmaengine i.e if the controller has aN embedded DMA (I think it should be okay > to keep that in drivers/pci/controller itself instead of drivers/dma) and

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-06-02 Thread Kishon Vijay Abraham I
Hi, On 31/05/19 1:19 PM, Arnd Bergmann wrote: > On Fri, May 31, 2019 at 8:32 AM Vinod Koul wrote: >> On 31-05-19, 10:50, Kishon Vijay Abraham I wrote: >>> On 31/05/19 10:37 AM, Vinod Koul wrote: On 30-05-19, 11:16, Kishon Vijay Abraham I wrote: > > right, my initial thought process w

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-06-02 Thread Kishon Vijay Abraham I
Hi Vinod, On 31/05/19 12:02 PM, Vinod Koul wrote: > On 31-05-19, 10:50, Kishon Vijay Abraham I wrote: >> Hi Vinod, >> >> On 31/05/19 10:37 AM, Vinod Koul wrote: >>> Hi Kishon, >>> >>> On 30-05-19, 11:16, Kishon Vijay Abraham I wrote: +Vinod Koul Hi, On 30/05/19 4:07 AM, Al

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-31 Thread Alan Mikhak
On Thu, May 30, 2019 at 10:08 PM Kishon Vijay Abraham I wrote: > Hi Alan, > > > > Hi Kishon, > > > > I have some improvements in mind for a v2 patch in response to > > feedback from Gustavo Pimentel that the current implementation is HW > > specific. I hesitate from submitting a v2 patch because i

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-31 Thread Arnd Bergmann
On Fri, May 31, 2019 at 8:32 AM Vinod Koul wrote: > On 31-05-19, 10:50, Kishon Vijay Abraham I wrote: > > On 31/05/19 10:37 AM, Vinod Koul wrote: > > > On 30-05-19, 11:16, Kishon Vijay Abraham I wrote: > > >> > > >> right, my initial thought process was to use only dmaengine APIs in > > >> pci-epf

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-30 Thread Vinod Koul
On 31-05-19, 10:50, Kishon Vijay Abraham I wrote: > Hi Vinod, > > On 31/05/19 10:37 AM, Vinod Koul wrote: > > Hi Kishon, > > > > On 30-05-19, 11:16, Kishon Vijay Abraham I wrote: > >> +Vinod Koul > >> > >> Hi, > >> > >> On 30/05/19 4:07 AM, Alan Mikhak wrote: > >>> On Mon, May 27, 2019 at 2:09 AM

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-30 Thread Kishon Vijay Abraham I
Hi Vinod, On 31/05/19 10:37 AM, Vinod Koul wrote: > Hi Kishon, > > On 30-05-19, 11:16, Kishon Vijay Abraham I wrote: >> +Vinod Koul >> >> Hi, >> >> On 30/05/19 4:07 AM, Alan Mikhak wrote: >>> On Mon, May 27, 2019 at 2:09 AM Gustavo Pimentel >>> wrote: On Fri, May 24, 2019 at 20:42:43,

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-30 Thread Kishon Vijay Abraham I
Hi Alan, On 30/05/19 11:26 PM, Alan Mikhak wrote: > On Wed, May 29, 2019 at 10:48 PM Kishon Vijay Abraham I wrote: >> >> +Vinod Koul >> >> Hi, >> > On Fri, May 24, 2019 at 1:59 AM Gustavo Pimentel > wrote: >> >> Hi Alan, >> >> This patch implementation is very HW implemen

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-30 Thread Vinod Koul
Hi Kishon, On 30-05-19, 11:16, Kishon Vijay Abraham I wrote: > +Vinod Koul > > Hi, > > On 30/05/19 4:07 AM, Alan Mikhak wrote: > > On Mon, May 27, 2019 at 2:09 AM Gustavo Pimentel > > wrote: > >> > >> On Fri, May 24, 2019 at 20:42:43, Alan Mikhak > >> wrote: > >> > >> Hi Alan, > >> > >>> On Fr

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-30 Thread Alan Mikhak
On Wed, May 29, 2019 at 10:48 PM Kishon Vijay Abraham I wrote: > > +Vinod Koul > > Hi, > > >>> On Fri, May 24, 2019 at 1:59 AM Gustavo Pimentel > >>> wrote: > > Hi Alan, > > This patch implementation is very HW implementation dependent and > requires the DMA to exposed th

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-29 Thread Kishon Vijay Abraham I
+Vinod Koul Hi, On 30/05/19 4:07 AM, Alan Mikhak wrote: > On Mon, May 27, 2019 at 2:09 AM Gustavo Pimentel > wrote: >> >> On Fri, May 24, 2019 at 20:42:43, Alan Mikhak >> wrote: >> >> Hi Alan, >> >>> On Fri, May 24, 2019 at 1:59 AM Gustavo Pimentel >>> wrote: Hi Alan, This

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-29 Thread Alan Mikhak
On Mon, May 27, 2019 at 2:09 AM Gustavo Pimentel wrote: > > On Fri, May 24, 2019 at 20:42:43, Alan Mikhak > wrote: > > Hi Alan, > > > On Fri, May 24, 2019 at 1:59 AM Gustavo Pimentel > > wrote: > > > > > > Hi Alan, > > > > > > This patch implementation is very HW implementation dependent and > >

RE: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-27 Thread Gustavo Pimentel
On Fri, May 24, 2019 at 20:42:43, Alan Mikhak wrote: Hi Alan, > On Fri, May 24, 2019 at 1:59 AM Gustavo Pimentel > wrote: > > > > Hi Alan, > > > > This patch implementation is very HW implementation dependent and > > requires the DMA to exposed through PCIe BARs, which aren't always the > > ca

Re: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-24 Thread Alan Mikhak
On Fri, May 24, 2019 at 1:59 AM Gustavo Pimentel wrote: > > Hi Alan, > > This patch implementation is very HW implementation dependent and > requires the DMA to exposed through PCIe BARs, which aren't always the > case. Besides, you are defining some control bits on > include/linux/pci-epc.h that

RE: [PATCH] PCI: endpoint: Add DMA to Linux PCI EP Framework

2019-05-24 Thread Gustavo Pimentel
Hi Alan, This patch implementation is very HW implementation dependent and requires the DMA to exposed through PCIe BARs, which aren't always the case. Besides, you are defining some control bits on include/linux/pci-epc.h that may not have any meaning to other types of DMA. I don't think thi