RE: [PATCH] Export functions from pcie-designware

2014-09-23 Thread Mohit KUMAR DCG
essage- > > >> From: Bjorn Helgaas [mailto:bhelg...@google.com] > > >> Sent: Wednesday, September 17, 2014 5:09 AM > > >> To: Fabio Estevam > > >> Cc: mat...@sai.msu.ru; Mohit KUMAR DCG; Jingoo Han; linux- > > >> p...@vger.kernel.org; linux-ke

Re: [PATCH] Export functions from pcie-designware

2014-09-18 Thread Bjorn Helgaas
September 17, 2014 5:09 AM > >> To: Fabio Estevam > >> Cc: mat...@sai.msu.ru; Mohit KUMAR DCG; Jingoo Han; linux- > >> p...@vger.kernel.org; linux-kernel; matwey.korni...@gmail.com > >> Subject: Re: [PATCH] Export functions from pcie-designware > >> > >

Re: [PATCH] Export functions from pcie-designware

2014-09-16 Thread Bjorn Helgaas
t KUMAR DCG; Jingoo Han; linux- >> p...@vger.kernel.org; linux-kernel; matwey.korni...@gmail.com >> Subject: Re: [PATCH] Export functions from pcie-designware >> >> On Sat, Aug 30, 2014 at 10:07:30AM -0300, Fabio Estevam wrote: >> > On Sat, Aug 30, 2014 at 9:24 AM, wrote:

RE: [PATCH] Export functions from pcie-designware

2014-09-16 Thread Mohit KUMAR DCG
.com > Subject: Re: [PATCH] Export functions from pcie-designware > > On Sat, Aug 30, 2014 at 10:07:30AM -0300, Fabio Estevam wrote: > > On Sat, Aug 30, 2014 at 9:24 AM, wrote: > > > From: "Matwey V. Kornilov" > > > > > > pcie-spear13

Re: [PATCH] Export functions from pcie-designware

2014-09-16 Thread Bjorn Helgaas
On Sat, Aug 30, 2014 at 10:07:30AM -0300, Fabio Estevam wrote: > On Sat, Aug 30, 2014 at 9:24 AM, wrote: > > From: "Matwey V. Kornilov" > > > > pcie-spear13xx when built as module requires the functions from > > pcie-designware. > > Export them properly. I don't know how valuable pcie-spear13x

Re: [PATCH] Export functions from pcie-designware

2014-09-01 Thread Matwey V. Kornilov
2014-08-30 17:07 GMT+04:00 Fabio Estevam : > On Sat, Aug 30, 2014 at 9:24 AM, wrote: >> +EXPORT_SYMBOL(dw_pcie_cfg_read); > > What about using EXPORT_SYMBOL_GPL instead? It is for initial author to decide whether he want to export this function only for GPLed. > Why is this needed? For style c

Re: [PATCH] Export functions from pcie-designware

2014-08-30 Thread Fabio Estevam
On Sat, Aug 30, 2014 at 9:24 AM, wrote: > From: "Matwey V. Kornilov" > > pcie-spear13xx when built as module requires the functions from > pcie-designware. > Export them properly. > > Signed-off-by: Matwey V. Kornilov > --- > drivers/pci/host/pcie-designware.c | 7 +++ > drivers/pci/host