Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Dan Williams
On 10/27/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > Yeah, it's a pretty serious bug if the DMA engine flags an error. But > wouldn't it be better to BUG() in the context of the caller? That way, > you won't necessarily bring down the whole system. > I see your point... We could track t

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 09:44:44 -0700 "Dan Williams" <[EMAIL PROTECTED]> wrote: > On 10/24/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > Otherwise, Acked-by: Dan Williams <[EMAIL PROTECTED]> > > > > Thanks. Are one of you going to pick it up as well? > > > > Yeah, I'll pick it up. I'l

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 10:02:24 -0700 "Dan Williams" <[EMAIL PROTECTED]> wrote: > On 10/25/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > static irqreturn_t iop_adma_err_handler(int irq, void *data) > > { > > (...) > > > > BUG(); > > } > > > > That's a panic waiting to happen, i

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-26 Thread Dan Williams
On 10/25/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > On Wed, 24 Oct 2007 20:16:16 +0200 > Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > [handwaving about API extensions] > > Oh, and we definitely need a way to report errors. Looks like the > existing drivers want this as well -- I cou

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-26 Thread Dan Williams
On 10/24/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > Otherwise, Acked-by: Dan Williams <[EMAIL PROTECTED]> > > Thanks. Are one of you going to pick it up as well? > Yeah, I'll pick it up. I'll leave off the AVR addition to DMADEVICES because I assume it will come with the future patch i

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-25 Thread Haavard Skinnemoen
On Wed, 24 Oct 2007 20:16:16 +0200 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > [handwaving about API extensions] Oh, and we definitely need a way to report errors. Looks like the existing drivers want this as well -- I couldn't help but notice this in the iop-adma driver: static irqreturn_t

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-24 Thread Haavard Skinnemoen
On Wed, 24 Oct 2007 08:55:58 -0700 "Dan Williams" <[EMAIL PROTECTED]> wrote: > > Don't get me wrong; I think Intel deserves lots of respect for > > creating this framework. But this is also why I got a bit > > disappointed when I discovered that it seems to be less generic > > than I initially hope

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-24 Thread Dan Williams
Hi Haavard, On 10/24/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > This patch corrects what I hope are invalid assumptions about the DMA > engine layer: Not only Intel(R) hardware can do DMA, and DMA can be > used for other things than memcpy and RAID offloading. > > At the same time, make t

RE: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-24 Thread Nelson, Shannon
>From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] >Subject: [PATCH] DMA: Correct invalid assumptions in the Kconfig text > >This patch corrects what I hope are invalid assumptions about the DMA >engine layer: Not only Intel(R) hardware can do DMA, and DMA can be >used for other things than memcp