RE: [PATCH] ASoC: max98373: Added 10ms delay after amp software reset

2018-08-23 Thread Ryan Lee
ct: Re: [PATCH] ASoC: max98373: Added 10ms delay after amp software >reset > >EXTERNAL EMAIL > > > >On Thu, Aug 23, 2018 at 10:51:07AM +0100, Mark Brown wrote: >> On Wed, Aug 22, 2018 at 05:31:04PM -0700, Dmitry Torokhov wrote: >> > On Wed, Aug 22, 2018 at 5:21 PM

Re: [PATCH] ASoC: max98373: Added 10ms delay after amp software reset

2018-08-23 Thread Dmitry Torokhov
On Thu, Aug 23, 2018 at 10:51:07AM +0100, Mark Brown wrote: > On Wed, Aug 22, 2018 at 05:31:04PM -0700, Dmitry Torokhov wrote: > > On Wed, Aug 22, 2018 at 5:21 PM Ryan Lee > > wrote: > > > + mdelay(10); > > > Is it really necessary for the CPU to spin for 10msec here? > > usleep_range() wo

Re: [PATCH] ASoC: max98373: Added 10ms delay after amp software reset

2018-08-23 Thread Mark Brown
On Wed, Aug 22, 2018 at 05:31:04PM -0700, Dmitry Torokhov wrote: > On Wed, Aug 22, 2018 at 5:21 PM Ryan Lee > wrote: > > + mdelay(10); > Is it really necessary for the CPU to spin for 10msec here? > usleep_range() would be better solution. Or msleep() for that matter, it's not going ot be

Re: [PATCH] ASoC: max98373: Added 10ms delay after amp software reset

2018-08-22 Thread Dmitry Torokhov
On Wed, Aug 22, 2018 at 5:21 PM Ryan Lee wrote: > > Signed-off-by: Ryan Lee > --- > Changes : Applied 10ms delay after amp software reset. >10ms guard time is required for stability. > sound/soc/codecs/max98373.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/c