Re: [PATCH] ACPICA: cleanup method properly on error

2016-07-29 Thread Vegard Nossum
On 07/29/2016 06:47 AM, Zheng, Lv wrote: Hi, Vegard From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- ow...@vger.kernel.org] On Behalf Of Vegard Nossum Subject: [PATCH] ACPICA: cleanup method properly on error If the call to acpi_ds_init_aml_walk() fails, then we have to undo the walk

RE: [PATCH] ACPICA: cleanup method properly on error

2016-07-28 Thread Zheng, Lv
Hi, Vegard > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Vegard Nossum > Subject: [PATCH] ACPICA: cleanup method properly on error > > If the call to acpi_ds_init_aml_walk() fails, then we have to undo the > walk state push done by acpi_ds_crea

Re: [PATCH] ACPICA: cleanup method properly on error

2016-07-26 Thread Vegard Nossum
On 07/26/2016 10:28 PM, Moore, Robert wrote: /* Put the new state at the head of the walk list */ if (Thread) { AcpiDsPushWalkState (WalkState, Thread); } Is there any chance that Thread could be zero? I'm not sure if this question was for me or not, but that code

RE: [PATCH] ACPICA: cleanup method properly on error

2016-07-26 Thread Moore, Robert
/* Put the new state at the head of the walk list */ if (Thread) { AcpiDsPushWalkState (WalkState, Thread); } Is there any chance that Thread could be zero? > -Original Message- > From: Devel [mailto:devel-boun...@acpica.org] On Behalf Of Moore, Robert > Sent: Tu

RE: [PATCH] ACPICA: cleanup method properly on error

2016-07-26 Thread Moore, Robert
We'll look at this. Thanks. > -Original Message- > From: Vegard Nossum [mailto:vegard.nos...@oracle.com] > Sent: Friday, July 22, 2016 8:35 AM > To: Moore, Robert ; Zheng, Lv > ; Wysocki, Rafael J > Cc: linux-a...@vger.kernel.org; de...@acpica.org; linux- > ker...@vger.kernel.org; Vegard