Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-07-03 Thread Rafael J. Wysocki
On Mon, Jul 3, 2017 at 8:27 PM, Loc Ho wrote: > Hi Rafael, > > >> >> The current SPCR code does not check the access width of the > >> >> mmio, and > >> >> uses a default of 8bit register accesses. This prevents > >> >> devices that > >> >> only do 16 or

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-07-03 Thread Loc Ho
Hi Rafael, >> >> The current SPCR code does not check the access width of the >> >> mmio, and >> >> uses a default of 8bit register accesses. This prevents devices >> >> that >> >> only do 16 or 32bit register accesses from working. By simply

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-06-20 Thread Rafael J. Wysocki
On Tue, Jun 20, 2017 at 11:27 PM, Jon Mason wrote: > On Tue, Jun 20, 2017 at 2:33 PM, Loc Ho wrote: >> Hi Jon, >> >>> >>> >> >> The current SPCR code does not check the access width of the >>> >> >> mmio, and >>> >> >> uses a default of 8bit register accesses. This prevents devices

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-06-20 Thread Loc Ho
Hi Jon, >>> >> >> The current SPCR code does not check the access width of the >>> >> >> mmio, and >>> >> >> uses a default of 8bit register accesses. This prevents devices >>> >> >> that >>> >> >> only do 16 or 32bit register accesses from working. By simply >>> >> >>

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-06-20 Thread Jon Mason
On Tue, Jun 20, 2017 at 2:33 PM, Loc Ho wrote: > Hi Jon, > >> >> >> >> The current SPCR code does not check the access width of the mmio, >> >> >> and >> >> >> uses a default of 8bit register accesses. This prevents devices >> >> >> that >> >> >> only do 16 or 32bit register

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-06-20 Thread Loc Ho
Hi Jon, > > >> >> The current SPCR code does not check the access width of the mmio, > >> >> and > >> >> uses a default of 8bit register accesses. This prevents devices > >> >> that > >> >> only do 16 or 32bit register accesses from working. By simply > >> >> checking

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Loc Ho
Hi Jon, >> >> The current SPCR code does not check the access width of the mmio, and >> >> uses a default of 8bit register accesses. This prevents devices that >> >> only do 16 or 32bit register accesses from working. By simply >> >> checking >> >> this field and setting the

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Jon Masters
Sorry for top post. We would need to also need to handle other OEMs like HPE m400. The set is limited but we want to key off the right ID. You could also key off DMI data if it were later in boot. But probably too early at this point. -- Computer Architect | Sent from my 64-bit #ARM Powered pho

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Jon Mason
On Mon, May 08, 2017 at 01:51:20PM -0700, Loc Ho wrote: > Hi Jon, > > On Mon, May 8, 2017 at 1:34 PM, Jon Mason wrote: > > On Mon, May 8, 2017 at 3:57 PM, Loc Ho wrote: > >> Hi Jon, > >> > > >> The current SPCR code does not check the access width of the mmio, and > >> uses a defaul

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Loc Ho
Hi Jon, On Mon, May 8, 2017 at 1:34 PM, Jon Mason wrote: > On Mon, May 8, 2017 at 3:57 PM, Loc Ho wrote: >> Hi Jon, >> >> The current SPCR code does not check the access width of the mmio, and >> uses a default of 8bit register accesses. This prevents devices that >> only do 16

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Jon Mason
On Mon, May 8, 2017 at 3:57 PM, Loc Ho wrote: > Hi Jon, > >>> > The current SPCR code does not check the access width of the mmio, and > uses a default of 8bit register accesses. This prevents devices that > only do 16 or 32bit register accesses from working. By simply checking >

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Loc Ho
Hi Jon, >> The current SPCR code does not check the access width of the mmio, and uses a default of 8bit register accesses. This prevents devices that only do 16 or 32bit register accesses from working. By simply checking this field and setting the mmio string appropriately,

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Jon Masters
On 05/08/2017 03:11 PM, Loc Ho wrote: > Hi Jon, > >>> The current SPCR code does not check the access width of the mmio, and >>> uses a default of 8bit register accesses. This prevents devices that >>> only do 16 or 32bit register accesses from working. By simply checking >>> this field and sett

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-08 Thread Loc Ho
Hi Jon, >> The current SPCR code does not check the access width of the mmio, and >> uses a default of 8bit register accesses. This prevents devices that >> only do 16 or 32bit register accesses from working. By simply checking >> this field and setting the mmio string appropriately, this issue

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-06 Thread Jon Masters
On 05/04/2017 11:05 AM, Jon Mason wrote: > The current SPCR code does not check the access width of the mmio, and > uses a default of 8bit register accesses. This prevents devices that > only do 16 or 32bit register accesses from working. By simply checking > this field and setting the mmio strin

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-05 Thread Jon Mason
On Thu, May 4, 2017 at 11:09 PM, Zheng, Lv wrote: > Hi, > >> From: Jon Mason [mailto:jon.ma...@broadcom.com] >> Sent: Thursday, May 4, 2017 11:06 PM >> Subject: [PATCH] ACPI: SPCR: Use access width to determine mmio usage >> >> The current SPCR code does not check the access width of the mmio, and

RE: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-04 Thread Zheng, Lv
Hi, > From: Jon Mason [mailto:jon.ma...@broadcom.com] > Sent: Thursday, May 4, 2017 11:06 PM > Subject: [PATCH] ACPI: SPCR: Use access width to determine mmio usage > > The current SPCR code does not check the access width of the mmio, and > uses a default of 8bit register accesses. This prevent

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-04 Thread Jon Mason
On Thu, May 4, 2017 at 12:28 PM, Moore, Robert wrote: > Jon, > > You might want to take a look at using the acpi_read and acpi_write ACPICA > interfaces that accept a GAS structure and handle the access width (etc.) > automatically. > > Bob This function in SPCR is using common code for the ear

RE: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-04 Thread Moore, Robert
Jon, You might want to take a look at using the acpi_read and acpi_write ACPICA interfaces that accept a GAS structure and handle the access width (etc.) automatically. Bob > -Original Message- > From: Jon Mason [mailto:jon.ma...@broadcom.com] > Sent: Thursday, May 4, 2017 8:06 AM > T