Re: Question on comment header for for_each_domain()

2018-11-08 Thread Paul E. McKenney
On Thu, Nov 08, 2018 at 04:35:40PM +0100, Peter Zijlstra wrote: > On Thu, Nov 08, 2018 at 07:31:09AM -0800, Paul E. McKenney wrote: > > On Thu, Nov 08, 2018 at 10:21:51AM +0100, Peter Zijlstra wrote: > > > On Wed, Nov 07, 2018 at 03:00:02PM -0800, Paul E. McKenney wrote: > > > > Hello! > > > > > >

Re: Question on comment header for for_each_domain()

2018-11-08 Thread Peter Zijlstra
On Thu, Nov 08, 2018 at 07:31:09AM -0800, Paul E. McKenney wrote: > On Thu, Nov 08, 2018 at 10:21:51AM +0100, Peter Zijlstra wrote: > > On Wed, Nov 07, 2018 at 03:00:02PM -0800, Paul E. McKenney wrote: > > > Hello! > > > > > > The header comment for for_each_domain() talks about a call to > > > sy

Re: Question on comment header for for_each_domain()

2018-11-08 Thread Paul E. McKenney
On Thu, Nov 08, 2018 at 10:21:51AM +0100, Peter Zijlstra wrote: > On Wed, Nov 07, 2018 at 03:00:02PM -0800, Paul E. McKenney wrote: > > Hello! > > > > The header comment for for_each_domain() talks about a call to > > synchronize_sched() within detach_destroy_domains(), but I am not > > seeing any

Re: Question on comment header for for_each_domain()

2018-11-08 Thread Peter Zijlstra
On Wed, Nov 07, 2018 at 03:00:02PM -0800, Paul E. McKenney wrote: > Hello! > > The header comment for for_each_domain() talks about a call to > synchronize_sched() within detach_destroy_domains(), but I am not > seeing any such call. Because synchronize_sched() is now folded into > synchronize_rc

Question on comment header for for_each_domain()

2018-11-07 Thread Paul E. McKenney
Hello! The header comment for for_each_domain() talks about a call to synchronize_sched() within detach_destroy_domains(), but I am not seeing any such call. Because synchronize_sched() is now folded into synchronize_rcu(), I have a patch that edits the comment, but it looks like a larger change