Re: Question: pause mode disabled for marvell 88e151x phy

2019-01-24 Thread Yunsheng Lin
On 2019/1/24 6:41, Russell King - ARM Linux admin wrote: > On Sat, Jan 05, 2019 at 11:28:19AM +0800, Yunsheng Lin wrote: >> On 2018/12/17 22:36, Russell King - ARM Linux wrote: >>> I'll try to do further diagnosis over Christmas in case I've missed >>> something, but I suspect it may be one of thos

Re: Question: pause mode disabled for marvell 88e151x phy

2019-01-23 Thread Russell King - ARM Linux admin
On Sat, Jan 05, 2019 at 11:28:19AM +0800, Yunsheng Lin wrote: > On 2018/12/17 22:36, Russell King - ARM Linux wrote: > > I'll try to do further diagnosis over Christmas in case I've missed > > something, but I suspect it may be one of those "weird behaviour" issues > > where the safest action is to

Re: Question: pause mode disabled for marvell 88e151x phy

2019-01-04 Thread Yunsheng Lin
On 2018/12/17 22:36, Russell King - ARM Linux wrote: > I'll try to do further diagnosis over Christmas in case I've missed > something, but I suspect it may be one of those "weird behaviour" issues > where the safest action is to disable pause mode as per my commit - > which is far saner than havin

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 05:34:27PM +0800, Yunsheng Lin wrote: > On 2018/12/17 22:36, Russell King - ARM Linux wrote: > > As I've previously stated, the behaviour I've seen is _both_ pause bits > > clear: > > > > If I set bit 10 (pause), and read back to confirm: > > > > MII PHY #0 transceiver r

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-18 Thread Yunsheng Lin
On 2018/12/17 22:36, Russell King - ARM Linux wrote: > On Mon, Dec 17, 2018 at 05:42:20PM +0800, Yunsheng Lin wrote: >> On 2018/12/15 18:37, Russell King - ARM Linux wrote: >>> On Sat, Dec 15, 2018 at 04:07:42PM +0800, Yunsheng Lin wrote: There seems to be some problem with pause subsequent ne

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-17 Thread Russell King - ARM Linux
On Mon, Dec 17, 2018 at 05:42:20PM +0800, Yunsheng Lin wrote: > On 2018/12/15 18:37, Russell King - ARM Linux wrote: > > On Sat, Dec 15, 2018 at 04:07:42PM +0800, Yunsheng Lin wrote: > >> There seems to be some problem with pause subsequent negotiation. > >> We reverted the above patch and tried to

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-17 Thread Yunsheng Lin
On 2018/12/15 18:37, Russell King - ARM Linux wrote: > On Sat, Dec 15, 2018 at 04:07:42PM +0800, Yunsheng Lin wrote: >> There seems to be some problem with pause subsequent negotiation. >> We reverted the above patch and tried to reproduce the above problem >> by triggering another negotiation by r

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-15 Thread Russell King - ARM Linux
On Sat, Dec 15, 2018 at 04:07:42PM +0800, Yunsheng Lin wrote: > There seems to be some problem with pause subsequent negotiation. > We reverted the above patch and tried to reproduce the above problem > by triggering another negotiation by reconnection of the cable, using > ethtool -a cmd shows bot

Question: pause mode disabled for marvell 88e151x phy

2018-12-15 Thread Yunsheng Lin
Hi, all When using the marvel 88e151x phy driver, the pause mode is disabled by commit 6623c0fba10e when phy is inited as below: if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { + u32 pause; + /* Select page 18 */ err = marvell_set_