Re: Possible regression with commit 52221610d

2015-01-13 Thread Tim Kryger
On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: > On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: > >> I'm somewhat puzzled to what benefit 52221610d brings after bringing >> back the write of BIT(0). Is it just that we don't hit the BUG() on >> non-standard voltages? > > It is to all

Re: Possible regression with commit 52221610d

2015-01-13 Thread Tim Kryger
On Mon, Jan 12, 2015 at 2:31 AM, Ulf Hansson wrote: > On 5 January 2015 at 20:52, Bjorn Andersson wrote: >> On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: >>> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: >> [..] Non-the-less, feel free to propose a patch and I will give it

Re: Possible regression with commit 52221610d

2015-01-13 Thread Tim Kryger
On Mon, Jan 5, 2015 at 11:52 AM, Bjorn Andersson wrote: > On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: >> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: > [..] >>> Non-the-less, feel free to propose a patch and I will give it a test. >> >> Lets start with the simplest change firs

Re: Possible regression with commit 52221610d

2015-01-12 Thread Ulf Hansson
On 5 January 2015 at 20:52, Bjorn Andersson wrote: > On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: >> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: > [..] >>> Non-the-less, feel free to propose a patch and I will give it a test. >> >> Lets start with the simplest change first. P

Re: Possible regression with commit 52221610d

2015-01-05 Thread Bjorn Andersson
On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: > On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: [..] >> Non-the-less, feel free to propose a patch and I will give it a test. > > Lets start with the simplest change first. Please give this a try and > let me know what you think. > >

Re: Possible regression with commit 52221610d

2014-12-21 Thread Tim Kryger
On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: > I'm somewhat puzzled to what benefit 52221610d brings after bringing > back the write of BIT(0). Is it just that we don't hit the BUG() on > non-standard voltages? It is to allow the use of external regulators that are capable of supplyi

Re: Possible regression with commit 52221610d

2014-12-17 Thread Bjorn Andersson
On Tue, Dec 16, 2014 at 10:20 PM, Tim Kryger wrote: > On Tue, Dec 16, 2014 at 10:18 AM, Bjorn Andersson wrote: > >> We are routing the regulators straight to vdd of the memory and should >> hence use vmmc to specify this. However unless I actually program 0x29 >> in the Qualcomm sdhci block I get

Re: Possible regression with commit 52221610d

2014-12-16 Thread Tim Kryger
On Tue, Dec 16, 2014 at 10:18 AM, Bjorn Andersson wrote: > We are routing the regulators straight to vdd of the memory and should > hence use vmmc to specify this. However unless I actually program 0x29 > in the Qualcomm sdhci block I get no responses from the card. > > Which I believe is correct

Re: Possible regression with commit 52221610d

2014-12-16 Thread Stephen Warren
On 12/14/2014 09:48 PM, Tim Kryger wrote: On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson wrote: ... Or simply; what is vmmc (in the code) supposed to represent? Hi Bjorn, VMMC is the supply that delivers power out to the SD card itself (aka VDD). It is not the internal power rail/power

Re: Possible regression with commit 52221610d

2014-12-16 Thread Bjorn Andersson
On Mon, Dec 15, 2014 at 10:27 PM, Bjorn Andersson wrote: > On Sun, Dec 14, 2014 at 8:48 PM, Tim Kryger wrote: >> On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson wrote: > [..] >>> Or simply; what is vmmc (in the code) supposed to represent? >> >> Hi Bjorn, >> >> VMMC is the supply that delivers

Re: Possible regression with commit 52221610d

2014-12-15 Thread Bjorn Andersson
On Sun, Dec 14, 2014 at 8:48 PM, Tim Kryger wrote: > On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson wrote: [..] >> Or simply; what is vmmc (in the code) supposed to represent? > > Hi Bjorn, > > VMMC is the supply that delivers power out to the SD card itself (aka VDD). > > It is not the intern

Re: Possible regression with commit 52221610d

2014-12-14 Thread Tim Kryger
On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson wrote: > On Tue, Nov 4, 2014 at 7:31 AM, Tim Kryger wrote: >> On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot >> wrote: >>> Hi Tim, thanks for your reply! >>> >>> On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3, 2014 at 7:05

Re: Possible regression with commit 52221610d

2014-12-13 Thread Bjorn Andersson
On Tue, Nov 4, 2014 at 7:31 AM, Tim Kryger wrote: > On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot wrote: >> Hi Tim, thanks for your reply! >> >> On 11/04/2014 02:28 PM, Tim Kryger wrote: >>> >>> On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot [..] After bisecting I tracked commit 5222

Re: Possible regression with commit 52221610d

2014-11-05 Thread Alexandre Courbot
On 11/06/2014 12:27 AM, Tim Kryger wrote: On Wed, Nov 5, 2014 at 12:10 AM, Alexandre Courbot wrote: On 11/05/2014 12:31 AM, Tim Kryger wrote: On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot wrote: Hi Tim, thanks for your reply! On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3,

Re: Possible regression with commit 52221610d

2014-11-05 Thread Tim Kryger
On Wed, Nov 5, 2014 at 12:10 AM, Alexandre Courbot wrote: > On 11/05/2014 12:31 AM, Tim Kryger wrote: >> >> On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot >> wrote: >>> >>> Hi Tim, thanks for your reply! >>> >>> On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3, 2014 at 7:

Re: Possible regression with commit 52221610d

2014-11-05 Thread Alexandre Courbot
On 11/05/2014 12:31 AM, Tim Kryger wrote: On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot wrote: Hi Tim, thanks for your reply! On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot wrote: Hi guys, On the NVIDIA shield (tegra114-roth) platform, I h

Re: Possible regression with commit 52221610d

2014-11-04 Thread Tim Kryger
On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot wrote: > Hi Tim, thanks for your reply! > > On 11/04/2014 02:28 PM, Tim Kryger wrote: >> >> On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot >> wrote: >>> >>> Hi guys, >>> >>> On the NVIDIA shield (tegra114-roth) platform, I have noticed that MMC

Re: Possible regression with commit 52221610d

2014-11-04 Thread Alexandre Courbot
Hi Tim, thanks for your reply! On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot wrote: Hi guys, On the NVIDIA shield (tegra114-roth) platform, I have noticed that MMC stopped working completely on recent kernels. MMC devices will not show up and the

Re: Possible regression with commit 52221610d

2014-11-03 Thread Tim Kryger
On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot wrote: > Hi guys, > > On the NVIDIA shield (tegra114-roth) platform, I have noticed that MMC > stopped working completely on recent kernels. MMC devices will not show up > and the message "mmc1: Controller never released inhibit bit(s)." shows up >

Possible regression with commit 52221610d

2014-11-03 Thread Alexandre Courbot
Hi guys, On the NVIDIA shield (tegra114-roth) platform, I have noticed that MMC stopped working completely on recent kernels. MMC devices will not show up and the message "mmc1: Controller never released inhibit bit(s)." shows up repeatedly in the console. After bisecting I tracked commit 5