Re: Pls add this driver to the kernel tree !!

2000-12-01 Thread David Schleef
On Fri, Dec 01, 2000 at 09:26:29AM +, David Woodhouse wrote: > > [EMAIL PROTECTED] said: > > Not necessarily - it all depends on what your driver does. In many > > cases, supporting 2.2 and 2.4 is easy, and all you need are a few > > #if's. It's certainly much better to have a dozen or so

Re: Pls add this driver to the kernel tree !!

2000-12-01 Thread Jeff Garzik
On Tue, 28 Nov 2000, John B. Jacobsen wrote: > > /* winbond-840.c: A Linux PCI network adapter skeleton device driver. */ It is already in 2.4.x Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read

Re: Pls add this driver to the kernel tree !!

2000-12-01 Thread David Woodhouse
[EMAIL PROTECTED] said: > Not necessarily - it all depends on what your driver does. In many > cases, supporting 2.2 and 2.4 is easy, and all you need are a few > #if's. It's certainly much better to have a dozen or so #if's > sprinkled throughout the code than to have two separate source tree

Re: Pls add this driver to the kernel tree !!

2000-11-30 Thread Alan Cox
> > Actually, there is some benefit in leaving the LINUX_VERSION_CODE checks > > there... If someone wants to back-port the driver to 2.2, this makes it > > much easier. Also, some people like to maintain a single driver for all > > of the kernel versions, so they don't have to bugfix each drive

Re: Pls add this driver to the kernel tree !!

2000-11-30 Thread Timur Tabi
** Reply to message from Mark Hahn <[EMAIL PROTECTED]> on Thu, 30 Nov 2000 14:16:16 -0500 (EST) > > Actually, there is some benefit in leaving the LINUX_VERSION_CODE checks > > there... If someone wants to back-port the driver to 2.2, this makes it > > much easier. Also, some people like to ma

Re: Pls add this driver to the kernel tree !!

2000-11-30 Thread Mark Hahn
> Actually, there is some benefit in leaving the LINUX_VERSION_CODE checks > there... If someone wants to back-port the driver to 2.2, this makes it > much easier. Also, some people like to maintain a single driver for all > of the kernel versions, so they don't have to bugfix each driver versio

Re: Pls add this driver to the kernel tree !!

2000-11-30 Thread Andreas Dilger
Meelis Roos writes: > JBJ> #ifdef INLINE_PCISCAN > JBJ> #include "k_compat.h" > JBJ> #else > JBJ> #include "pci-scan.h" > JBJ> #include "kern_compat.h" > JBJ> #endif > > I quess you need to convert it to kernel PCI API first and probably also to > optimize away the LINUX_VERSION_CODE checks (we k

Re: Pls add this driver to the kernel tree !!

2000-11-30 Thread Meelis Roos
JBJ> #ifdef INLINE_PCISCAN JBJ> #include "k_compat.h" JBJ> #else JBJ> #include "pci-scan.h" JBJ> #include "kern_compat.h" JBJ> #endif I quess you need to convert it to kernel PCI API first and probably also to optimize away the LINUX_VERSION_CODE checks (we know it's 2.4). -- Meelis Roos ([EMAI

Re: Pls add this driver to the kernel tree !!

2000-11-30 Thread Tigran Aivazian
hi Dick, On Tue, 28 Nov 2000, John B. Jacobsen wrote: > /* Set the copy breakpoint for the copy-only-tiny-frames scheme. >Setting to > 1518 effectively disables this feature. */ > static int rx_copybreak = 0; A skeleton driver has a higher responsibility than just "a driver" and thus needs t

Pls add this driver to the kernel tree !!

2000-11-30 Thread John B. Jacobsen
/* winbond-840.c: A Linux PCI network adapter skeleton device driver. */ /* Written 1998-2000 by Donald Becker. This software may be used and distributed according to the terms of the GNU General Public License (GPL), incorporated herein by reference. Drivers base