Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-20 Thread Siddharth Gupta
On 1/20/2021 1:10 AM, Christoph Hellwig wrote: Can you give this patch a spin? Thanks! This patch fixed the fallback mechanism for me. Attaching logs: [   84.410162][  T244] qcom_q6v5_pas .remoteproc-cdsp: Direct firmware load for cdsp.bX failed with error -2 [   84.418276][  T244] q

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-20 Thread Christoph Hellwig
Can you give this patch a spin? diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c index f277d023ebcd14..4b5833b3059f9c 100644 --- a/fs/kernfs/file.c +++ b/fs/kernfs/file.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "kernfs-internal.h" @@ -180,11 +181,10 @@ static c

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-17 Thread Siddharth Gupta
On 1/15/2021 8:20 AM, Greg KH wrote: On Tue, Jan 12, 2021 at 10:31:26AM -0800, Siddharth Gupta wrote: On 1/8/2021 6:44 AM, Greg KH wrote: On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote: On 1/6/2021 2:33 AM, Greg KH wrote: Since the binary attributes don't support splice_{re

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-15 Thread Greg KH
On Tue, Jan 12, 2021 at 10:31:26AM -0800, Siddharth Gupta wrote: > > On 1/8/2021 6:44 AM, Greg KH wrote: > > On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote: > > > On 1/6/2021 2:33 AM, Greg KH wrote: > > > > > > > Since the binary attributes don't support splice_{read,write} > > >

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-12 Thread Siddharth Gupta
On 1/8/2021 6:44 AM, Greg KH wrote: On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote: On 1/6/2021 2:33 AM, Greg KH wrote: Since the binary attributes don't support splice_{read,write} functions the calls to splice_{read,write} used the default kernel_{read,write} functions. Wit

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-08 Thread Greg KH
On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote: > On 1/6/2021 2:33 AM, Greg KH wrote: > > > > > Since the binary attributes don't support splice_{read,write} > > > > > functions the > > > > > calls to splice_{read,write} used the default kernel_{read,write} > > > > > functions. >

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-07 Thread Siddharth Gupta
On 1/6/2021 2:33 AM, Greg KH wrote: On Tue, Jan 05, 2021 at 05:00:58PM -0800, Siddharth Gupta wrote: On 1/4/2021 10:36 PM, Greg KH wrote: On Mon, Jan 04, 2021 at 02:43:45PM -0800, Siddharth Gupta wrote: Hi all, With the introduction of the filesystem change "fs: don't allow splice read/writ

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-06 Thread Greg KH
On Tue, Jan 05, 2021 at 05:00:58PM -0800, Siddharth Gupta wrote: > > On 1/4/2021 10:36 PM, Greg KH wrote: > > On Mon, Jan 04, 2021 at 02:43:45PM -0800, Siddharth Gupta wrote: > > > Hi all, > > > > > > With the introduction of the filesystem change "fs: don't allow splice > > > read/write without

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-05 Thread Siddharth Gupta
On 1/4/2021 10:36 PM, Greg KH wrote: On Mon, Jan 04, 2021 at 02:43:45PM -0800, Siddharth Gupta wrote: Hi all, With the introduction of the filesystem change "fs: don't allow splice read/write without explicit ops"[1] the fallback mechanism of the firmware loader[2] no longer works when using

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-04 Thread Greg KH
On Mon, Jan 04, 2021 at 02:43:45PM -0800, Siddharth Gupta wrote: > Hi all, > > With the introduction of the filesystem change "fs: don't allow splice > read/write without explicit ops"[1] the fallback mechanism of the firmware > loader[2] no longer works when using sendfile[3] from the userspace.

PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-04 Thread Siddharth Gupta
Hi all, With the introduction of the filesystem change "fs: don't allow splice read/write without explicit ops"[1] the fallback mechanism of the firmware loader[2] no longer works when using sendfile[3] from the userspace. Since the binary attributes don't support splice_{read,write} functio