Re: PM / Suspend: Print wall time at suspend entry and exit

2017-07-13 Thread Pavel Machek
Hi! > >And userspace should not really be parsing kernel logs for time > >keeping, right? > Post-mortem, armed with user space logs in CLOCK_REALTIME (a choice that > most want on Android Logging) and kernel logs, these messages are > _invaluable_ in order to merge the kernel activities with user

Re: PM / Suspend: Print wall time at suspend entry and exit

2017-06-06 Thread Mark Salyzyn
On 06/05/2017 03:40 PM, Pavel Machek wrote: Nanoseconds do not really matter here, right? useconds do matter (syscall takes about 1us). But no matter, since Suspended message is only available on platforms that support persistent clock, so in those case (more devices than I can count) the me

Re: PM / Suspend: Print wall time at suspend entry and exit

2017-06-05 Thread Pavel Machek
Hi! > >>>On Mon, Jun 5, 2017 at 9:31 PM, Mark Salyzyn > >>>wrote: > Permits power state and battery life diagnosis. > >>>Which is possible even without this patch and we have tools for that > >>>(analyze_suspend.py, anyone?). > >>> > >>>Honestly, I don't see why this change is necessary or ev

Re: PM / Suspend: Print wall time at suspend entry and exit

2017-06-05 Thread Mark Salyzyn
On 06/05/2017 02:47 PM, Mark Salyzyn wrote: On 06/05/2017 02:18 PM, Pavel Machek wrote: Hi! On Mon, Jun 5, 2017 at 9:31 PM, Mark Salyzyn wrote: Permits power state and battery life diagnosis. Which is possible even without this patch and we have tools for that (analyze_suspend.py, anyone?).

Re: PM / Suspend: Print wall time at suspend entry and exit

2017-06-05 Thread Mark Salyzyn
On 06/05/2017 02:18 PM, Pavel Machek wrote: Hi! On Mon, Jun 5, 2017 at 9:31 PM, Mark Salyzyn wrote: Permits power state and battery life diagnosis. Which is possible even without this patch and we have tools for that (analyze_suspend.py, anyone?). Honestly, I don't see why this change is ne

Re: PM / Suspend: Print wall time at suspend entry and exit

2017-06-05 Thread Pavel Machek
Hi! > On Mon, Jun 5, 2017 at 9:31 PM, Mark Salyzyn wrote: > > Permits power state and battery life diagnosis. > > Which is possible even without this patch and we have tools for that > (analyze_suspend.py, anyone?). > > Honestly, I don't see why this change is necessary or even useful. I ran d

Re: PM / Suspend: Print wall time at suspend entry and exit

2017-06-05 Thread Rafael J. Wysocki
On Mon, Jun 5, 2017 at 9:31 PM, Mark Salyzyn wrote: > Permits power state and battery life diagnosis. Which is possible even without this patch and we have tools for that (analyze_suspend.py, anyone?). Honestly, I don't see why this change is necessary or even useful. Thanks, Rafael

Re: PM / Suspend: Print wall time at suspend entry and exit

2017-06-05 Thread Pavel Machek
On Mon 2017-06-05 12:31:14, Mark Salyzyn wrote: > Permits power state and battery life diagnosis. > > Signed-off-by: Todd Poynor > Signed-off-by: Mark Salyzyn I don't particulary like it (RTC is slow on PC class machines), but I guess the information is useful. Acked-by: Pavel Machek > --- >

PM / Suspend: Print wall time at suspend entry and exit

2017-06-05 Thread Mark Salyzyn
Permits power state and battery life diagnosis. Signed-off-by: Todd Poynor Signed-off-by: Mark Salyzyn --- kernel/power/suspend.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index c0248c74d6d4..464175f04bc5 100644 --- a/ke

Re: [RFC][PATCH 2/2] PM: Suspend: Print wall time at suspend entry and exit

2014-08-18 Thread Todd Poynor
> Existing printk timestamps in a dmesg only log suspend activities > (e.g. filesystem syncs, freezing/unfreezing tasks etc) while the > system has already started to enter/exit the suspend state. Sometimes > it is handy to have suspend entry/exit overhead information while > debugging suspend issu

[RFC][PATCH 2/2] PM: Suspend: Print wall time at suspend entry and exit

2014-08-01 Thread Amit Pundir
From: Todd Poynor Existing printk timestamps in a dmesg only log suspend activities (e.g. filesystem syncs, freezing/unfreezing tasks etc) while the system has already started to enter/exit the suspend state. Sometimes it is handy to have suspend entry/exit overhead information while debugging su