[PATCH 4.9 034/191] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-29 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH 4.4 026/135] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-29 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH 5.7 174/477] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-23 Thread Greg Kroah-Hartman
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH 5.4 123/314] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-23 Thread Greg Kroah-Hartman
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH 4.14 048/136] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-23 Thread Greg Kroah-Hartman
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH 4.19 074/206] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-23 Thread Greg Kroah-Hartman
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH AUTOSEL 4.19 079/172] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-17 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH AUTOSEL 4.9 39/80] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-17 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH AUTOSEL 4.14 050/108] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-17 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH AUTOSEL 4.4 31/60] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-17 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH AUTOSEL 5.4 125/266] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-17 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

[PATCH AUTOSEL 5.7 177/388] PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges

2020-06-17 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 66ff14e59e8a30690755b08bc3042359703fb07a ] 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PC

Re: [PATCH v2 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-18 Thread Bjorn Helgaas
On Thu, Jun 18, 2015 at 12:55:53PM -0500, Bjorn Helgaas wrote: > On Fri, Jun 12, 2015 at 05:35:57PM -0700, Duc Dang wrote: > > X-Gene v1 PCIe controller has a bug in Configuration Request Retry > > Status (CRS) logic: > > When CPU tries to read Vendor ID and Device ID of not-existed > > remote

Re: [PATCH v2 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-18 Thread Duc Dang
On Thu, Jun 18, 2015 at 10:55 AM, Bjorn Helgaas wrote: > On Fri, Jun 12, 2015 at 05:35:57PM -0700, Duc Dang wrote: >> X-Gene v1 PCIe controller has a bug in Configuration Request Retry >> Status (CRS) logic: >> When CPU tries to read Vendor ID and Device ID of not-existed >> remote device, the

Re: [PATCH v2 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-18 Thread Tanmay Inamdar
Hi, On Fri, Jun 12, 2015 at 5:35 PM, Duc Dang wrote: > X-Gene v1 PCIe controller has a bug in Configuration Request Retry > Status (CRS) logic: > When CPU tries to read Vendor ID and Device ID of not-existed > remote device, the controller returns 0x0001 instead of > 0x; this wi

Re: [PATCH v2 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-18 Thread Bjorn Helgaas
On Fri, Jun 12, 2015 at 05:35:57PM -0700, Duc Dang wrote: > X-Gene v1 PCIe controller has a bug in Configuration Request Retry > Status (CRS) logic: > When CPU tries to read Vendor ID and Device ID of not-existed > remote device, the controller returns 0x0001 instead of > 0x; this

[PATCH v2 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-12 Thread Duc Dang
X-Gene v1 PCIe controller has a bug in Configuration Request Retry Status (CRS) logic: When CPU tries to read Vendor ID and Device ID of not-existed remote device, the controller returns 0x0001 instead of 0x; this will add significant delay in boot time as pci_bus_read_dev_vendo

Re: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-12 Thread Bjorn Helgaas
On Fri, Jun 12, 2015 at 5:10 PM, Duc Dang wrote: > Hi Bjorn, > > On Fri, Jun 12, 2015 at 2:59 PM, Bjorn Helgaas wrote: >> Hi Duc, >> >> On Thu, Jun 11, 2015 at 01:08:14PM -0700, Duc Dang wrote: >>> X-Gene v1 PCIe controller has a bug in Configuration Request Retry >>> Status (CRS) logic: >>> Wh

Re: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-12 Thread Duc Dang
Hi Bjorn, On Fri, Jun 12, 2015 at 2:59 PM, Bjorn Helgaas wrote: > Hi Duc, > > On Thu, Jun 11, 2015 at 01:08:14PM -0700, Duc Dang wrote: >> X-Gene v1 PCIe controller has a bug in Configuration Request Retry >> Status (CRS) logic: >> When CPU tries to read Vendor ID and Device ID of not-existed >

Re: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-12 Thread Bjorn Helgaas
Hi Duc, On Thu, Jun 11, 2015 at 01:08:14PM -0700, Duc Dang wrote: > X-Gene v1 PCIe controller has a bug in Configuration Request Retry > Status (CRS) logic: > When CPU tries to read Vendor ID and Device ID of not-existed > remote device, the controller returns 0x0001 instead of > 0xF

Re: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-12 Thread Ian Campbell
On Thu, 2015-06-11 at 13:08 -0700, Duc Dang wrote: > X-Gene v1 PCIe controller has a bug in Configuration Request Retry > Status (CRS) logic: > When CPU tries to read Vendor ID and Device ID of not-existed > remote device, the controller returns 0x0001 instead of > 0x; this will a

Re: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-12 Thread Marcin Juszkiewicz
W dniu 11.06.2015 o 22:08, Duc Dang pisze:> X-Gene v1 PCIe controller has a bug in Configuration Request Retry > Status (CRS) logic: >When CPU tries to read Vendor ID and Device ID of not-existed >remote device, the controller returns 0x0001 instead of >0x; this will add si

[PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-11 Thread Duc Dang
X-Gene v1 PCIe controller has a bug in Configuration Request Retry Status (CRS) logic: When CPU tries to read Vendor ID and Device ID of not-existed remote device, the controller returns 0x0001 instead of 0x; this will add significant delay in boot time as pci_bus_read_dev_vendo

Re: [PATCH v10 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-06-05 Thread Duc Dang
On Fri, Jun 5, 2015 at 2:05 PM, Bjorn Helgaas wrote: > On Fri, May 29, 2015 at 11:24:28AM -0700, Duc Dang wrote: >> This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 >> SoC. >> APM X-Gene v1 SoC supports its own implementation of MSI, which is not >> compliant >> to GIC V

Re: [PATCH v10 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-06-05 Thread Bjorn Helgaas
On Fri, May 29, 2015 at 11:24:28AM -0700, Duc Dang wrote: > This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > compliant > to GIC V2M specification for MSI Termination. > > There is single MSI b

[PATCH v10 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-05-29 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver. Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar Reviewed-by: Marc Zyngier --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 781e099..59

[PATCH v10 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-29 Thread Duc Dang
APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block supports 2048 MSI termination ports coalesced into 16 physical HW IRQ lines and sh

[PATCH v10 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-05-29 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block sup

Re: [PATCH v9 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-28 Thread Duc Dang
On Thu, May 28, 2015 at 1:05 AM, Marc Zyngier wrote: > On 27/05/15 19:27, Duc Dang wrote: >> APM X-Gene v1 SoC supports its own implementation of MSI, which is not >> compliant to GIC V2M specification for MSI Termination. >> >> There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe po

Re: [PATCH v9 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-28 Thread Marc Zyngier
On 27/05/15 19:27, Duc Dang wrote: > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > compliant to GIC V2M specification for MSI Termination. > > There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. > This MSI block supports 2048 MSI termination ports c

Re: [PATCH v8 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-27 Thread Duc Dang
On Mon, May 25, 2015 at 4:52 AM, Marc Zyngier wrote: > On Fri, 22 May 2015 19:41:10 +0100 > Duc Dang wrote: > >> APM X-Gene v1 SoC supports its own implementation of MSI, which is not >> compliant >> to GIC V2M specification for MSI Termination. >> >> There is single MSI block in X-Gene v1 SOC w

[PATCH v9 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-27 Thread Duc Dang
APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block supports 2048 MSI termination ports coalesced into 16 physical HW IRQ lines and sh

[PATCH v9 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-05-27 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar Reviewed-by: Marc Zyngier --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 781e099..59a

[PATCH v9 0/4]PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-05-27 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block su

Re: [PATCH v8 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-25 Thread Marc Zyngier
On Fri, 22 May 2015 19:41:10 +0100 Duc Dang wrote: > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > compliant > to GIC V2M specification for MSI Termination. > > There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. > This MSI > block supports 2048

Re: [PATCH v7 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-22 Thread Duc Dang
On Wed, May 20, 2015 at 2:16 AM, Marc Zyngier wrote: > On Mon, 18 May 2015 10:55:19 +0100 > Duc Dang wrote: > >> APM X-Gene v1 SoC supports its own implementation of MSI, which is not >> compliant >> to GIC V2M specification for MSI Termination. >> >> There is single MSI block in X-Gene v1 SOC w

[PATCH v8 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-05-22 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block su

[PATCH v8 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-22 Thread Duc Dang
APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block supports 2048 MSI termination ports coalesced into 16 physical HW IRQ lines and

[PATCH v8 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-05-22 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddc5a8c..a1b119b 100644 --- a/MAINTAINE

Re: [PATCH v7 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-20 Thread Marc Zyngier
On Mon, 18 May 2015 10:55:19 +0100 Duc Dang wrote: > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > compliant > to GIC V2M specification for MSI Termination. > > There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. > This MSI > block supports 2048

Re: [PATCH v6 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-18 Thread Duc Dang
On Wed, Apr 22, 2015 at 5:50 AM, Marc Zyngier wrote: > > On Wed, 22 Apr 2015 07:15:09 +0100 > Duc Dang wrote: > > > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > > compliant > > to GIC V2M specification for MSI Termination. > > > > There is single MSI block in X-Gene v

[PATCH v7 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-05-18 Thread Duc Dang
APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block supports 2048 MSI termination ports coalesced into 16 physical HW IRQ lines and

[PATCH v7 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-05-18 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddc5a8c..a1b119b 100644 --- a/MAINTAINE

[PATCH v7 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-05-18 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block su

Re: [PATCH v6 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-22 Thread Marc Zyngier
On Wed, 22 Apr 2015 07:15:09 +0100 Duc Dang wrote: > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > compliant > to GIC V2M specification for MSI Termination. > > There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. > This MSI > block supports 2048

[PATCH v6 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-04-21 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddc5a8c..a1b119b 100644 --- a/MAINTAINE

[PATCH v6 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-21 Thread Duc Dang
APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block supports 2048 MSI termination ports coalesced into 16 physical HW IRQ lines and

[PATCH v6 0/4]PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-04-21 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block su

Re: [PATCH v5 0/4]PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-04-21 Thread Jon Masters
On 04/21/2015 12:04 AM, Duc Dang wrote: > This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > compliant > to GIC V2M specification for MSI Termination. > > There is single MSI block in X-Gene v1

Re: [PATCH v5 0/4]PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-04-21 Thread Jon Masters
On 04/21/2015 12:04 AM, Duc Dang wrote: > This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. > APM X-Gene v1 SoC supports its own implementation of MSI, which is not > compliant > to GIC V2M specification for MSI Termination. > > There is single MSI block in X-Gene v1

Re: [PATCH v5 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-21 Thread Marc Zyngier
On 21/04/15 05:04, Duc Dang wrote: > X-Gene v1 SoC supports total 256 MSI/MSIX vectors coalesced into > 16 HW IRQ lines. This commit message could be beefed up to describe what this really does. > Signed-off-by: Duc Dang > Signed-off-by: Tanmay Inamdar > --- > drivers/pci/host/Kconfig

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-21 Thread Marc Zyngier
On 20/04/15 19:51, Feng Kan wrote: > Is it possible to use the pci_msi_create_default_irq_domain for the X-Gene MSI > driver. Or is this going to be removed in the future. Thanks This is not the preferred way. pci_msi_create_default_irq_domain is only there for legacy purposes, so that we can loo

Re: [PATCH v4 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-21 Thread Arnd Bergmann
On Monday 20 April 2015 11:49:37 Feng Kan wrote: > > > > Obviously they appear on the PCI host bridge in order, because that > > is a how PCI works. My question was about what happens then. On a lot > > of SoCs, there is something like an AXI bus that uses posted > > transactions between PCI and RA

[PATCH v5 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-20 Thread Duc Dang
X-Gene v1 SoC supports total 256 MSI/MSIX vectors coalesced into 16 HW IRQ lines. Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 6 + drivers/pci/host/Makefile| 1 + drivers/pci/host/pci-xgene-msi.c | 477

[PATCH v5 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-04-20 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddc5a8c..a1b119b 100644 --- a/MAINTAINE

[PATCH v5 0/4]PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-04-20 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block su

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-20 Thread Feng Kan
On Fri, Apr 17, 2015 at 5:45 AM, Marc Zyngier wrote: > On 17/04/15 13:37, Duc Dang wrote: >> On Fri, Apr 17, 2015 at 3:17 AM, Marc Zyngier wrote: >>> On 17/04/15 11:00, Duc Dang wrote: On Wed, Apr 15, 2015 at 1:16 AM, Marc Zyngier wrote: > On Tue, 14 Apr 2015 19:20:19 +0100 > Duc Da

Re: [PATCH v4 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-20 Thread Feng Kan
On Sun, Apr 19, 2015 at 12:55 PM, Arnd Bergmann wrote: > On Sunday 19 April 2015 11:40:09 Duc Dang wrote: >> On Fri, Apr 17, 2015 at 7:10 AM, Arnd Bergmann wrote: >> > On Friday 17 April 2015 02:50:07 Duc Dang wrote: >> >> + >> >> + /* >> >> +* MSIINTn (n is 0..F) indicates if there

Re: [PATCH v4 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-19 Thread Arnd Bergmann
On Sunday 19 April 2015 11:40:09 Duc Dang wrote: > On Fri, Apr 17, 2015 at 7:10 AM, Arnd Bergmann wrote: > > On Friday 17 April 2015 02:50:07 Duc Dang wrote: > >> + > >> + /* > >> +* MSIINTn (n is 0..F) indicates if there is a pending MSI > >> interrupt > >> +* If bit x of t

Re: [PATCH v4 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-19 Thread Duc Dang
On Fri, Apr 17, 2015 at 7:10 AM, Arnd Bergmann wrote: > On Friday 17 April 2015 02:50:07 Duc Dang wrote: >> + >> + /* >> +* MSIINTn (n is 0..F) indicates if there is a pending MSI interrupt >> +* If bit x of this register is set (x is 0..7), one or more >> interupts >> +

Re: [PATCH v4 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-18 Thread Arnd Bergmann
On Friday 17 April 2015 02:50:07 Duc Dang wrote: > + > + /* > +* MSIINTn (n is 0..F) indicates if there is a pending MSI interrupt > +* If bit x of this register is set (x is 0..7), one or more interupts > +* corresponding to MSInIRx is set. > +*/ > + grp

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-17 Thread Marc Zyngier
On 17/04/15 13:37, Duc Dang wrote: > On Fri, Apr 17, 2015 at 3:17 AM, Marc Zyngier wrote: >> On 17/04/15 11:00, Duc Dang wrote: >>> On Wed, Apr 15, 2015 at 1:16 AM, Marc Zyngier wrote: On Tue, 14 Apr 2015 19:20:19 +0100 Duc Dang wrote: > On Sat, Apr 11, 2015 at 5:06 AM, Marc Z

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-17 Thread Duc Dang
On Fri, Apr 17, 2015 at 3:17 AM, Marc Zyngier wrote: > On 17/04/15 11:00, Duc Dang wrote: >> On Wed, Apr 15, 2015 at 1:16 AM, Marc Zyngier wrote: >>> On Tue, 14 Apr 2015 19:20:19 +0100 >>> Duc Dang wrote: >>> On Sat, Apr 11, 2015 at 5:06 AM, Marc Zyngier wrote: > On 2015-04-11 00:

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-17 Thread Marc Zyngier
On 17/04/15 11:00, Duc Dang wrote: > On Wed, Apr 15, 2015 at 1:16 AM, Marc Zyngier wrote: >> On Tue, 14 Apr 2015 19:20:19 +0100 >> Duc Dang wrote: >> >>> On Sat, Apr 11, 2015 at 5:06 AM, Marc Zyngier >>> wrote: On 2015-04-11 00:42, Duc Dang wrote: > > On Fri, Apr 10, 2015 at 10:20 A

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-17 Thread Duc Dang
On Wed, Apr 15, 2015 at 1:16 AM, Marc Zyngier wrote: > On Tue, 14 Apr 2015 19:20:19 +0100 > Duc Dang wrote: > >> On Sat, Apr 11, 2015 at 5:06 AM, Marc Zyngier >> wrote: >> > On 2015-04-11 00:42, Duc Dang wrote: >> >> >> >> On Fri, Apr 10, 2015 at 10:20 AM, Marc Zyngier >> >> wrote: >> >>> >> >>

[PATCH v4 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-04-17 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddc5a8c..a1b119b 100644 --- a/MAINTAINE

[PATCH v4 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-17 Thread Duc Dang
X-Gene v1 SoC supports total 2048 MSI/MSIX vectors coalesced into 16 HW IRQ lines. Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 6 + drivers/pci/host/Makefile| 1 + drivers/pci/host/pci-xgene-msi.c | 410 +++

[PATCH v4 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-04-17 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block su

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-15 Thread Marc Zyngier
On Tue, 14 Apr 2015 19:20:19 +0100 Duc Dang wrote: > On Sat, Apr 11, 2015 at 5:06 AM, Marc Zyngier > wrote: > > On 2015-04-11 00:42, Duc Dang wrote: > >> > >> On Fri, Apr 10, 2015 at 10:20 AM, Marc Zyngier > >> wrote: > >>> > >>> On 09/04/15 18:05, Duc Dang wrote: > > X-Gene v1 SoC su

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-14 Thread Duc Dang
On Sat, Apr 11, 2015 at 5:06 AM, Marc Zyngier wrote: > On 2015-04-11 00:42, Duc Dang wrote: >> >> On Fri, Apr 10, 2015 at 10:20 AM, Marc Zyngier >> wrote: >>> >>> On 09/04/15 18:05, Duc Dang wrote: X-Gene v1 SoC supports total 2688 MSI/MSIX vectors coalesced into 16 HW IRQ lines. >

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-11 Thread Arnd Bergmann
On Friday 10 April 2015 17:16:32 Feng Kan wrote: > Hi Marc: > > Is there any plans to support ACPI for GICv2m MSI? Both this driver and the > GICv2m seems to support OF model of discovery for msi controller. X-Gene1 > uses this driver and X-Gene2 uses GICv2m, there needs to be a way to > associate

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-11 Thread Marc Zyngier
Hi Feng, On 2015-04-11 01:16, Feng Kan wrote: Is there any plans to support ACPI for GICv2m MSI? Both this driver and the GICv2m seems to support OF model of discovery for msi controller. X-Gene1 uses this driver and X-Gene2 uses GICv2m, there needs to be a way to associate msi controller wit

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-11 Thread Marc Zyngier
On 2015-04-11 00:42, Duc Dang wrote: On Fri, Apr 10, 2015 at 10:20 AM, Marc Zyngier wrote: On 09/04/15 18:05, Duc Dang wrote: X-Gene v1 SoC supports total 2688 MSI/MSIX vectors coalesced into 16 HW IRQ lines. Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfi

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-10 Thread Feng Kan
Hi Marc: Is there any plans to support ACPI for GICv2m MSI? Both this driver and the GICv2m seems to support OF model of discovery for msi controller. X-Gene1 uses this driver and X-Gene2 uses GICv2m, there needs to be a way to associate msi controller with the PCIe bus. I haven't found a standard

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-10 Thread Duc Dang
On Fri, Apr 10, 2015 at 11:13 AM, Paul Bolle wrote: > Just a nit about a license mismatch. > > On Thu, 2015-04-09 at 10:05 -0700, Duc Dang wrote: >> --- a/drivers/pci/host/Kconfig >> +++ b/drivers/pci/host/Kconfig > >> +config PCI_XGENE_MSI >> + bool "X-Gene v1 PCIe MSI feature" >> + depen

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-10 Thread Duc Dang
On Fri, Apr 10, 2015 at 10:20 AM, Marc Zyngier wrote: > On 09/04/15 18:05, Duc Dang wrote: >> X-Gene v1 SoC supports total 2688 MSI/MSIX vectors coalesced into >> 16 HW IRQ lines. >> >> Signed-off-by: Duc Dang >> Signed-off-by: Tanmay Inamdar >> --- >> drivers/pci/host/Kconfig | 6 + >

Re: [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-09 Thread Bjorn Helgaas
On Thu, Apr 09, 2015 at 10:05:03AM -0700, Duc Dang wrote: > X-Gene v1 SoC supports total 2688 MSI/MSIX vectors coalesced into > 16 HW IRQ lines. > > Signed-off-by: Duc Dang > Signed-off-by: Tanmay Inamdar > ... > --- /dev/null > +++ b/drivers/pci/host/pci-xgene-msi.c > @@ -0,0 +1,407 @@ > ...

[PATCH v3 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver

2015-04-09 Thread Duc Dang
This patch set adds MSI/MSIX termination driver support for APM X-Gene v1 SoC. APM X-Gene v1 SoC supports its own implementation of MSI, which is not compliant to GIC V2M specification for MSI Termination. There is single MSI block in X-Gene v1 SOC which serves all 5 PCIe ports. This MSI block su

[PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver

2015-04-09 Thread Duc Dang
X-Gene v1 SoC supports total 2688 MSI/MSIX vectors coalesced into 16 HW IRQ lines. Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 6 + drivers/pci/host/Makefile| 1 + drivers/pci/host/pci-xgene-msi.c | 407 +++

[PATCH v3 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver

2015-04-09 Thread Duc Dang
This patch adds information of maintainers for APM X-Gene v1 PCIe MSI/MSIX termination driver Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddc5a8c..a1b119b 100644 --- a/MAINTAINE

Re: [PATCH 1/1] PCI: X-Gene: assign resource to bus before adding new devices

2014-11-13 Thread Bjorn Helgaas
On Thu, Nov 06, 2014 at 05:14:18PM -0800, Duc Dang wrote: > X-Gene PCIE driver currently depends on Liviu Dudau's patch > https://lkml.org/lkml/2014/9/30/166 in order to assign resource > to root bus and endpoint devices. The patch was dropped because > it will break x86, powerpc and probably other

[PATCH 1/1] PCI: X-Gene: assign resource to bus before adding new devices

2014-11-06 Thread Duc Dang
X-Gene PCIE driver currently depends on Liviu Dudau's patch https://lkml.org/lkml/2014/9/30/166 in order to assign resource to root bus and endpoint devices. The patch was dropped because it will break x86, powerpc and probably others. So X-Gene PCIE host functionality is currently broken. This pa

[PATCH v1 09/13] PCI: Apply _HPP settings to PCIe devices as well as PCI and PCI-X

2014-09-12 Thread Bjorn Helgaas
The ACPI _HPP method was defined before PCIe existed, so its documentation only mentions PCI. The _HPX Type 0 setting record is essentially identical to _HPP, but the spec (ACPI rev 5.0, sec 6.2.8.1) says it should be applied to PCI, PCI-X, and PCIe devices, with settings being ignored if they

2.6.22.7 reboots if PCI-X eth card is used for capture

2007-10-23 Thread Michael Stiller
Hi, i run a machine with 4 dual gigabit ethernet cards utilizing 2.6.22.7. All cards are PCI-E, one card is PCI-X, all Gigabit Ethernet from Intel. This is working fine and stable if only the PCI-E cards are used. If i try to capture packets on the PCI-X card, the machine reboots after some

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-31 Thread Ulrich Windl
gt; > card is operating. As is seen here (although a bit truncated -- > > > > separate issue, I'll try to see if I can reproduce this on one of my > > > > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz > > > > (bus clock) slot. Wh

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-31 Thread Andrew Vasquez
gt; > > separate issue, I'll try to see if I can reproduce this on one of my > > > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz > > > (bus clock) slot. When operating under this mode, each data-phase > > > between two devices is divided i

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-30 Thread Ulrich Windl
> > > I have a question: The Qlogic ISP2422 chip is said to handle PCI-X > > > > 266MHz. So does > > > > the HP Itanium2 server rx6600. Basically that was the reason to select > > > > that > > > > server. The FC-HBA is in a 266 MHz capa

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-27 Thread Andrew Vasquez
I'll try to see if I can reproduce this on one of my > > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz > > (bus clock) slot. When operating under this mode, each data-phase > > between two devices is divided into 2 sub-phases, effectively doubling > > the

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-27 Thread Andrew Patterson
On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote: > On Thu, 26 Jul 2007, Andrew Patterson wrote: > > > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote: > > > Hi, > > > > > > I have a question: The Qlogic ISP2422 chip is said to handle PCI

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-26 Thread Andrew Vasquez
On Thu, 26 Jul 2007, Andrew Patterson wrote: > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote: > > Hi, > > > > I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. > > So does > > the HP Itanium2 server rx6600. Basically t

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-26 Thread Andrew Patterson
On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote: > Hi, > > I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. So > does > the HP Itanium2 server rx6600. Basically that was the reason to select that > server. The FC-HBA is in a 266 MHz capable

Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-26 Thread Ulrich Windl
Hi, I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. So does the HP Itanium2 server rx6600. Basically that was the reason to select that server. The FC-HBA is in a 266 MHz capable slot. However when booting SLES10 SP1 for IA64, the logs say: <6>QLogic Fibre C

Re: [PATCH 1/2] PCI-X/PCI-Express read control interfaces

2007-05-16 Thread Randy Dunlap
On Tue, 15 May 2007 13:59:13 +0200 Peter Oruba wrote: > This patch introduces an interface to read and write PCI-X / PCI-Express > maximum read byte count values from PCI config space. There is a second > function that returns the maximum _designed_ read byte count, which marks the

Re: [PATCH 0/2] PCI-X/PCI-Express read control interfaces - Patch correction

2007-05-16 Thread Peter Oruba
t. > > > Sorry, I missed out an essential part in the qla2xxx driver, namely the MMRBC configuration for PCI-X. The submitted patch only did that for PCIe. This is the corrected version The pre-condition check is there to not blindly call the mmrbc-functions, but to check for the bus t

Re: [PATCH 0/2] PCI-X/PCI-Express read control interfaces

2007-05-16 Thread Peter Oruba
Am Dienstag, 15. Mai 2007 21:37:21 schrieb Andrew Morton: > On Tue, 15 May 2007 13:50:27 +0200 > > "Peter Oruba" <[EMAIL PROTECTED]> wrote: > > This patch set introduces a PCI-X / PCI-Express read byte count control > > interface. Instead of letting every

Re: [PATCH 0/2] PCI-X/PCI-Express read control interfaces

2007-05-15 Thread Andrew Vasquez
On Tue, 15 May 2007, Andrew Morton wrote: > On Tue, 15 May 2007 13:50:27 +0200 > "Peter Oruba" <[EMAIL PROTECTED]> wrote: > > > This patch set introduces a PCI-X / PCI-Express read byte count control > > interface. Instead of letting every driver to directl

Re: [PATCH 0/2] PCI-X/PCI-Express read control interfaces

2007-05-15 Thread Kok, Auke
Andrew Morton wrote: On Tue, 15 May 2007 13:50:27 +0200 "Peter Oruba" <[EMAIL PROTECTED]> wrote: This patch set introduces a PCI-X / PCI-Express read byte count control interface. Instead of letting every driver to directly read/write to PCI config space for that, an inter

Re: [PATCH 2/2] PCI-X/PCI-Express read control interfaces

2007-05-15 Thread Jeff Kirsher
On 5/15/07, Peter Oruba <[EMAIL PROTECTED]> wrote: These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those valuse doesn't take place "manually", instead wrapping functions are called to allow quirks for some PCI

Re: [PATCH 0/2] PCI-X/PCI-Express read control interfaces

2007-05-15 Thread Andrew Morton
On Tue, 15 May 2007 13:50:27 +0200 "Peter Oruba" <[EMAIL PROTECTED]> wrote: > This patch set introduces a PCI-X / PCI-Express read byte count control > interface. Instead of letting every driver to directly read/write to PCI > config space for that, an interface i

[PATCH 2/2] PCI-X/PCI-Express read control interfaces

2007-05-15 Thread Peter Oruba
These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those valuse doesn't take place "manually", instead wrapping functions are called to allow quirks for some PCI bridges. Signed-off by: Peter Oruba <[EMAIL PROTECT

  1   2   >