Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

2014-02-18 Thread Geert Uytterhoeven
On Mon, Feb 17, 2014 at 10:45 PM, Kent Overstreet wrote: > *swears* Actually, I'm just going to cast this to unsigned (that's definitely > safe here): > > > commit 70bc49d421c793f73a772ae1f50622a39c6136d9 > Author: Kent Overstreet > Date: Mon Feb 17 13:44:06 2014 -0800 > > bcache: Fix anoth

Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

2014-02-17 Thread Kent Overstreet
On Mon, Feb 17, 2014 at 02:44:47PM -0800, Randy Dunlap wrote: > Could that cause a truncation? unsigned means unsigned int. > Can unsigned int be smaller (fewer bits) than the k pointer? > If so, is that OK or a problem? It's just truncating the offset of the pointer within the struct bset, which

Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

2014-02-17 Thread Randy Dunlap
On 02/17/2014 01:45 PM, Kent Overstreet wrote: > On Mon, Feb 17, 2014 at 10:11:51PM +0100, Geert Uytterhoeven wrote: >> On Mon, Feb 17, 2014 at 10:06 PM, Randy Dunlap wrote: >>> On 02/17/2014 01:00 PM, Geert Uytterhoeven wrote: On Fri, Feb 14, 2014 at 8:04 PM, Linux Kernel Mailing List

Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

2014-02-17 Thread Kent Overstreet
On Mon, Feb 17, 2014 at 10:11:51PM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 17, 2014 at 10:06 PM, Randy Dunlap wrote: > > On 02/17/2014 01:00 PM, Geert Uytterhoeven wrote: > >> On Fri, Feb 14, 2014 at 8:04 PM, Linux Kernel Mailing List > >> wrote: > >>>bcache: Minor fixes from kbuild ro

Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

2014-02-17 Thread Geert Uytterhoeven
On Mon, Feb 17, 2014 at 10:06 PM, Randy Dunlap wrote: > On 02/17/2014 01:00 PM, Geert Uytterhoeven wrote: >> On Fri, Feb 14, 2014 at 8:04 PM, Linux Kernel Mailing List >> wrote: >>>bcache: Minor fixes from kbuild robot >> >>> diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c >>

Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

2014-02-17 Thread Randy Dunlap
On 02/17/2014 01:00 PM, Geert Uytterhoeven wrote: > On Fri, Feb 14, 2014 at 8:04 PM, Linux Kernel Mailing List > wrote: >>bcache: Minor fixes from kbuild robot > >> diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c >> index 4f6b594..3f74b4b 100644 >> --- a/drivers/md/bcache/bse

New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

2014-02-17 Thread Geert Uytterhoeven
On Fri, Feb 14, 2014 at 8:04 PM, Linux Kernel Mailing List wrote: >bcache: Minor fixes from kbuild robot > diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c > index 4f6b594..3f74b4b 100644 > --- a/drivers/md/bcache/bset.c > +++ b/drivers/md/bcache/bset.c > @@ -23,7 +23,7 @@ voi