Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Andy Shevchenko
On Mon, Jan 18, 2021 at 05:40:36PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 18, 2021 at 05:27:44PM +0200, Andy Shevchenko wrote: > > On Mon, Jan 18, 2021 at 03:58:18PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Jan 18, 2021 at 04:48:53PM +0200, Andy Shevchenko wrote: > > > > On Mon, Jan 1

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Greg Kroah-Hartman
On Mon, Jan 18, 2021 at 05:27:44PM +0200, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 03:58:18PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 18, 2021 at 04:48:53PM +0200, Andy Shevchenko wrote: > > > On Mon, Jan 18, 2021 at 03:26:28PM +0100, Greg Kroah-Hartman wrote: > > > > On Mon, Jan 1

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Andy Shevchenko
On Mon, Jan 18, 2021 at 03:58:18PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 18, 2021 at 04:48:53PM +0200, Andy Shevchenko wrote: > > On Mon, Jan 18, 2021 at 03:26:28PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Jan 18, 2021 at 04:12:38PM +0200, Mika Westerberg wrote: > > > > On Mon, Jan 1

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Greg Kroah-Hartman
On Mon, Jan 18, 2021 at 04:48:53PM +0200, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 03:26:28PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 18, 2021 at 04:12:38PM +0200, Mika Westerberg wrote: > > > On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > > > > On Mon, Jan 18

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Mika Westerberg
On Mon, Jan 18, 2021 at 03:26:28PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 18, 2021 at 04:12:38PM +0200, Mika Westerberg wrote: > > Hi, > > > > On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > > > CC Mika and Andy. > > > > > > On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Fe

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Andy Shevchenko
On Mon, Jan 18, 2021 at 04:12:38PM +0200, Mika Westerberg wrote: > On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > > On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Feng > > wrote: > > > On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng > > > wrote: > > > > > > > > Commit 8765c5ba19490

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Andy Shevchenko
On Mon, Jan 18, 2021 at 03:26:28PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 18, 2021 at 04:12:38PM +0200, Mika Westerberg wrote: > > On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > > > On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Feng > > > wrote: > > > > On Sat, Jan 9, 2021

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Greg Kroah-Hartman
On Mon, Jan 18, 2021 at 04:12:38PM +0200, Mika Westerberg wrote: > Hi, > > On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > > CC Mika and Andy. > > > > On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Feng > > wrote: > > > > > > On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng > > > wr

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Mika Westerberg
Hi, On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > CC Mika and Andy. > > On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Feng > wrote: > > > > On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng > > wrote: > > > > > > Commit 8765c5ba19490 ("ACPI / scan: Rework modalias creation when >

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Rafael J. Wysocki
CC Mika and Andy. On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Feng wrote: > > On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng > wrote: > > > > Commit 8765c5ba19490 ("ACPI / scan: Rework modalias creation when > > "compatible" is present") creates two modaliases for certain ACPI > > devices. However u

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-17 Thread Kai-Heng Feng
On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng wrote: > > Commit 8765c5ba19490 ("ACPI / scan: Rework modalias creation when > "compatible" is present") creates two modaliases for certain ACPI > devices. However userspace (systemd-udevd in this case) assumes uevent > file doesn't have duplicated key

Multiple MODALIAS= in uevent file confuses userspace

2021-01-08 Thread Kai-Heng Feng
Commit 8765c5ba19490 ("ACPI / scan: Rework modalias creation when "compatible" is present") creates two modaliases for certain ACPI devices. However userspace (systemd-udevd in this case) assumes uevent file doesn't have duplicated keys, so two "MODALIAS=" breaks the assumption. Based on the assum