Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Olaf Titz
> > I suppose. Look at what you just stated! This means that a reported > > value is now worthless. > > Correct. And it was always worthless. Right. The module "use count" is not a use count, it's a lock count. E.g. a driver may well increase this counter on open and then again when in a partic

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Christoph Hellwig
In article <[EMAIL PROTECTED]> you wrote: > On Thu, 9 Nov 2000, Jeff Garzik wrote: >> There is NO guarantee that module use count == device open count. Never >> has been, AFAIK. It just happens to work out that way on a lot of >> pre-2.4 code. >> >> The kernel is free to bump the module referen

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Jeff Garzik
"Richard B. Johnson" wrote: > I suppose. Look at what you just stated! This means that a reported > value is now worthless. > > To restate, somebody decided that we didn't need this reported value > anymore. Therefore, it is okay to make it worthless. > > I don't agree. The De-facto standard has

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Richard B. Johnson
On Thu, 9 Nov 2000, Jeff Garzik wrote: > "Richard B. Johnson" wrote: > > > > On Thu, 9 Nov 2000, Brian Gerst wrote: > > > > > "Richard B. Johnson" wrote: > > > > > > > > `lsmod` shows that a device is open twice when using Linux-2.4.0-test9 > > > > when, in fact, it has been opened only once. >

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Brian Gerst
"Richard B. Johnson" wrote: > > On Thu, 9 Nov 2000, Brian Gerst wrote: > > > "Richard B. Johnson" wrote: > > > > > > `lsmod` shows that a device is open twice when using Linux-2.4.0-test9 > > > when, in fact, it has been opened only once. > > > > > > > > > > When the module is closed, the use-c

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Jeff Garzik
"Richard B. Johnson" wrote: > > On Thu, 9 Nov 2000, Brian Gerst wrote: > > > "Richard B. Johnson" wrote: > > > > > > `lsmod` shows that a device is open twice when using Linux-2.4.0-test9 > > > when, in fact, it has been opened only once. > > > > > > > > > > When the module is closed, the use-c

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Christoph Hellwig
In article <[EMAIL PROTECTED]> you wrote: > This may be, as you say, "harmless". It is, however, a bug. The > reporting must be correct or large complex systems can't be > developed or maintained. No. It is not. The module usage count doesn't have a direct relation to the number of open devices

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Richard B. Johnson
On Thu, 9 Nov 2000, Brian Gerst wrote: > "Richard B. Johnson" wrote: > > > > `lsmod` shows that a device is open twice when using Linux-2.4.0-test9 > > when, in fact, it has been opened only once. > > > > > > When the module is closed, the use-count goes to zero as expected. > > However, a si

Re: Module open() problems, Linux 2.4.0

2000-11-09 Thread Brian Gerst
"Richard B. Johnson" wrote: > > `lsmod` shows that a device is open twice when using Linux-2.4.0-test9 > when, in fact, it has been opened only once. > > lsmod is version 2.3.15, the latest-and-greatest. > > Here are the open/close routines for a module. > > /*-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Module open() problems, Linux 2.4.0

2000-11-09 Thread Richard B. Johnson
`lsmod` shows that a device is open twice when using Linux-2.4.0-test9 when, in fact, it has been opened only once. lsmod is version 2.3.15, the latest-and-greatest. Here are the open/close routines for a module. /*-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ /*