Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-23 Thread Alan Stern
On Tue, 23 Aug 2016, Vittorio Zecca wrote: > After applying the patch above the UBSAN issue in devio.c disappeared. > > However, I got the following messages in dmesg, probably due to a > NetworkManager > malfunctioning, and if I click on the NetworkManager icon I get > "NetworkManager is not ru

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-23 Thread Vittorio Zecca
After applying the patch above the UBSAN issue in devio.c disappeared. However, I got the following messages in dmesg, probably due to a NetworkManager malfunctioning, and if I click on the NetworkManager icon I get "NetworkManager is not running" but maybe this is another issue and your patch did

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-23 Thread Alan Stern
On Mon, 22 Aug 2016, Vittorio Zecca wrote: > I can reproduce the UBSAN report by inserting in the USB receptacle a > HUAWEI Mobile Broadband E353 HSPA+ USB Stick. > If there is any patch I'll be happy to try it. Thank you. Please let us know what happens with the patch below. Alan Stern Ind

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-22 Thread Vittorio Zecca
I can reproduce the UBSAN report by inserting in the USB receptacle a HUAWEI Mobile Broadband E353 HSPA+ USB Stick. Alan Stern asked for /sys/kernel/debug/usb/devices: cat debug-usb-devices T: Bus=01 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=480 MxCh= 2 B: Alloc= 0/800 us ( 0%), #Int= 0, #

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-22 Thread Alan Stern
On Mon, 22 Aug 2016, Bjørn Mork wrote: > Alan Stern writes: > > > On Mon, 22 Aug 2016, Bjørn Mork wrote: > > > >> Alan Stern writes: > >> > >> > On Sun, 21 Aug 2016, Jiri Slaby wrote: > >> > > >> >> Cc: proper lists. > >> >> > >> >> ep->desc.bInterval seems to be 0 here. > > > >> > As far as

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-22 Thread Bjørn Mork
Alan Stern writes: > On Mon, 22 Aug 2016, Bjørn Mork wrote: > >> Alan Stern writes: >> >> > On Sun, 21 Aug 2016, Jiri Slaby wrote: >> > >> >> Cc: proper lists. >> >> >> >> ep->desc.bInterval seems to be 0 here. > >> > As far as I can see, this isn't possible. The usb_parse_endpoint() >> > r

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-22 Thread Alan Stern
On Mon, 22 Aug 2016, Bjørn Mork wrote: > Alan Stern writes: > > > On Sun, 21 Aug 2016, Jiri Slaby wrote: > > > >> Cc: proper lists. > >> > >> ep->desc.bInterval seems to be 0 here. > > As far as I can see, this isn't possible. The usb_parse_endpoint() > > routine in drivers/usb/core/config.

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-22 Thread Bjørn Mork
o.c:1713 is "as->urb->interval = 1 << min(15, ep->desc.bInterval - >> > 1);") >> > >> > [ +0.354486] >> > ======== >> > [ +0.08] UBSAN: Undefined behaviour in >> > /home/vitti/1tb/vitti/rpmbuild/SOURCES/linux-4.7.2/drivers/usb/core/devio.c:

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-22 Thread Alan Stern
===== > > [ +0.08] UBSAN: Undefined behaviour in > > /home/vitti/1tb/vitti/rpmbuild/SOURCES/linux-4.7.2/drivers/usb/core/devio.c:1713:25 > > [ +0.04] shift exponent -1 is negative As far as I can see, this isn't po

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-21 Thread Jiri Slaby
ime: > > (devio.c:1713 is "as->urb->interval = 1 << min(15, ep->desc.bInterval - 1);") > > [ +0.354486] > > [ +0.08] UBSAN: Undefined behaviour in > /home/vitti/1tb/

Linux 4.7.2

2016-08-20 Thread Greg KH
Feng Li (1): iscsi-target: Fix panic when adding second TCP connection to iSCSI session Florian Echtler (2): sur40: lower poll interval to fix occasional FPS drops to ~56 FPS sur40: fix occasional oopses on device close Frank Rowand (1): of: fix memory leak related to safe_