Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 18:08, Duyck, Alexander H wrote > Okay I think I have figured it out, but I am not sure what a good > solution is. > > I think the problem is the fact that the keys may not be initialized > until init_default_flow_dissectors is called and I am not sure that is > happening before th

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 10:08 AM, Duyck, Alexander H wrote: > Okay I think I have figured it out, but I am not sure what a good > solution is. > > I think the problem is the fact that the keys may not be initialized > until init_default_flow_dissectors is called and I am not sure that is > happen

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Mon, Nov 21, 10:28, Greg KH wrote > I'm announcing the release of the 4.4.34 kernel. > > All users of the 4.4 kernel series must upgrade. This update broke PXE boot on our 4-way AMD boxes. The kernel panics in eth_type_trans(), presumably during kernel-level IP autoconfiguration, see [1]. Bise

Re: Linux 4.4.34

2016-11-22 Thread Duyck, Alexander H
On Tue, 2016-11-22 at 19:06 +0100, Andre Noll wrote: > On Tue, Nov 22, 09:56, Eric Dumazet wrote > > > > > > > > > > > > > @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > > > > memcpy(key_eth_addrs, ð->h_dest, > > > > sizeof(*key_eth_addrs)); > > > >

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 09:56, Eric Dumazet wrote > >> @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > >> memcpy(key_eth_addrs, ð->h_dest, > >> sizeof(*key_eth_addrs)); > >> } > >> > >> + barrier(); > >> again: > >> switch (proto) { > >>

Re: Linux 4.4.34

2016-11-22 Thread Duyck, Alexander H
On Tue, 2016-11-22 at 09:56 -0800, Eric Dumazet wrote: > On Tue, Nov 22, 2016 at 9:55 AM, Andre Noll wrote: > > > > On Tue, Nov 22, 09:46, Eric Dumazet wrote > > > > > > This is an aliasing problem. > > > Tom code is hard to read and understand. > > > > > > Andre, could you try : > > > > > > d

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 9:55 AM, Andre Noll wrote: > On Tue, Nov 22, 09:46, Eric Dumazet wrote >> This is an aliasing problem. >> Tom code is hard to read and understand. >> >> Andre, could you try : >> >> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c >> index 69e4463a4b1b..b0

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 18:06, Greg KH wrote > On Tue, Nov 22, 2016 at 05:59:12PM +0100, Andre Noll wrote: > > On Mon, Nov 21, 10:28, Greg KH wrote > > > I'm announcing the release of the 4.4.34 kernel. > > > > > > All users of the 4.4 kernel series must upgrade. > > > > This update broke PXE boot on our

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 09:14, Eric Dumazet wrote > We definitely want to fix the real bug, not working around it. > > Seems an aliasing problem, key_control and key_basic might point to > adjacent memory > and a barrier() would solve the issue as well. This was also my first idea. I added some printk st

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 09:46, Eric Dumazet wrote > This is an aliasing problem. > Tom code is hard to read and understand. > > Andre, could you try : > > diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c > index 69e4463a4b1b..b045980faaea 100644 > --- a/net/core/flow_dissector.c > +++ b

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
. > > I was wondering if we shouldn't just cap all cases? > > It seems like this could potentially return a value greater than skb- >>len in the "good" case since things like IP header length isn't > validated other then making sure it meets the minimum value, and if > there isn't a recognized L4 h

Re: Linux 4.4.34

2016-11-22 Thread Duyck, Alexander H
On Tue, 2016-11-22 at 09:14 -0800, Eric Dumazet wrote: > On Tue, Nov 22, 2016 at 9:06 AM, Greg KH wrote: > > > > On Tue, Nov 22, 2016 at 05:59:12PM +0100, Andre Noll wrote: > > > > > > On Mon, Nov 21, 10:28, Greg KH wrote > > > > > > > > I'm announcing the release of the 4.4.34 kernel. > > > >

Re: Linux 4.4.34

2016-11-22 Thread Greg KH
On Tue, Nov 22, 2016 at 06:22:47PM +0100, Andre Noll wrote: > On Tue, Nov 22, 18:06, Greg KH wrote > > On Tue, Nov 22, 2016 at 05:59:12PM +0100, Andre Noll wrote: > > > On Mon, Nov 21, 10:28, Greg KH wrote > > > > I'm announcing the release of the 4.4.34 kernel. > > > > > > > > All users of the 4.

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 9:22 AM, Andre Noll wrote: > On Tue, Nov 22, 18:06, Greg KH wrote >> On Tue, Nov 22, 2016 at 05:59:12PM +0100, Andre Noll wrote: >> > On Mon, Nov 21, 10:28, Greg KH wrote >> > > I'm announcing the release of the 4.4.34 kernel. >> > > >> > > All users of the 4.4 kernel serie

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 9:06 AM, Greg KH wrote: > On Tue, Nov 22, 2016 at 05:59:12PM +0100, Andre Noll wrote: >> On Mon, Nov 21, 10:28, Greg KH wrote >> > I'm announcing the release of the 4.4.34 kernel. >> > >> > All users of the 4.4 kernel series must upgrade. >> >> This update broke PXE boot on

Re: Linux 4.4.34

2016-11-22 Thread Greg KH
On Tue, Nov 22, 2016 at 05:59:12PM +0100, Andre Noll wrote: > On Mon, Nov 21, 10:28, Greg KH wrote > > I'm announcing the release of the 4.4.34 kernel. > > > > All users of the 4.4 kernel series must upgrade. > > This update broke PXE boot on our 4-way AMD boxes. The kernel panics in > eth_type_t

Re: Linux 4.4.34

2016-11-21 Thread Greg KH
diff --git a/Makefile b/Makefile index a513c045c8de..30924aabf1b4 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ VERSION = 4 PATCHLEVEL = 4 -SUBLEVEL = 33 +SUBLEVEL = 34 EXTRAVERSION = NAME = Blurry Fish Butt diff --git a/arch/sparc/include/asm/mmu_64.h b/arch/sparc/include/asm/mmu_64.h

Linux 4.4.34

2016-11-21 Thread Greg KH
take care of truncations done by sk_filter() Florian Westphal (1): dctcp: avoid bogus doubling of cwnd after loss Greg Kroah-Hartman (1): Linux 4.4.34 James Clarke (1): sparc: Handle negative offsets in arch_jump_label_transform Marcelo Ricardo Leitner (1): sctp: assign assoc_