Re: Linux 4.18-rc7

2018-08-02 Thread John Stultz
On Wed, Aug 1, 2018 at 2:55 PM, Hugh Dickins wrote: > On Wed, 1 Aug 2018, Kirill A. Shutemov wrote: >> On Wed, Aug 01, 2018 at 11:31:52AM -0700, Hugh Dickins wrote: >> > On Wed, 1 Aug 2018, Linus Torvalds wrote: >> > > >> > > Anyway, the upshot of all this is that I think I know what the ia64 >> >

Re: Linux 4.18-rc7

2018-08-02 Thread Amit Pundir
On Wed, 1 Aug 2018 at 22:45, Linus Torvalds wrote: > > I'd like to get this sorted out asap, although at this point I still > think that I'll have to do an rc8 even though I feel like we may have > caught everything. No AOSP regressions in my limited smoke testing so far with current HEAD: 6b4703

Re: Linux 4.18-rc7

2018-08-01 Thread Hugh Dickins
On Wed, 1 Aug 2018, Kirill A. Shutemov wrote: > On Wed, Aug 01, 2018 at 11:31:52AM -0700, Hugh Dickins wrote: > > On Wed, 1 Aug 2018, Linus Torvalds wrote: > > > > > > Anyway, the upshot of all this is that I think I know what the ia64 > > > problem was, and John sent the patch for the ashmem case

Re: Linux 4.18-rc7

2018-08-01 Thread Kirill A. Shutemov
On Wed, Aug 01, 2018 at 01:56:19PM -0700, Linus Torvalds wrote: > On Wed, Aug 1, 2018 at 1:52 PM Kirill A. Shutemov > wrote: > > > > Is there a reason why we pass vma to flush_tlb_range? > > Yes. It's even in that patch. > > The fact is, real MM users *have* a vma, and passing it in to the TLB

Re: Linux 4.18-rc7

2018-08-01 Thread Kirill A. Shutemov
On Wed, Aug 01, 2018 at 11:31:52AM -0700, Hugh Dickins wrote: > On Wed, 1 Aug 2018, Linus Torvalds wrote: > > > > Anyway, the upshot of all this is that I think I know what the ia64 > > problem was, and John sent the patch for the ashmem case, and I'm > > going to hold off reverting that vma_is_an

Re: Linux 4.18-rc7

2018-08-01 Thread Linus Torvalds
On Wed, Aug 1, 2018 at 1:52 PM Kirill A. Shutemov wrote: > > Is there a reason why we pass vma to flush_tlb_range? Yes. It's even in that patch. The fact is, real MM users *have* a vma, and passing it in to the TLB flushing is the right thing to do. That allows architectures that care (mainly po

Re: Linux 4.18-rc7

2018-08-01 Thread Kirill A. Shutemov
On Wed, Aug 01, 2018 at 01:05:48PM -0700, Linus Torvalds wrote: > On Wed, Aug 1, 2018 at 10:15 AM Linus Torvalds > wrote: > > > > I'm still unhappy about the vma_init() ones, and I have not decided > > how to go with those. Either the memset() in vma_init(), or just > > reverting the (imho unneces

Re: Linux 4.18-rc7

2018-08-01 Thread Linus Torvalds
On Wed, Aug 1, 2018 at 10:15 AM Linus Torvalds wrote: > > I'm still unhappy about the vma_init() ones, and I have not decided > how to go with those. Either the memset() in vma_init(), or just > reverting the (imho unnecessary) commit 2c4541e24c55. Kirill, Andrew, > comments? Ugh. Adding a memset

Re: Linux 4.18-rc7

2018-08-01 Thread Luck, Tony
On Wed, Aug 01, 2018 at 10:15:05AM -0700, Linus Torvalds wrote: > Tony, can you please double-check my commit ebad825cdd4e ("ia64: mark > special ia64 memory areas anonymous") fixes things for you? I didn't > even compile it, but it really looks so obvious that I just committed > it directly. It's

Re: Linux 4.18-rc7

2018-08-01 Thread Hugh Dickins
On Wed, 1 Aug 2018, Linus Torvalds wrote: > > Anyway, the upshot of all this is that I think I know what the ia64 > problem was, and John sent the patch for the ashmem case, and I'm > going to hold off reverting that vma_is_anonymous() false-positives > commit after all. I'd better send deletion

Re: Linux 4.18-rc7

2018-08-01 Thread Linus Torvalds
On Tue, Jul 31, 2018 at 10:43 AM Luck, Tony wrote: > > On Tue, Jul 31, 2018 at 08:03:28PM +0300, Kirill A. Shutemov wrote: > > But it's not the only issue unfortunately. Tony reported issue with > > booting ia64 with the patch. I have no clue why. I rechecked everything > > ia64-specific and looks

Re: Linux 4.18-rc7

2018-07-31 Thread Hugh Dickins
On Tue, 31 Jul 2018, Kirill A. Shutemov wrote: > On Tue, Jul 31, 2018 at 09:29:27AM +0300, Kirill A. Shutemov wrote: > > On Mon, Jul 30, 2018 at 06:01:26PM -0700, Linus Torvalds wrote: > > > > > > So to me it looks like a historical check that simply doesn't > > > "normally" trigger, but there's n

Re: Linux 4.18-rc7

2018-07-31 Thread youling 257
my x86 report isPrevious: true Build: Android-x86/android_x86/x86:8.1.0/OPM6.171019.030.B1/cwhuang0618:userdebug/test-keys Hardware: unknown Revision: 0 Bootloader: unknown Radio: unknown Kernel: Linux version 4.18.0-rc7-android-x86_64+ (root@localhost) (gcc version 8.2.0 (Ubuntu 8.2.0-1ubuntu2))

Re: Linux 4.18-rc7

2018-07-31 Thread youling 257
Build fingerprint: 'Android-x86/android_x86/x86:8.1.0/OPM6.171019.030.B1/cwhuang0618:userdebug/test-keys' Revision: '0' ABI: 'x86' pid: 2899, tid: 2899, name: zygote >>> zygote <<< signal 7 (SIGBUS), code 2 (BUS_ADRERR), fault addr 0xec8 eax ebx f0274a40 ecx 01e0 edx 0ec8

Re: Linux 4.18-rc7

2018-07-31 Thread Linus Torvalds
On Tue, Jul 31, 2018 at 10:43 AM Luck, Tony wrote: > > If I just revert bfd40eaff5ab ("mm: fix vma_is_anonymous() false-positives") > then ia64 boots again. Ok, so it's not just the ashmem thing. I think I'll do an rc8 with the revert, just so that we'll have some time to figure this out. It's o

Re: Linux 4.18-rc7

2018-07-31 Thread Luck, Tony
On Tue, Jul 31, 2018 at 08:03:28PM +0300, Kirill A. Shutemov wrote: > But it's not the only issue unfortunately. Tony reported issue with > booting ia64 with the patch. I have no clue why. I rechecked everything > ia64-specific and looks fine to me. :-/ If I just revert bfd40eaff5ab ("mm: fix vma_

Re: Linux 4.18-rc7

2018-07-31 Thread Kirill A. Shutemov
On Tue, Jul 31, 2018 at 09:29:22AM -0700, Linus Torvalds wrote: > On Mon, Jul 30, 2018 at 11:40 PM Amit Pundir wrote: > > > > This ashmem change ^^ worked too. > > Ok, let's go for that one and hope it's the only one. > > John, can I get a proper commit message and sign-off for that ashmem chang

Re: Linux 4.18-rc7

2018-07-31 Thread John Stultz
On Tue, Jul 31, 2018 at 9:29 AM, Linus Torvalds wrote: > On Mon, Jul 30, 2018 at 11:40 PM Amit Pundir wrote: >> >> This ashmem change ^^ worked too. > > Ok, let's go for that one and hope it's the only one. > > John, can I get a proper commit message and sign-off for that ashmem change? Will do.

Re: Linux 4.18-rc7

2018-07-31 Thread Linus Torvalds
On Mon, Jul 30, 2018 at 11:40 PM Amit Pundir wrote: > > This ashmem change ^^ worked too. Ok, let's go for that one and hope it's the only one. John, can I get a proper commit message and sign-off for that ashmem change? Kirill - you mentioned that somebody reproduced a problem on x86-64 too. I

Re: Linux 4.18-rc7

2018-07-31 Thread Kirill A. Shutemov
On Tue, Jul 31, 2018 at 09:29:27AM +0300, Kirill A. Shutemov wrote: > On Mon, Jul 30, 2018 at 06:01:26PM -0700, Linus Torvalds wrote: > > On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: > > > > > > I have no problem with reverting -rc7's vma_is_anonymous() series. > > > > I don't think we nee

Re: Linux 4.18-rc7

2018-07-30 Thread Kirill A. Shutemov
On Tue, Jul 31, 2018 at 12:10:06PM +0530, Amit Pundir wrote: > On Tue, 31 Jul 2018 at 09:55, John Stultz wrote: > > > > On Mon, Jul 30, 2018 at 8:26 PM, Hugh Dickins wrote: > > > On Mon, 30 Jul 2018, Linus Torvalds wrote: > > >> On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: > > >> > > > >>

Re: Linux 4.18-rc7

2018-07-30 Thread Amit Pundir
On Tue, 31 Jul 2018 at 09:55, John Stultz wrote: > > On Mon, Jul 30, 2018 at 8:26 PM, Hugh Dickins wrote: > > On Mon, 30 Jul 2018, Linus Torvalds wrote: > >> On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: > >> > > >> > I have no problem with reverting -rc7's vma_is_anonymous() series. > >>

Re: Linux 4.18-rc7

2018-07-30 Thread Kirill A. Shutemov
On Mon, Jul 30, 2018 at 06:01:26PM -0700, Linus Torvalds wrote: > On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: > > > > I have no problem with reverting -rc7's vma_is_anonymous() series. > > I don't think we need to revert the whole series: I think the rest are > all fairly obvious cleanups

Re: Linux 4.18-rc7

2018-07-30 Thread John Stultz
On Mon, Jul 30, 2018 at 8:26 PM, Hugh Dickins wrote: > On Mon, 30 Jul 2018, Linus Torvalds wrote: >> On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: >> > >> > I have no problem with reverting -rc7's vma_is_anonymous() series. >> >> I don't think we need to revert the whole series: I think the

Re: Linux 4.18-rc7

2018-07-30 Thread Hugh Dickins
On Mon, 30 Jul 2018, Linus Torvalds wrote: > On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: > > > > I have no problem with reverting -rc7's vma_is_anonymous() series. > > I don't think we need to revert the whole series: I think the rest are > all fairly obvious cleanups, and shouldn't reall

Re: Linux 4.18-rc7

2018-07-30 Thread Linus Torvalds
On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: > > I have no problem with reverting -rc7's vma_is_anonymous() series. I don't think we need to revert the whole series: I think the rest are all fairly obvious cleanups, and shouldn't really have any semantic changes. It's literally only that

Re: Linux 4.18-rc7

2018-07-30 Thread Hugh Dickins
On Mon, 30 Jul 2018, Linus Torvalds wrote: > On Mon, Jul 30, 2018 at 6:01 AM Kirill A. Shutemov > wrote: > > > > I think I missed vma_set_anonymous() somewhere, but I fail to see where. > > Honestly, by now we just need to revert that commit. > > It's not even clear that it was a good idea to b

Re: Linux 4.18-rc7

2018-07-30 Thread Linus Torvalds
On Mon, Jul 30, 2018 at 6:01 AM Kirill A. Shutemov wrote: > > I think I missed vma_set_anonymous() somewhere, but I fail to see where. Honestly, by now we just need to revert that commit. It's not even clear that it was a good idea to begin with. The rest of the commits were cleanups, this one w

Re: Linux 4.18-rc7

2018-07-30 Thread Amit Pundir
On Mon, 30 Jul 2018 at 18:31, Kirill A. Shutemov wrote: > > On Mon, Jul 30, 2018 at 12:17:46PM +0530, Amit Pundir wrote: > > On Mon, 30 Jul 2018 at 03:39, Linus Torvalds > > wrote: > > > > > > So unless something odd happens, this should be the last rc for 4.18. > > > > > > Nothing particularly o

Re: Linux 4.18-rc7

2018-07-30 Thread Guenter Roeck
On Sun, Jul 29, 2018 at 03:09:05PM -0700, Linus Torvalds wrote: > So unless something odd happens, this should be the last rc for 4.18. > > Nothing particularly odd happened this last week - we got the usual > random set of various minor fixes all over. About two thirds of it is > drivers - networ

Re: Linux 4.18-rc7

2018-07-30 Thread Kirill A. Shutemov
On Mon, Jul 30, 2018 at 12:17:46PM +0530, Amit Pundir wrote: > On Mon, 30 Jul 2018 at 03:39, Linus Torvalds > wrote: > > > > So unless something odd happens, this should be the last rc for 4.18. > > > > Nothing particularly odd happened this last week - we got the usual > > random set of various m

Re: Linux 4.18-rc7

2018-07-29 Thread Amit Pundir
On Mon, 30 Jul 2018 at 03:39, Linus Torvalds wrote: > > So unless something odd happens, this should be the last rc for 4.18. > > Nothing particularly odd happened this last week - we got the usual > random set of various minor fixes all over. About two thirds of it is > drivers - networking, stag

Linux 4.18-rc7

2018-07-29 Thread Linus Torvalds
n" Kirill A. Shutemov (3): mm: introduce vma_init() mm: use vma_init() to initialize VMAs on stack and data segments mm: fix vma_is_anonymous() false-positives Li Wang (1): zswap: re-check zswap_is_full() after do zswap_shrink() Linus Torvalds (2): squashfs: be more