Re: Linux 3.6-rc5

2012-09-10 Thread Romain Francoise
Herbert Xu writes: > Thanks! I think this patch should fix the problem. Can someone > please confirm this? Works for me as well, thanks! > crypto: authenc - Fix crash with zero-length assoc data > > The authenc code doesn't deal with zero-length associated data > correctly and ends up construc

Re: Linux 3.6-rc5

2012-09-09 Thread Mathias Krause
On Sun, Sep 09, 2012 at 02:00:00PM -0700, Herbert Xu wrote: > On Sun, Sep 09, 2012 at 10:09:10PM +0200, Mathias Krause wrote: > > > > It happens with the C variants of SHA1 and AES, too. You can easily > > trigger the bug with Steffen's crconf[1]: > > > > $ crconf add alg "authenc(hmac(sha1-generi

Re: Linux 3.6-rc5

2012-09-09 Thread Herbert Xu
On Sun, Sep 09, 2012 at 11:54:04PM +0300, Jussi Kivilinna wrote: > > It seems that authenc is chaining empty assoc scatterlist, which causes > BUG_ON(!sg->length) set off in crypto/scatterwalk.c. > > Following fixes the bug and self-test passes, but not sure if it's correct > (note, copy-paste to

Re: Linux 3.6-rc5

2012-09-09 Thread Herbert Xu
On Sun, Sep 09, 2012 at 10:09:10PM +0200, Mathias Krause wrote: > > It happens with the C variants of SHA1 and AES, too. You can easily > trigger the bug with Steffen's crconf[1]: > > $ crconf add alg "authenc(hmac(sha1-generic),cbc(aes-generic))" type 3 > > So the problem is likely not related t

Re: Linux 3.6-rc5

2012-09-09 Thread Jussi Kivilinna
Quoting Herbert Xu : On Sun, Sep 09, 2012 at 08:35:56AM -0700, Linus Torvalds wrote: On Sun, Sep 9, 2012 at 5:54 AM, Jussi Kivilinna wrote: > > Does reverting e46e9a46386bca8e80a6467b5c643dc494861896 help? > > That commit added crypto selftest for authenc(hmac(sha1),cbc(aes)) in 3.6, > and pro

Re: Linux 3.6-rc5

2012-09-09 Thread Jussi Kivilinna
Quoting Herbert Xu : Can you try blacklisting/not loading sha1_ssse3 and aesni_intel to see which one of them is causing this crash? Of course if you can still reproduce this without loading either of them that would also be interesting to know. This triggers with aes-x86_64 and sha1_generic

Re: Linux 3.6-rc5

2012-09-09 Thread Mathias Krause
On Sun, Sep 09, 2012 at 12:19:58PM -0700, Herbert Xu wrote: > On Sun, Sep 09, 2012 at 11:13:02AM +0200, Romain Francoise wrote: > > Still seeing this BUG with -rc5, that I originally reported here: > > http://marc.info/?l=linux-crypto-vger&m=134653220530264&w=2 > > > > [ 26.362567] [

Re: Linux 3.6-rc5

2012-09-09 Thread Herbert Xu
On Sun, Sep 09, 2012 at 11:13:02AM +0200, Romain Francoise wrote: > Still seeing this BUG with -rc5, that I originally reported here: > http://marc.info/?l=linux-crypto-vger&m=134653220530264&w=2 > > [ 26.362567] [ cut here ] > [ 26.362583] kernel BUG at crypto/scatterw

Re: Linux 3.6-rc5

2012-09-09 Thread Herbert Xu
On Sun, Sep 09, 2012 at 08:35:56AM -0700, Linus Torvalds wrote: > On Sun, Sep 9, 2012 at 5:54 AM, Jussi Kivilinna > wrote: > > > > Does reverting e46e9a46386bca8e80a6467b5c643dc494861896 help? > > > > That commit added crypto selftest for authenc(hmac(sha1),cbc(aes)) in 3.6, > > and probably made

Re: Linux 3.6-rc5

2012-09-09 Thread Linus Torvalds
On Sun, Sep 9, 2012 at 5:54 AM, Jussi Kivilinna wrote: > > Does reverting e46e9a46386bca8e80a6467b5c643dc494861896 help? > > That commit added crypto selftest for authenc(hmac(sha1),cbc(aes)) in 3.6, > and probably made this bug visible (but not directly causing it). So Romain said it does - wher

Re: Linux 3.6-rc5

2012-09-09 Thread Romain Francoise
Jussi Kivilinna writes: > Does reverting e46e9a46386bca8e80a6467b5c643dc494861896 help? It does, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: Linux 3.6-rc5

2012-09-09 Thread Jussi Kivilinna
Quoting Romain Francoise : Still seeing this BUG with -rc5, that I originally reported here: http://marc.info/?l=linux-crypto-vger&m=134653220530264&w=2 Does reverting e46e9a46386bca8e80a6467b5c643dc494861896 help? That commit added crypto selftest for authenc(hmac(sha1),cbc(aes)) in 3.6, a

Re: Linux 3.6-rc5

2012-09-09 Thread Romain Francoise
Still seeing this BUG with -rc5, that I originally reported here: http://marc.info/?l=linux-crypto-vger&m=134653220530264&w=2 [ 26.362567] [ cut here ] [ 26.362583] kernel BUG at crypto/scatterwalk.c:37! [ 26.362606] invalid opcode: [#1] SMP [ 26.362622] Modul

Linux 3.6-rc5

2012-09-08 Thread Linus Torvalds
(2): mmc: mxs-mmc: fix deadlock in SDIO IRQ case mmc: mxs-mmc: fix deadlock caused by recursion loop Linus Torvalds (1): Linux 3.6-rc5 Linus Walleij (1): ARM: gemini: fix the gemini build Ludovic Desroches (4): ARM: at91: fix system timer irq issue due to sparse irq sup