Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-31 Thread Bill Davidsen
Patrick McHardy wrote: David S. Miller wrote: I've forwarded this to netfilter-devel for inspection. Thanks for collecting all the data points so well. Here is the fix for everyone. Please report back if it doesn't solve the problem. Thanks. Worked here. ---

Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-28 Thread Art Haas
On Fri, Jan 28, 2005 at 02:33:10AM +0100, Patrick McHardy wrote: > Here is the fix for everyone. Please report back if it doesn't > solve the problem. Thanks. > > [ ... snip ... ] Success!!! Art Haas -- Man once surrendering his reason, has no remaining guard against absurdities the most monstr

Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-27 Thread Rusty Russell
On Fri, 2005-01-28 at 02:33 +0100, Patrick McHardy wrote: > David S. Miller wrote: > > >I've forwarded this to netfilter-devel for inspection. > >Thanks for collecting all the data points so well. > > > Here is the fix for everyone. Please report back if it doesn't > solve the problem. Thanks. Ve

Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-27 Thread Patrick McHardy
David S. Miller wrote: I've forwarded this to netfilter-devel for inspection. Thanks for collecting all the data points so well. Here is the fix for everyone. Please report back if it doesn't solve the problem. Thanks. = net/ipv4/netfilter/ip_nat_proto_tcp.c 1.10 vs edited = --- 1.10/net/i

Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-27 Thread David S. Miller
I've forwarded this to netfilter-devel for inspection. Thanks for collecting all the data points so well. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-27 Thread David Brownell
I just got an interesting "I see these problems too" report. It may provide a useful clue. According to "Art Haas" <[EMAIL PROTECTED]>: > I'm running the current BK kernel now, and I'm not seeing the problems > right now because, I found, I do not have some of the IP masquerading > modules insta

Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-27 Thread Janos Farkas
On 2005-01-27 at 11:28:48, David Brownell wrote: > > Indeed, I had to shuffle my machines around a bit to get a proof that > > something is broken, but now I can confirm the above with a connection > > to cvs.sourceforge.net: > > Thanks for confirming it wasn't just me ... I confess I'm a bit > su

Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-27 Thread David Brownell
On Thursday 27 January 2005 1:02 am, Janos Farkas wrote: > On 2005-01-25 at 10:54:36, David Brownell wrote: > > On Tuesday 25 January 2005 10:35 am, David Ford wrote: > > > PMTU bug -- or better said, bad firewall admin who blocks all ICMP. > > > > PMTU bug, sure -- but one that came late in RC2.

2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2)

2005-01-27 Thread Janos Farkas
On 2005-01-25 at 10:54:36, David Brownell wrote: > On Tuesday 25 January 2005 10:35 am, David Ford wrote: > > PMTU bug -- or better said, bad firewall admin who blocks all ICMP. > > PMTU bug, sure -- but one that came late in RC2. Remember: same firewall > in both cases, but only RC2 breaks. Th

Re: Linux 2.6.11-rc2

2005-01-25 Thread David Brownell
On Tuesday 25 January 2005 10:35 am, David Ford wrote: > PMTU bug -- or better said, bad firewall admin who blocks all ICMP. PMTU bug, sure -- but one that came late in RC2. Remember: same firewall in both cases, but only RC2 breaks. The ICMP packet has landed in the RC2 system, which ignores i

Re: Linux 2.6.11-rc2

2005-01-25 Thread David Ford
PMTU bug -- or better said, bad firewall admin who blocks all ICMP. http://blue-labs.org/clue/mtu-mss.php -david David Brownell wrote: I'm seeing a problem with TCP as accessed through KMail (SuSE 9.2, x86_64). But oddly enough, only for sending mail, not reading it; and not through other (reading)

Re: Linux 2.6.11-rc2: vmnet breaks; put skb_copy_datagram b

2005-01-25 Thread Sytse Wielinga
On Tue, Jan 25, 2005 at 02:46:56AM +0100, Petr Vandrovec wrote: > On 25 Jan 05 at 1:41, Sytse Wielinga wrote: > > Linus, could you please put skb_copy_datagram back in place? It's not used > > anymore in the kernel, but the vmnet module (in vmware) still uses this > > interface to skb_copy_datagram

Re: Linux 2.6.11-rc2: vmnet breaks; put skb_copy_datagram back in place

2005-01-24 Thread Christoph Hellwig
On Tue, Jan 25, 2005 at 01:41:17AM +0100, Sytse Wielinga wrote: > Linus, could you please put skb_copy_datagram back in place? It's not used > anymore in the kernel, but the vmnet module (in vmware) still uses this > interface to skb_copy_datagram_iovec. > > Patch for 2.6.11-rc2 follows. It compil

Re: Linux 2.6.11-rc2: vmnet breaks; put skb_copy_datagram b

2005-01-24 Thread Petr Vandrovec
On 25 Jan 05 at 1:41, Sytse Wielinga wrote: > Linus, could you please put skb_copy_datagram back in place? It's not used > anymore in the kernel, but the vmnet module (in vmware) still uses this > interface to skb_copy_datagram_iovec. There is no reason for doing this. Just grab latest vmmon & vm

Re: Linux 2.6.11-rc2: vmnet breaks; put skb_copy_datagram back in place

2005-01-24 Thread Sytse Wielinga
Linus, could you please put skb_copy_datagram back in place? It's not used anymore in the kernel, but the vmnet module (in vmware) still uses this interface to skb_copy_datagram_iovec. Patch for 2.6.11-rc2 follows. It compiles cleanly; I have not tested it yet, but I assume it's okay. I'll test it

Re: Linux 2.6.11-rc2

2005-01-24 Thread David Brownell
On Monday 24 January 2005 10:05 am, Martin Josefsson wrote: > On Sun, 2005-01-23 at 22:51 -0800, David Brownell wrote: > > ... > > - Each gets an ICMP destination unreachable, frag needed, next hop MTU 1492 > > - ... all retransmits are 1500 bytes not 1492, triggering ICMPs ... > > > > Naturally

Re: Linux 2.6.11-rc2 (compile stats)

2005-01-24 Thread John Cherry
Linux 2.6 Compile Statistics (gcc 3.4.1) Web page with links to complete details: http://developer.osdl.org/cherry/compile/ Kernel bzImagebzImage bzImage modules bzImage modules (defconfig) (allno) (allyes) (allyes) (allmod) (allmod) --- --- --

Re: Linux 2.6.11-rc2

2005-01-24 Thread Magnus Määttä
Hi, On Monday 24 January 2005 11.43, Adrian Bunk wrote: > On Sun, Jan 23, 2005 at 10:11:45PM +0100, Magnus Määttä wrote: > > Hello > > Hi Magnus, > > > It doesn't compile here, here's the error: > > > > CC net/sched/sch_generic.o > > net/sched/sch_generic.c: In function `qdisc_restart': > >

Re: Linux 2.6.11-rc2

2005-01-24 Thread Martin Josefsson
On Sun, 2005-01-23 at 22:51 -0800, David Brownell wrote: > I'm seeing a problem with TCP as accessed through KMail (SuSE 9.2, x86_64). > But oddly enough, only for sending mail, not reading it; and not through > other (reading) applications... it's a regression with respect to rc1 and > earlier ker

Re: Linux 2.6.11-rc2

2005-01-24 Thread Adrian Bunk
On Sun, Jan 23, 2005 at 10:11:45PM +0100, Magnus Määttä wrote: > Hello Hi Magnus, > > It doesn't compile here, here's the error: > > CC net/sched/sch_generic.o > net/sched/sch_generic.c: In function `qdisc_restart': > net/sched/sch_generic.c:128: error: label `requeue' used but not > d

Re: Linux 2.6.11-rc2

2005-01-23 Thread David Brownell
I'm seeing a problem with TCP as accessed through KMail (SuSE 9.2, x86_64). But oddly enough, only for sending mail, not reading it; and not through other (reading) applications... it's a regression with respect to rc1 and earlier kernels. Basically, it can only send REALLY TINY emails... What et

Re: Linux 2.6.11-rc2

2005-01-23 Thread Magnus Määttä
Hello On Saturday 22 January 2005 03.13, Linus Torvalds wrote: > Ok, trying to calm things down again for a 2.6.11 release. > > Tons of small cleanups, annotations and fixes here. Driver updates, > cpufreq, ppc, parisc, arm.. Pls check that I got it all. > > Linus > It doesn't compile here, her

Re: Linux 2.6.11-rc2

2005-01-23 Thread sean
This patch worked. Or at least it built. Thanks for the quick response. sean Martin Josefsson wrote: Try this patch: diff -X dontdiff.ny -urNp linux-2.6.11-rc2.orig/include/linux/netfilter_ipv4/ip_conntrack_tftp.h linux-2.6.11-rc2/include/linux/netfilter_ipv4/ip_conntrack_tftp.h --- linux-2.6.11

Re: Linux 2.6.11-rc2

2005-01-22 Thread Martin Josefsson
rack_tftp.o(.bss+0x0): first defined here > make[3]: *** [net/ipv4/netfilter/built-in.o] Error 1 > make[2]: *** [net/ipv4/netfilter] Error 2 Ok, another problem intriduced by the recent patches... sigh Try this patch: diff -X dontdiff.ny -urNp linux-2.6.11-rc2.orig/include/linux/netfilt

Re: Linux 2.6.11-rc2

2005-01-22 Thread sean
Martin Josefsson wrote: On Fri, 2005-01-21 at 22:32 -0800, Udo A. Steinberg wrote: On Fri, 21 Jan 2005 18:13:55 -0800 (PST) Linus Torvalds (LT) wrote: LT> Ok, trying to calm things down again for a 2.6.11 release. Connection tracking does not compile... CC net/ipv4/netfilter/ip_conntrack_stand

Re: Linux 2.6.11-rc2

2005-01-22 Thread Linus Torvalds
On Sat, 22 Jan 2005, Udo A. Steinberg wrote: > > Linus, please apply the following patch from Martin. Please go through Davem, he's quite responsive, but prefers things like this to be sent to the netdev mailing list too if it hasn't been there already (netdev@oss.sgi.com). L

Re: Linux 2.6.11-rc2

2005-01-22 Thread Udo A. Steinberg
compile both with and without NAT MJ> now. Thanks, this fixes my problem, too. Linus, please apply the following patch from Martin. -Udo. diff -X /home/gandalf/dontdiff.ny -urNp linux-2.6.11-rc2.orig/include/linux/netfilter_ipv4/ip_conntrack.h linux-2.6.11-rc2/include/linux/netfilter_ipv4/

Re: Linux 2.6.11-rc2

2005-01-22 Thread Martin Josefsson
On Sat, 2005-01-22 at 12:57 -0800, Udo A. Steinberg wrote: > On Sat, 22 Jan 2005 15:04:29 +0100 Martin Josefsson (MJ) wrote: > > MJ> On Fri, 2005-01-21 at 22:32 -0800, Udo A. Steinberg wrote: > MJ> > > MJ> > Connection tracking does not compile... > > MJ> The problem is when compiling without NA

Re: Linux 2.6.11-rc2

2005-01-22 Thread Martin Josefsson
v4/ip_conntrack.h:307: error: (Each undeclared > identifier is reported only once > include/linux/netfilter_ipv4/ip_conntrack.h:307: error: for each function it > appears in.) The problem is when compiling without NAT... The patch below should fix it, I can compile both with and without NAT now.

Re: Linux 2.6.11-rc2

2005-01-21 Thread Udo A. Steinberg
On Fri, 21 Jan 2005 18:13:55 -0800 (PST) Linus Torvalds (LT) wrote: LT> Ok, trying to calm things down again for a 2.6.11 release. Connection tracking does not compile... CC net/ipv4/netfilter/ip_conntrack_standalone.o In file included from net/ipv4/netfilter/ip_conntrack_standalone.c:34:

Linux 2.6.11-rc2

2005-01-21 Thread Linus Torvalds
rt "Don't busy-lock-loop in preemptable spinlocks" patch o Remove old debugging tests o Remove broken-as-designed "rwlock_is_locked()" macro o Revert "x86_64/i386: increase command line size" patch o ppc64: rwlock *_can_lock() primitives o ia64: rwlock *_c