Re: Linux 2.4.30-rc2

2005-03-27 Thread Andi Kleen
Willy Tarreau <[EMAIL PROTECTED]> writes: > Marcelo, > > just another one and that's all. Zachary Amsden found an unconditional > write to a debug register in the signal delivery path which is only > needed when we use a breakpoint. This is a very expensive operation on > x86, and doing it conditi

Re: Linux 2.4.30-rc2

2005-03-26 Thread David S. Miller
This should go through Jeff Garzik, at least let him review and look over it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://ww

Re: Linux 2.4.30-rc2 - fix for CAN-2005-0794: Potential DOS in load_elf_library

2005-03-26 Thread Marcelo Tosatti
On Sat, Mar 26, 2005 at 01:14:01PM +0100, Andreas Arens wrote: > Hi Marcelo, Herbert, > > I'm just reading the patch so don't know of any hidden side-effects which > might cure it, but this clearly looks like a possibly deadlocking typo in > fs/binfmt_elf.c to me: > > > >- while (elf_phdata

Re: Linux 2.4.30-rc2

2005-03-26 Thread Marcelo Tosatti
On Sat, Mar 26, 2005 at 12:44:53PM +0100, Arjan van de Ven wrote: > On Sat, 2005-03-26 at 12:22 +0100, Willy Tarreau wrote: > > Marcelo, > > > > here's a patch from Dave Jones, which is already in 2.6 and which I've > > used in my local tree for 6 months now. It removes a useless NULL check > > in

Re: Linux 2.4.30-rc2

2005-03-26 Thread Willy Tarreau
On Sat, Mar 26, 2005 at 12:46:19PM +0100, Arjan van de Ven wrote: > On Sat, 2005-03-26 at 12:34 +0100, Willy Tarreau wrote: > > Marcelo, > > > > just another one and that's all. Zachary Amsden found an unconditional > > write to a debug register in the signal delivery path which is only > > needed

Re: Linux 2.4.30-rc2

2005-03-26 Thread Willy Tarreau
On Sat, Mar 26, 2005 at 12:44:53PM +0100, Arjan van de Ven wrote: > On Sat, 2005-03-26 at 12:22 +0100, Willy Tarreau wrote: > > Marcelo, > > > > here's a patch from Dave Jones, which is already in 2.6 and which I've > > used in my local tree for 6 months now. It removes a useless NULL check > > in

Re: Linux 2.4.30-rc2

2005-03-26 Thread Arjan van de Ven
On Sat, 2005-03-26 at 12:34 +0100, Willy Tarreau wrote: > Marcelo, > > just another one and that's all. Zachary Amsden found an unconditional > write to a debug register in the signal delivery path which is only > needed when we use a breakpoint. This is a very expensive operation on > x86, and do

Re: Linux 2.4.30-rc2

2005-03-26 Thread Arjan van de Ven
On Sat, 2005-03-26 at 12:22 +0100, Willy Tarreau wrote: > Marcelo, > > here's a patch from Dave Jones, which is already in 2.6 and which I've > used in my local tree for 6 months now. It removes a useless NULL check > in zlib_inflateInit2_(), since 'z' is already dereferenced one line > before the

Re: Linux 2.4.30-rc2

2005-03-26 Thread Willy Tarreau
Marcelo, just another one and that's all. Zachary Amsden found an unconditional write to a debug register in the signal delivery path which is only needed when we use a breakpoint. This is a very expensive operation on x86, and doing it conditionnaly enhanced signal delivery speed by 33% for him.

Re: Linux 2.4.30-rc2

2005-03-26 Thread Willy Tarreau
Marcelo, here's a patch from Dave Jones, which is already in 2.6 and which I've used in my local tree for 6 months now. It removes a useless NULL check in zlib_inflateInit2_(), since 'z' is already dereferenced one line before the test. Can in go in 2.4.30 please ? Thanks, Willy --- ./lib/zlib_i

Re: Linux 2.4.30-rc2

2005-03-26 Thread Willy Tarreau
Marcelo, David, could we merge this patch from Mitch Williams in 2.4.30 ? It fixes a stack dump when unloading the bonding module in 802.3ad mode if spinlock debugging is turned on. Thanks in advance, Willy diff -urN linux-2.4.29/drivers/net/bonding/bond_main.c linux-2.4.29-bond-2.6.1/drivers/

Re: Linux 2.4.30-rc2

2005-03-26 Thread Willy Tarreau
Marcelo, just in case you release an -rc3, would you please include this typo fix from Jurgen Quade. I have it in my tree since 2.4.23, it's a pure copy-paste typo which causes the driver either to print an incomplete message or a seconde unexpected one. BTW, it's fixed in 2.6. Thanks, Willy ---

Re: Linux 2.4.30-rc2

2005-03-26 Thread Willy Tarreau
Hi Marcelo, Hi Michael, ok, it runs fine on athlon-smp and pentium-M notebook. I still have my negociation trouble on the notebook with the tg3, but as I have not yet reported them, this is normal ;-) Basically, when the nic is connected to a 100 Mbps, forced-full duplex switch (eg: cisco), the N

Linux 2.4.30-rc2

2005-03-25 Thread Marcelo Tosatti
Hi, Here goes the second release candidate for v2.4.30. It contains a bunch of security updates (ext2 mkdir leak, af_bluetooth range checking, isofs corrupt media, load_elf_library DoS), an ia64 update, another round of networking fixes, amongst others. If nothing terrible shows up, this will b