Re: IPsec AH use of ahash

2013-01-30 Thread Jan Engelhardt
On Sunday 2013-01-20 14:54, Tom St Denis wrote: >> >> > You should really try running checkpatch.pl over code that's >> > already in the kernel before you call out new contributors on it. >> > >> > How is this supposed to not be adversarial when I can't even use >> > the Kernel source itself as a

Re: IPsec AH use of ahash

2013-01-21 Thread Chris Friesen
On 01/21/2013 09:31 AM, Tom St Denis wrote: - Original Message - From: "Steven Rostedt" To: "Tom St Denis" Cc: "David Dillow", "Borislav Petkov", linux-kernel@vger.kernel.org, net...@vger.kernel.org Sent: Monday, 21 January, 2013 10:28:33 AM Su

Re: IPsec AH use of ahash

2013-01-21 Thread Tom St Denis
- Original Message - > From: "Chris Friesen" > To: "Tom St Denis" > Cc: "Steven Rostedt" , "David Dillow" > , "Borislav Petkov" , > linux-kernel@vger.kernel.org, net...@vger.kernel.org > Sent: Monday, 21 January, 2013

Re: IPsec AH use of ahash

2013-01-21 Thread Tom St Denis
- Original Message - > From: "Steven Rostedt" > To: "Tom St Denis" > Cc: "David Dillow" , "Borislav Petkov" , > linux-kernel@vger.kernel.org, > net...@vger.kernel.org > Sent: Monday, 21 January, 2013 10:28:33 AM > Subject:

Re: IPsec AH use of ahash

2013-01-21 Thread Steven Rostedt
t; > net...@vger.kernel.org > > Sent: Monday, 21 January, 2013 9:37:41 AM > > Subject: Re: IPsec AH use of ahash > > > > > > I find that 73% of all stats are made up. > > > > I was only talking about my own experience. I gave no numbers. > > That was

Re: IPsec AH use of ahash

2013-01-21 Thread Tom St Denis
- Original Message - > From: "Steven Rostedt" > To: "Tom St Denis" > Cc: "David Dillow" , "Borislav Petkov" , > linux-kernel@vger.kernel.org, > net...@vger.kernel.org > Sent: Monday, 21 January, 2013 9:37:41 AM > Subject: Re

Re: IPsec AH use of ahash

2013-01-21 Thread Steven Rostedt
t; > net...@vger.kernel.org > > Sent: Monday, 21 January, 2013 8:38:54 AM > > Subject: Re: IPsec AH use of ahash > > > > The missing semi-colon is in fact missing and for that I apologize. > > > This btw is the first legitimate gripe with the code thus far. > >

Re: IPsec AH use of ahash

2013-01-21 Thread Tom St Denis
- Original Message - > From: "Steven Rostedt" > To: "Tom St Denis" > Cc: "David Dillow" , "Borislav Petkov" , > linux-kernel@vger.kernel.org, > net...@vger.kernel.org > Sent: Monday, 21 January, 2013 8:38:54 AM > Subject

Re: IPsec AH use of ahash

2013-01-21 Thread Steven Rostedt
teven Rostedt" > > > > Sent: Monday, 21 January, 2013 4:18:01 AM > > Subject: Re: IPsec AH use of ahash > > > > On Sun, 2013-01-20 at 19:40 -0500, Tom St Denis wrote: > > > The problem is for me to add the ()'s is a no brainer. > > > > I

Re: IPsec AH use of ahash

2013-01-21 Thread Tom St Denis
- Original Message - > From: "David Dillow" > To: "Tom St Denis" > Cc: "Borislav Petkov" , linux-kernel@vger.kernel.org, > net...@vger.kernel.org, "Steven Rostedt" > > Sent: Monday, 21 January, 2013 4:18:01 AM > Subjec

Re: IPsec AH use of ahash

2013-01-21 Thread David Dillow
On Sun, 2013-01-20 at 19:40 -0500, Tom St Denis wrote: > The problem is for me to add the ()'s is a no brainer. It was more than just the ()'s. You completely botched the indentation in the parts of code you didn't copy from xcbc.c, among other issues. > For me to re-write complete statements for

Re: IPsec AH use of ahash

2013-01-20 Thread Borislav Petkov
On Sun, Jan 20, 2013 at 07:40:49PM -0500, Tom St Denis wrote: > If you guys can't appreciate that I should just bow out of the > discussion. I didn't come here looking for a fight I came here to seek > reason. Ok, I'm going to pretty much repeat what Steve said but I'm going to repeat it only once

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
...@gondor.apana.org.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, > "Michal Kubecek" , "Mike Galbraith" > Sent: Sunday, 20 January, 2013 5:07:22 PM > Subject: Re: IPsec AH use of ahash > > On Sun, Jan 20, 2013 at 07:56:27AM -0500, Tom St Den

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "Alan Cox" > To: "Tom St Denis" , "David Dillow" > > Cc: linux-kernel@vger.kernel.org, net...@vger.kernel.org > Sent: Sunday, 20 January, 2013 3:30:49 PM > Subject: Re: IPsec AH use of ahash > > Look

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "Borislav Petkov" > To: "Steven Rostedt" > Cc: "Tom St Denis" , "David Dillow" > , linux-kernel@vger.kernel.org, > net...@vger.kernel.org > Sent: Sunday, 20 January, 2013 7:34:41 PM > Subject:

Re: IPsec AH use of ahash

2013-01-20 Thread Borislav Petkov
On Sun, Jan 20, 2013 at 05:54:07PM -0500, Steven Rostedt wrote: > My God, you sound like a 2 year old. > > Suck it up, and do the fixes. It's not the time you are worried about, > as you most definitely spent more time bitching to everyone than it > would have taken you to clean up your work. It'

Re: IPsec AH use of ahash

2013-01-20 Thread Steven Rostedt
On Sun, Jan 20, 2013 at 01:47:01PM -0500, Tom St Denis wrote: > > > > > > You mean the content at http://lkml.org/lkml/2012/12/11/369 ? > > > > Funny how posting to an mailing list works... > > I posted that in December ... it wasn't till January that I got the first > reply back about it fai

Re: IPsec AH use of ahash

2013-01-20 Thread Steven Rostedt
On Sun, Jan 20, 2013 at 07:56:27AM -0500, Tom St Denis wrote: > > You should really try running checkpatch.pl over code that's already in the > kernel before you call out new contributors on it. > > How is this supposed to not be adversarial when I can't even use the Kernel > source itself as a

Re: IPsec AH use of ahash

2013-01-20 Thread Alan Cox
Look at it from the kernel end. What happens if your change shows up bugs on another architecture or has a flaw. It works for you now but you plan to dump and run. That's not a viable long term development model for upstream. The licence allows you to do it, and other parties who care more to pi

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "David Dillow" > To: "Tom St Denis" > Cc: linux-kernel@vger.kernel.org, net...@vger.kernel.org > Sent: Sunday, 20 January, 2013 1:11:11 PM > Subject: Re: IPsec AH use of ahash > > On Sun, 2013-01-20 at 12:40 -0500,

Re: IPsec AH use of ahash

2013-01-20 Thread David Dillow
On Sun, 2013-01-20 at 12:40 -0500, Tom St Denis wrote: > > On Sun, 2013-01-20 at 10:07 -0500, Tom St Denis wrote: > > > In all likelihood I will submit a revised CMAC patch but it'll take > > > time before I can get business hours to work on it. So instead of > > > having a maintainer just touch i

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "David Dillow" > To: "Tom St Denis" > Cc: linux-kernel@vger.kernel.org, net...@vger.kernel.org > Sent: Sunday, 20 January, 2013 11:34:52 AM > Subject: Re: IPsec AH use of ahash > > On Sun, 2013-01-20 at 10:07 -0500,

Re: IPsec AH use of ahash

2013-01-20 Thread David Dillow
On Sun, 2013-01-20 at 10:07 -0500, Tom St Denis wrote: > In all likelihood I will submit a revised CMAC patch but it'll take > time before I can get business hours to work on it. So instead of > having a maintainer just touch it up we're all going to lose out > because of pride? Yes -- but it wou

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
r.hengli.com.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, > "Michal Kubecek" > Sent: Sunday, 20 January, 2013 12:03:34 PM > Subject: Re: IPsec AH use of ahash > > On 01/20/2013 07:07 AM, Tom St Denis wrote: > > > > In all likelihood I

Re: IPsec AH use of ahash

2013-01-20 Thread H. Peter Anvin
On 01/20/2013 07:07 AM, Tom St Denis wrote: In all likelihood I will submit a revised CMAC patch but it'll take time before I can get business hours to work on it. So instead of having a maintainer just touch it up we're all going to lose out because of pride? It's not about pride. It is ab

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
@vger.kernel.org, net...@vger.kernel.org, "Michal Kubecek" > > Sent: Sunday, 20 January, 2013 9:11:34 AM > Subject: Re: IPsec AH use of ahash > > On Sun, 2013-01-20 at 07:55 -0500, Tom St Denis wrote: > > > > - Original Message - > > &

Re: IPsec AH use of ahash

2013-01-20 Thread Mike Galbraith
t; > > , "steffen klassert" , > > herb...@gondor.apana.org.au, > > linux-kernel@vger.kernel.org, net...@vger.kernel.org, "Michal Kubecek" > > > > Sent: Sunday, 20 January, 2013 12:06:21 AM > > Subject: Re: IPsec AH use of ahash > > &g

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
...@gondor.apana.org.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, > "Michal Kubecek" , "Mike Galbraith" > Sent: Sunday, 20 January, 2013 8:34:20 AM > Subject: Re: IPsec AH use of ahash > > Am 20.01.2013 13:56, schrieb Tom St Denis: > &

Re: IPsec AH use of ahash

2013-01-20 Thread Alexander Holler
Am 20.01.2013 13:56, schrieb Tom St Denis: You should really try running checkpatch.pl over code that's already in the kernel before you call out new contributors on it. How is this supposed to not be adversarial when I can't even use the Kernel source itself as a reference? In case of the

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
...@gondor.apana.org.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, > "Michal Kubecek" > Sent: Sunday, 20 January, 2013 5:31:32 AM > Subject: Re: IPsec AH use of ahash > > On Sun, Jan 20, 2013 at 06:06:21AM +0100, Mike Galbraith wrote: > > Sounds as though

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
rnel@vger.kernel.org, net...@vger.kernel.org, "Michal Kubecek" > > Sent: Sunday, 20 January, 2013 12:06:21 AM > Subject: Re: IPsec AH use of ahash > > On Sat, 2013-01-19 at 05:30 -0500, Tom St Denis wrote: > > > For those of us who do Kernel development during

Re: IPsec AH use of ahash

2013-01-20 Thread Borislav Petkov
On Sun, Jan 20, 2013 at 06:06:21AM +0100, Mike Galbraith wrote: > Sounds as though any patches you submit land on your dinner plate just > like potatoes. Hand the cook a pot of half peeled potatoes, he/she may > say try again. And how he/she would say it! I've seen serious fights spring up from ha

Re: IPsec AH use of ahash

2013-01-19 Thread Mike Galbraith
On Sat, 2013-01-19 at 05:30 -0500, Tom St Denis wrote: > For those of us who do Kernel development during business hours it's > hard to justify the work when the path to mainline is convoluted and > landmined. Sounds as though any patches you submit land on your dinner plate just like potatoes.

Re: IPsec AH use of ahash

2013-01-19 Thread Eric Dumazet
On Sat, 2013-01-19 at 05:30 -0500, Tom St Denis wrote: > As someone who maintained (and I mean that in all senses not just > applied patches) OSS projects while working full time and still trying > to have a life I get it. That said I never turned away patches solely > on "style" issues. At the

Re: IPsec AH use of ahash

2013-01-19 Thread Tom St Denis
el@vger.kernel.org, net...@vger.kernel.org > Sent: Friday, 18 January, 2013 10:59:55 PM > Subject: Re: IPsec AH use of ahash > > On Sat, 2013-01-19 at 03:33 +0100, Michal Kubecek wrote: > > > Someone already pointed you to http://patchwork.ozlabs.org/ > > Please do tak

Re: IPsec AH use of ahash

2013-01-18 Thread Eric Dumazet
On Sat, 2013-01-19 at 03:33 +0100, Michal Kubecek wrote: > Someone already pointed you to http://patchwork.ozlabs.org/ > Please do take a look there. I just did and found that in last three > months, about 3500 patches were submitted to this list, i.e. about > 40 patches per day (including weekend

Re: IPsec AH use of ahash

2013-01-18 Thread Tom St Denis
er.kernel.org > Sent: Friday, 18 January, 2013 9:33:55 PM > Subject: Re: IPsec AH use of ahash > > On Fri, Jan 18, 2013 at 05:31:45PM -0500, Tom St Denis wrote: > > My gripe here is suppose I spend professional paid time working on > > an > > AH patch to [in

Re: IPsec AH use of ahash

2013-01-18 Thread Michal Kubecek
On Fri, Jan 18, 2013 at 05:31:45PM -0500, Tom St Denis wrote: > My gripe here is suppose I spend professional paid time working on an > AH patch to [in my opinion] fix it and then I get > ignored/stonewalled/etc because I didn't cross a t or dot an i ... ... > ... if the likelihood of seeing it in

Re: IPsec AH use of ahash

2013-01-18 Thread Tom St Denis
- Original Message - > From: "Waskiewicz Jr, Peter P" > To: "Tom St Denis" > Cc: "David Miller" , "steffen klassert" > , > herb...@gondor.apana.org.au, linux-kernel@vger.kernel.org, > net...@vger.kernel.org > Sent: Frida

Re: IPsec AH use of ahash

2013-01-18 Thread Waskiewicz Jr, Peter P
On Fri, Jan 18, 2013 at 03:53:44PM -0500, Tom St Denis wrote: > Admittedly I'm new to the kernel scene but what exactly is a "maintainer" > then? Maintainers are ultimately responsible for content that flows into a tree or subsystem. That means they must command a level of expertise on everythin

Re: IPsec AH use of ahash

2013-01-18 Thread Tom St Denis
- Original Message - > From: "David Miller" > To: tstde...@elliptictech.com > Cc: "steffen klassert" , > herb...@gondor.apana.org.au, linux-kernel@vger.kernel.org, > net...@vger.kernel.org > Sent: Friday, 18 January, 2013 2:50:05 PM > Subject: Re

Re: IPsec AH use of ahash

2013-01-18 Thread David Miller
From: Tom St Denis Date: Fri, 18 Jan 2013 14:35:33 -0500 (EST) > Any "maintainers" going to reply to this at all? What do you mean? There was a reply, and the reply if someone so skilled finds this facility useful they can feel free to submit an implementation. You can't force people to work

Re: IPsec AH use of ahash

2013-01-18 Thread Tom St Denis
Sent: Wednesday, 16 January, 2013 1:21:04 AM > Subject: Re: IPsec AH use of ahash > > Please Cc net...@vger.kernel.org on all networking related topics. > > On Tue, Jan 15, 2013 at 11:51:48AM -0500, Tom St Denis wrote: > > Hi all, > > > > The AH4/6 code uses ahash

Re: IPsec AH use of ahash

2013-01-15 Thread Steffen Klassert
Please Cc net...@vger.kernel.org on all networking related topics. On Tue, Jan 15, 2013 at 11:51:48AM -0500, Tom St Denis wrote: > Hi all, > > The AH4/6 code uses ahash to perform the MAC calculation but this precludes > the availability of GMAC to the user. Are there any plans to port the AH