Re: I2C-Octeon: Use common error handling code in octeon_i2c_probe()

2017-10-25 Thread SF Markus Elfring
> NAK.  We don't need any more Markus Elfring spam. Why do you not like another update suggestion for this use case? >> Add a jump target so that a specific error message is stored only once >> at the end of this function implementation. > > Please read C standard about duplicate literal string

Re: [PATCH] I2C-Octeon: Use common error handling code in octeon_i2c_probe()

2017-10-25 Thread David Daney
On 10/25/2017 02:52 AM, SF Markus Elfring wrote: From: Markus Elfring NAK. We don't need any more Markus Elfring spam. Date: Wed, 25 Oct 2017 11:45:48 +0200 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Please read C s

[PATCH] I2C-Octeon: Use common error handling code in octeon_i2c_probe()

2017-10-25 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 25 Oct 2017 11:45:48 +0200 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "dev_err" by goto statements. This issue was detected by using the Coccinelle software.