Re: For review: seccomp_user_notif(2) manual page [v2]

On Mon, Nov 2, 2020 at 8:50 PM Sargun Dhillon wrote: > On Mon, Nov 2, 2020 at 11:45 AM Michael Kerrisk (man-pages) > wrote: > >Caveats regarding blocking system calls > >Suppose that the target performs a blocking system call (e.g., > >accept(2)) that the supervisor should han

Re: For review: seccomp_user_notif(2) manual page [v2]

On Mon, Nov 2, 2020 at 11:45 AM Michael Kerrisk (man-pages) wrote: > > Hello Sargun, > > Thanks for your reply! > > On 11/2/20 9:07 AM, Sargun Dhillon wrote: > > On Sat, Oct 31, 2020 at 9:27 AM Michael Kerrisk (man-pages) > > wrote: > >> > >> Hello Sargun, > >> > >> Thanks for your reply. > >> >

Re: For review: seccomp_user_notif(2) manual page [v2]

Hello Sargun, Thanks for your reply! On 11/2/20 9:07 AM, Sargun Dhillon wrote: > On Sat, Oct 31, 2020 at 9:27 AM Michael Kerrisk (man-pages) > wrote: >> >> Hello Sargun, >> >> Thanks for your reply. >> >> On 10/30/20 9:27 PM, Sargun Dhillon wrote: >>> On Thu, Oct 29, 2020 at 09:37:21PM +0100, Mi

Re: For review: seccomp_user_notif(2) manual page [v2]

On Sat, Oct 31, 2020 at 9:51 AM Michael Kerrisk (man-pages) wrote: > On 10/30/20 8:20 PM, Jann Horn wrote: > > On Thu, Oct 29, 2020 at 8:14 PM Michael Kerrisk (man-pages) > > wrote: > >> On 10/29/20 2:42 AM, Jann Horn wrote: > >>> As discussed at > >>>

Re: For review: seccomp_user_notif(2) manual page [v2]

On Sat, Oct 31, 2020 at 9:31 AM Michael Kerrisk (man-pages) wrote: > On 10/30/20 8:14 PM, Jann Horn wrote: > > With the caveat that a cancelled syscall > > could've also led to the memory being munmap()ed, so the nread==0 case > > could also happen legitimately - so you might want to move this che

Re: For review: seccomp_user_notif(2) manual page [v2]

On Sat, Oct 31, 2020 at 9:27 AM Michael Kerrisk (man-pages) wrote: > > Hello Sargun, > > Thanks for your reply. > > On 10/30/20 9:27 PM, Sargun Dhillon wrote: > > On Thu, Oct 29, 2020 at 09:37:21PM +0100, Michael Kerrisk (man-pages) > > wrote: > > [...] > > >>> I think I commented in another threa

Re: For review: seccomp_user_notif(2) manual page [v2]

Hello Sargun, Thanks for your reply. On 10/30/20 9:27 PM, Sargun Dhillon wrote: > On Thu, Oct 29, 2020 at 09:37:21PM +0100, Michael Kerrisk (man-pages) > wrote: [...] >>> I think I commented in another thread somewhere that the >>> supervisor is not notified if the syscall is preempted. Therefo

Re: For review: seccomp_user_notif(2) manual page [v2]

On 10/30/20 8:20 PM, Jann Horn wrote: > On Thu, Oct 29, 2020 at 8:14 PM Michael Kerrisk (man-pages) > wrote: >> On 10/29/20 2:42 AM, Jann Horn wrote: >>> As discussed at >>> , >>> we need to re-check c

Re: For review: seccomp_user_notif(2) manual page [v2]

On 10/30/20 8:14 PM, Jann Horn wrote: > On Thu, Oct 29, 2020 at 3:19 PM Michael Kerrisk (man-pages) > wrote: >> On 10/29/20 2:42 AM, Jann Horn wrote: >>> On Mon, Oct 26, 2020 at 10:55 AM Michael Kerrisk (man-pages) >>> wrote: static bool getTargetPathname(struct seccomp_no

Re: For review: seccomp_user_notif(2) manual page [v2]

On Thu, Oct 29, 2020 at 09:37:21PM +0100, Michael Kerrisk (man-pages) wrote: > Hello Sargun,, > > On 10/29/20 9:53 AM, Sargun Dhillon wrote: > > On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: > > [...] > > >>ioctl(2) operations > >>The following ioctl(2)

Re: For review: seccomp_user_notif(2) manual page [v2]

On 10/30/20 8:24 PM, Jann Horn wrote: > On Thu, Oct 29, 2020 at 8:53 PM Michael Kerrisk (man-pages) > wrote: >> On 10/29/20 4:26 PM, Christian Brauner wrote: >>> I like this manpage. I think this is the most comprehensive explanation >>> of any seccomp feature >> >> Thanks (at least, I think so...

Re: For review: seccomp_user_notif(2) manual page [v2]

On Thu, Oct 29, 2020 at 8:14 PM Michael Kerrisk (man-pages) wrote: > On 10/29/20 2:42 AM, Jann Horn wrote: > > As discussed at > > , > > we need to re-check checkNotificationIdIsValid() after reading r

Re: For review: seccomp_user_notif(2) manual page [v2]

On Thu, Oct 29, 2020 at 8:53 PM Michael Kerrisk (man-pages) wrote: > On 10/29/20 4:26 PM, Christian Brauner wrote: > > I like this manpage. I think this is the most comprehensive explanation > > of any seccomp feature > > Thanks (at least, I think so...) > > > and somewhat understandable. >

Re: For review: seccomp_user_notif(2) manual page [v2]

On Thu, Oct 29, 2020 at 3:19 PM Michael Kerrisk (man-pages) wrote: > On 10/29/20 2:42 AM, Jann Horn wrote: > > On Mon, Oct 26, 2020 at 10:55 AM Michael Kerrisk (man-pages) > > wrote: > >>static bool > >>getTargetPathname(struct seccomp_notif *req, int notifyFd, > >>

Re: For review: seccomp_user_notif(2) manual page [v2]

Hello Sargun,, On 10/29/20 9:53 AM, Sargun Dhillon wrote: > On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: [...] >>ioctl(2) operations >>The following ioctl(2) operations are provided to support seccomp >>user-space notification. For each of the

Re: For review: seccomp_user_notif(2) manual page [v2]

Hello Christian Thanks for taking a look at the page. On 10/29/20 4:26 PM, Christian Brauner wrote: > On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: >> Hi all (and especially Tycho and Sargun), >> >> Following review comments on the first draft (thanks to Jann, Kees,

Re: For review: seccomp_user_notif(2) manual page [v2]

Hello Jann, On 10/29/20 2:42 AM, Jann Horn wrote: > On Mon, Oct 26, 2020 at 10:55 AM Michael Kerrisk (man-pages) > wrote: >>static bool >>getTargetPathname(struct seccomp_notif *req, int notifyFd, >> char *path, size_t len) >>{ >>char p

Re: For review: seccomp_user_notif(2) manual page [v2]

On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: > Hi all (and especially Tycho and Sargun), > > Following review comments on the first draft (thanks to Jann, Kees, > Christian and Tycho), I've made a lot of changes to this page. > I've also added a few FIXMEs relating

Re: For review: seccomp_user_notif(2) manual page [v2]

Hello Jann, On 10/29/20 2:42 AM, Jann Horn wrote: > On Mon, Oct 26, 2020 at 10:55 AM Michael Kerrisk (man-pages) > wrote: >>static bool >>getTargetPathname(struct seccomp_notif *req, int notifyFd, >> char *path, size_t len) >>{ >>char p

Re: For review: seccomp_user_notif(2) manual page [v2]

On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: > Hi all (and especially Tycho and Sargun), > > Following review comments on the first draft (thanks to Jann, Kees, > Christian and Tycho), I've made a lot of changes to this page. > I've also added a few FIXMEs relating

Re: For review: seccomp_user_notif(2) manual page [v2]

On Thu, Oct 29, 2020 at 3:04 AM Tycho Andersen wrote: > On Thu, Oct 29, 2020 at 02:42:58AM +0100, Jann Horn wrote: > > On Mon, Oct 26, 2020 at 10:55 AM Michael Kerrisk (man-pages) > > wrote: > > >static bool > > >getTargetPathname(struct seccomp_notif *req, int notifyFd, > > >

Re: For review: seccomp_user_notif(2) manual page [v2]

On Mon, Oct 26, 2020 at 10:55 AM Michael Kerrisk (man-pages) wrote: >static bool >getTargetPathname(struct seccomp_notif *req, int notifyFd, > char *path, size_t len) >{ >char procMemPath[PATH_MAX]; > >snprintf(procMemPath, s

Re: For review: seccomp_user_notif(2) manual page [v2]

On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: > Hi all (and especially Tycho and Sargun), > > Following review comments on the first draft (thanks to Jann, Kees, > Christian and Tycho), I've made a lot of changes to this page. > I've also added a few FIXMEs relating

Re: For review: seccomp_user_notif(2) manual page [v2]

On Mon, Oct 26, 2020 at 03:30:29PM +0100, Michael Kerrisk (man-pages) wrote: > Hi Tycho, > > Thanks for getting back to me. > > On Mon, 26 Oct 2020 at 14:54, Tycho Andersen wrote: > > > > On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: > > > Hi all (and especially Ty

Re: For review: seccomp_user_notif(2) manual page [v2]

Hi Tycho, Thanks for getting back to me. On Mon, 26 Oct 2020 at 14:54, Tycho Andersen wrote: > > On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: > > Hi all (and especially Tycho and Sargun), > > > > Following review comments on the first draft (thanks to Jann, Kees,

For review: seccomp_user_notif(2) manual page [v2]

Hi all (and especially Tycho and Sargun), Following review comments on the first draft (thanks to Jann, Kees, Christian and Tycho), I've made a lot of changes to this page. I've also added a few FIXMEs relating to outstanding API issues. I'd like a second pass review of the page before I release i