From: 周琰杰 (Zhou Yanjie)
[ Upstream commit 942bfbecc0281c75db84f744b9b77b0f2396f484 ]
Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
error when I2C write operation which should look like this:
device_addr + w, reg_addr, data;
But without this patch, it looks like this:
device_a
From: 周琰杰 (Zhou Yanjie)
[ Upstream commit 942bfbecc0281c75db84f744b9b77b0f2396f484 ]
Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
error when I2C write operation which should look like this:
device_addr + w, reg_addr, data;
But without this patch, it looks like this:
device_a
Hi Wolfram,
On 2021/3/31 下午3:18, Wolfram Sang wrote:
Hi,
Any write operation? I wonder then why nobody noticed before?
The standard I2C communication should look like this:
Read:
device_addr + w, reg_addr, device_addr + r, data;
Write:
device_addr + w, reg_addr, data;
But without this
On Fri, Mar 19, 2021 at 06:12:13PM +0800, 周琰杰 (Zhou Yanjie) wrote:
> Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
> error when I2C write operation.
>
> Fixes: 21575a7a8d4c ("I2C: JZ4780: Add support for the X1000.")
>
> Reported-by: 杨文龙 (Yang Wenlong)
> Tested-by: 杨文龙 (Yang Wen
Hi,
> > Any write operation? I wonder then why nobody noticed before?
>
>
> The standard I2C communication should look like this:
>
> Read:
>
> device_addr + w, reg_addr, device_addr + r, data;
>
> Write:
>
> device_addr + w, reg_addr, data;
>
>
> But without this patch, it looks like thi
For SoCs after X1000, only send "X1000_I2C_DC_STOP" when last byte,
or it will cause error when I2C write operation.
v1->v2:
1.Add missing Reported-by and Tested-by.
2.Remove change which not related to the bugfix.
周琰杰 (Zhou Yanjie) (1):
I2C: JZ4780: Fix bug for Ingenic X1000.
Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
error when I2C write operation.
Fixes: 21575a7a8d4c ("I2C: JZ4780: Add support for the X1000.")
Reported-by: 杨文龙 (Yang Wenlong)
Tested-by: 杨文龙 (Yang Wenlong)
Signed-off-by: 周琰杰 (Zhou Yanjie)
---
Notes:
v1->v2:
1.Add missin
Hi Wolfram,
Sorry, please forgive my carefulness, I wrongly sent the version that
did not clean up, resulting in missing the reporter's information and
some errors in formats.
On 2021/3/19 上午1:06, Wolfram Sang wrote:
On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote:
Only
On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
> error when I2C write operation.
Any write operation? I wonder then why nobody noticed before?
> - while ((i2c_sta & JZ4780_I2C_STA_TFNF) &&
> -
On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
> error when I2C write operation.
>
> Fixes: 21575a7a8d4c ("I2C: JZ4780: Add support for the X1000.")
>
> Signed-off-by: 周琰杰 (Zhou Yanjie)
> ---
> drivers/i2c/buss
Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
error when I2C write operation.
Fixes: 21575a7a8d4c ("I2C: JZ4780: Add support for the X1000.")
Signed-off-by: 周琰杰 (Zhou Yanjie)
---
drivers/i2c/busses/i2c-jz4780.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff
For SoCs after X1000, only send "X1000_I2C_DC_STOP" when last byte,
or it will cause error when I2C write operation.
周琰杰 (Zhou Yanjie) (1):
I2C: JZ4780: Fix bug for Ingenic X1000.
drivers/i2c/busses/i2c-jz4780.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
--
2.7.4
12 matches
Mail list logo
