[PATCH 5.4 54/76] nvme-tcp: fix possible data corruption with bio merges

2021-01-18 Thread Greg Kroah-Hartman
From: Sagi Grimberg commit ca1ff67d0fb14f39cf0cc5102b1fbcc3b14f6fb9 upstream. When a bio merges, we can get a request that spans multiple bios, and the overall request payload size is the sum of all bios. When we calculate how much we need to send from the existing bio (and bvec), we did not tak

[PATCH 5.10 119/152] nvme-tcp: fix possible data corruption with bio merges

2021-01-18 Thread Greg Kroah-Hartman
From: Sagi Grimberg commit ca1ff67d0fb14f39cf0cc5102b1fbcc3b14f6fb9 upstream. When a bio merges, we can get a request that spans multiple bios, and the overall request payload size is the sum of all bios. When we calculate how much we need to send from the existing bio (and bvec), we did not tak

[PATCH 5.9 292/391] powerpc: Fix undetected data corruption with P9N DD2.1 VSX CI load emulation

2020-11-03 Thread Greg Kroah-Hartman
Also vbuf will not contain the correct data which results in the userspace emulation being wrong and hence undetected user data corruption. In the past we've been mostly lucky as vbuf has ended up aligned but this is fragile and isn't always true. CONFIG_STACKPROTECTOR in particular

[PATCH 5.4 163/214] powerpc: Fix undetected data corruption with P9N DD2.1 VSX CI load emulation

2020-11-03 Thread Greg Kroah-Hartman
Also vbuf will not contain the correct data which results in the userspace emulation being wrong and hence undetected user data corruption. In the past we've been mostly lucky as vbuf has ended up aligned but this is fragile and isn't always true. CONFIG_STACKPROTECTOR in particular

[PATCH 4.19 158/191] powerpc: Fix undetected data corruption with P9N DD2.1 VSX CI load emulation

2020-11-03 Thread Greg Kroah-Hartman
Also vbuf will not contain the correct data which results in the userspace emulation being wrong and hence undetected user data corruption. In the past we've been mostly lucky as vbuf has ended up aligned but this is fragile and isn't always true. CONFIG_STACKPROTECTOR in particular

[PATCH 4.14 008/191] r8169: fix data corruption issue on RTL8402

2020-10-27 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit ef9da46ddef071e1bbb943afbbe9b3877184 ] Petr reported that after resume from suspend RTL8402 partially truncates incoming packets, and re-initializing register RxConfig before the actual chip re-initialization sequence is needed to avoid the issue. Rep

[PATCH 4.19 012/264] r8169: fix data corruption issue on RTL8402

2020-10-27 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit ef9da46ddef071e1bbb943afbbe9b3877184 ] Petr reported that after resume from suspend RTL8402 partially truncates incoming packets, and re-initializing register RxConfig before the actual chip re-initialization sequence is needed to avoid the issue. Rep

[PATCH 5.4 047/408] SMB3: Resolve data corruption of TCP server info fields

2020-10-27 Thread Greg Kroah-Hartman
From: Rohith Surabattula commit 62593011247c8a8cfeb0c86aff84688b196727c2 upstream. TCP server info field server->total_read is modified in parallel by demultiplex thread and decrypt offload worker thread. server->total_read is used in calculation to discard the remaining data of PDU which is not

[PATCH 5.9 068/757] SMB3: Resolve data corruption of TCP server info fields

2020-10-27 Thread Greg Kroah-Hartman
From: Rohith Surabattula commit 62593011247c8a8cfeb0c86aff84688b196727c2 upstream. TCP server info field server->total_read is modified in parallel by demultiplex thread and decrypt offload worker thread. server->total_read is used in calculation to discard the remaining data of PDU which is not

[PATCH 5.8 064/633] SMB3: Resolve data corruption of TCP server info fields

2020-10-27 Thread Greg Kroah-Hartman
From: Rohith Surabattula commit 62593011247c8a8cfeb0c86aff84688b196727c2 upstream. TCP server info field server->total_read is modified in parallel by demultiplex thread and decrypt offload worker thread. server->total_read is used in calculation to discard the remaining data of PDU which is not

[PATCH 5.8 025/633] r8169: fix data corruption issue on RTL8402

2020-10-27 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit ef9da46ddef071e1bbb943afbbe9b3877184 ] Petr reported that after resume from suspend RTL8402 partially truncates incoming packets, and re-initializing register RxConfig before the actual chip re-initialization sequence is needed to avoid the issue. Rep

[PATCH 5.4 018/408] r8169: fix data corruption issue on RTL8402

2020-10-27 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit ef9da46ddef071e1bbb943afbbe9b3877184 ] Petr reported that after resume from suspend RTL8402 partially truncates incoming packets, and re-initializing register RxConfig before the actual chip re-initialization sequence is needed to avoid the issue. Rep

[PATCH 4.9 004/139] r8169: fix data corruption issue on RTL8402

2020-10-27 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit ef9da46ddef071e1bbb943afbbe9b3877184 ] Petr reported that after resume from suspend RTL8402 partially truncates incoming packets, and re-initializing register RxConfig before the actual chip re-initialization sequence is needed to avoid the issue. Rep

[PATCH 4.4 004/112] r8169: fix data corruption issue on RTL8402

2020-10-27 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit ef9da46ddef071e1bbb943afbbe9b3877184 ] Petr reported that after resume from suspend RTL8402 partially truncates incoming packets, and re-initializing register RxConfig before the actual chip re-initialization sequence is needed to avoid the issue. Rep

[PATCH 4.19 100/245] mm: avoid data corruption on CoW fault into PFN-mapped VMA

2020-09-29 Thread Greg Kroah-Hartman
From: Kirill A. Shutemov [ Upstream commit c3e5ea6ee574ae5e845a40ac8198de1fb63bb3ab ] Jeff Moyer has reported that one of xfstests triggers a warning when run on DAX-enabled filesystem: WARNING: CPU: 76 PID: 51024 at mm/memory.c:2317 wp_page_copy+0xc40/0xd50 ... wp_page_

[PATCH 5.4 151/388] mm: avoid data corruption on CoW fault into PFN-mapped VMA

2020-09-29 Thread Greg Kroah-Hartman
From: Kirill A. Shutemov [ Upstream commit c3e5ea6ee574ae5e845a40ac8198de1fb63bb3ab ] Jeff Moyer has reported that one of xfstests triggers a warning when run on DAX-enabled filesystem: WARNING: CPU: 76 PID: 51024 at mm/memory.c:2317 wp_page_copy+0xc40/0xd50 ... wp_page_

[PATCH 5.4 156/388] cpu-topology: Fix the potential data corruption

2020-09-29 Thread Greg Kroah-Hartman
From: Zeng Tao [ Upstream commit 4a33691c4cea9eb0a7c66e87248be4637e14b180 ] Currently there are only 10 bytes to store the cpu-topology 'name' information. Only 10 bytes copied into cluster/thread/core names. If the cluster ID exceeds 2-digit number, it will result in the data corru

[PATCH 4.14 076/166] mm: avoid data corruption on CoW fault into PFN-mapped VMA

2020-09-29 Thread Greg Kroah-Hartman
From: Kirill A. Shutemov [ Upstream commit c3e5ea6ee574ae5e845a40ac8198de1fb63bb3ab ] Jeff Moyer has reported that one of xfstests triggers a warning when run on DAX-enabled filesystem: WARNING: CPU: 76 PID: 51024 at mm/memory.c:2317 wp_page_copy+0xc40/0xd50 ... wp_page_

[PATCH AUTOSEL 5.4 157/330] mm: avoid data corruption on CoW fault into PFN-mapped VMA

2020-09-17 Thread Sasha Levin
From: "Kirill A. Shutemov" [ Upstream commit c3e5ea6ee574ae5e845a40ac8198de1fb63bb3ab ] Jeff Moyer has reported that one of xfstests triggers a warning when run on DAX-enabled filesystem: WARNING: CPU: 76 PID: 51024 at mm/memory.c:2317 wp_page_copy+0xc40/0xd50 ... wp_pag

[PATCH AUTOSEL 4.19 099/206] mm: avoid data corruption on CoW fault into PFN-mapped VMA

2020-09-17 Thread Sasha Levin
From: "Kirill A. Shutemov" [ Upstream commit c3e5ea6ee574ae5e845a40ac8198de1fb63bb3ab ] Jeff Moyer has reported that one of xfstests triggers a warning when run on DAX-enabled filesystem: WARNING: CPU: 76 PID: 51024 at mm/memory.c:2317 wp_page_copy+0xc40/0xd50 ... wp_pag

[PATCH AUTOSEL 4.14 059/127] mm: avoid data corruption on CoW fault into PFN-mapped VMA

2020-09-17 Thread Sasha Levin
From: "Kirill A. Shutemov" [ Upstream commit c3e5ea6ee574ae5e845a40ac8198de1fb63bb3ab ] Jeff Moyer has reported that one of xfstests triggers a warning when run on DAX-enabled filesystem: WARNING: CPU: 76 PID: 51024 at mm/memory.c:2317 wp_page_copy+0xc40/0xd50 ... wp_pag

[PATCH AUTOSEL 5.4 162/330] cpu-topology: Fix the potential data corruption

2020-09-17 Thread Sasha Levin
From: Zeng Tao [ Upstream commit 4a33691c4cea9eb0a7c66e87248be4637e14b180 ] Currently there are only 10 bytes to store the cpu-topology 'name' information. Only 10 bytes copied into cluster/thread/core names. If the cluster ID exceeds 2-digit number, it will result in the data corru

[PATCH 4.4 055/149] udp: drop corrupt packets earlier to avoid data corruption

2020-08-20 Thread Greg Kroah-Hartman
From: Dexuan Cui The v4.4 stable kernel lacks this bugfix: commit 327868212381 ("make skb_copy_datagram_msg() et.al. preserve ->msg_iter on error"). As a result, the v4.4 kernel can deliver corrupt data to the application when a corrupt UDP packet is closely followed by a valid UDP packet: the s

Re: BTRFS/EXT4 Data Corruption

2020-07-02 Thread Pavel Machek
Hi! > After alot of fiddling around it turned out that the problem goes away if > doing "cp --sparse=never" > when copying the files. This would to me exclude any hardware errors and > feels more like something > deeper inside the kernel. If files contain random data, they are never sparse. It is

Re: BTRFS/EXT4 Data Corruption

2020-06-30 Thread David Sterba
On Mon, Jun 29, 2020 at 01:55:40AM +0700, Sebastian Hyrwall wrote: > Sorry if this is not the right place for this email but I can't think of > another place (might be linux-fsdevel) You can always CC the mailinglists of the filesystems. > Someone here is ought to be an expert in this. > > It a

BTRFS/EXT4 Data Corruption

2020-06-28 Thread Sebastian Hyrwall
Hi Sorry if this is not the right place for this email but I can't think of another place (might be linux-fsdevel) Someone here is ought to be an expert in this. It all started as having file corruptions inside VMs that then led to alot of testing that resulted in replicatable results on the

[PATCH 5.7 187/477] f2fs: compress: fix zstd data corruption

2020-06-23 Thread Greg Kroah-Hartman
last one block space, let's just writeback raw data instead of compressed one, this can fix data corruption when decompressing incomplete stored compression data. Fixes: 50cfa66f0de0 ("f2fs: compress: support zstd compress algorithm") Signed-off-by: Daeho Jeong Signed-off-by: Chao Yu

[PATCH AUTOSEL 5.7 190/388] f2fs: compress: fix zstd data corruption

2020-06-17 Thread Sasha Levin
last one block space, let's just writeback raw data instead of compressed one, this can fix data corruption when decompressing incomplete stored compression data. Fixes: 50cfa66f0de0 ("f2fs: compress: support zstd compress algorithm") Signed-off-by: Daeho Jeong Signed-off-by: Chao Yu

Re: [PATCH] f2fs: compress: fix zstd data corruption

2020-05-11 Thread Chao Yu
mained in intermediate buffer, it means that zstd algorithm can not > save at last one block space, let's just writeback raw data instead of > compressed one, this can fix data corruption when decompressing > incomplete stored compression data. > Fixes: 50cfa66f0de0 ("f2fs:

Re: [f2fs-dev] [PATCH] f2fs: compress: fix zstd data corruption

2020-05-07 Thread Daeho Jeong
> > > > > Could we save more memory space for these two cases like ZSTD? > > > As you know, we are using 5 pages compression buffer for LZ4 and LZO > > in > > > compress_log_size=2, > > > and if the compressed data doesn't fit in

Re: [f2fs-dev] [PATCH] f2fs: compress: fix zstd data corruption

2020-05-07 Thread Chao Yu
ed data doesn't fit in 3 pages, it returns -EAGAIN to > > give up compressing that one. > > > > Thanks, > > > > 2020년 5월 8일 (금) 오전 10:17, Chao Yu <mailto:yuch...@huawei.com>>님이 작성: > > > >> During zstd compress

Re: [f2fs-dev] [PATCH] f2fs: compress: fix zstd data corruption

2020-05-07 Thread Chao Yu
y return non-zero value >> because distination buffer is full, but there is still compressed data >> remained in intermediate buffer, it means that zstd algorithm can not >> save at last one block space, let's just writeback raw data instead of >> compressed one, this can

[PATCH] f2fs: compress: fix zstd data corruption

2020-05-07 Thread Chao Yu
d one, this can fix data corruption when decompressing incomplete stored compression data. Signed-off-by: Daeho Jeong Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index c22cc0d37369..5e4947250262 1

[PATCH 4.19 13/37] dm writecache: fix data corruption when reloading the target

2020-05-04 Thread Greg Kroah-Hartman
reload: 1. construct new target 2. suspend old target 3. resume new target 4. destroy old target Metadata that were written by the old target between steps 1 and 2 would not be visible by the new target. Fix the data corruption by loading the metadata in the resume handler. Also, validate block_size

[PATCH 5.6 37/73] dm writecache: fix data corruption when reloading the target

2020-05-04 Thread Greg Kroah-Hartman
reload: 1. construct new target 2. suspend old target 3. resume new target 4. destroy old target Metadata that were written by the old target between steps 1 and 2 would not be visible by the new target. Fix the data corruption by loading the metadata in the resume handler. Also, validate block_size

[PATCH 5.4 31/57] dm writecache: fix data corruption when reloading the target

2020-05-04 Thread Greg Kroah-Hartman
reload: 1. construct new target 2. suspend old target 3. resume new target 4. destroy old target Metadata that were written by the old target between steps 1 and 2 would not be visible by the new target. Fix the data corruption by loading the metadata in the resume handler. Also, validate block_size

[PATCH 5.2 310/313] md/raid0: avoid RAID0 data corruption due to layout confusion.

2019-10-03 Thread Greg Kroah-Hartman
size of the second smallest - etc. A change in Linux 3.14 unintentionally changed the layout for the second and subsequent zones. All the correct data is still stored, but each chunk may be assigned to a different device than in pre-3.14 kernels. This can lead to data corruption. It is not

[PATCH 5.3 341/344] md/raid0: avoid RAID0 data corruption due to layout confusion.

2019-10-03 Thread Greg Kroah-Hartman
size of the second smallest - etc. A change in Linux 3.14 unintentionally changed the layout for the second and subsequent zones. All the correct data is still stored, but each chunk may be assigned to a different device than in pre-3.14 kernels. This can lead to data corruption. It is not

[PATCH 4.19 208/211] md/raid0: avoid RAID0 data corruption due to layout confusion.

2019-10-03 Thread Greg Kroah-Hartman
size of the second smallest - etc. A change in Linux 3.14 unintentionally changed the layout for the second and subsequent zones. All the correct data is still stored, but each chunk may be assigned to a different device than in pre-3.14 kernels. This can lead to data corruption. It is not

[PATCH 4.14 182/185] md/raid0: avoid RAID0 data corruption due to layout confusion.

2019-10-03 Thread Greg Kroah-Hartman
size of the second smallest - etc. A change in Linux 3.14 unintentionally changed the layout for the second and subsequent zones. All the correct data is still stored, but each chunk may be assigned to a different device than in pre-3.14 kernels. This can lead to data corruption. It is not

[PATCH 3.16 093/132] ext4: fix data corruption caused by overlapping unaligned and aligned IO

2019-09-20 Thread Ben Hutchings
3.16.74-rc1 review patch. If anyone has any objections, please let me know. -- From: Lukas Czerner commit 57a0da28ced8707cb9f79f071a016b9d005caf5a upstream. Unaligned AIO must be serialized because the zeroing of partial blocks of unaligned AIO can result in data corruption

[PATCH 3.16 008/157] ext4: fix data corruption caused by unaligned direct AIO

2019-08-10 Thread Ben Hutchings
result in data corruption. However it decides not to serialize if the potentially unaligned aio is past i_size with the rationale that no pending writes are possible past i_size. Unfortunately if the i_size is not block aligned and the second unaligned write lands past i_size, but still into the

[PATCH 4.14 58/63] ext4: fix data corruption caused by overlapping unaligned and aligned IO

2019-05-20 Thread Greg Kroah-Hartman
From: Lukas Czerner commit 57a0da28ced8707cb9f79f071a016b9d005caf5a upstream. Unaligned AIO must be serialized because the zeroing of partial blocks of unaligned AIO can result in data corruption in case it's overlapping another in flight IO. Currently we wait for all unwritten extents b

[PATCH 5.1 108/128] ext4: fix data corruption caused by overlapping unaligned and aligned IO

2019-05-20 Thread Greg Kroah-Hartman
From: Lukas Czerner commit 57a0da28ced8707cb9f79f071a016b9d005caf5a upstream. Unaligned AIO must be serialized because the zeroing of partial blocks of unaligned AIO can result in data corruption in case it's overlapping another in flight IO. Currently we wait for all unwritten extents b

[PATCH 5.0 103/123] ext4: fix data corruption caused by overlapping unaligned and aligned IO

2019-05-20 Thread Greg Kroah-Hartman
From: Lukas Czerner commit 57a0da28ced8707cb9f79f071a016b9d005caf5a upstream. Unaligned AIO must be serialized because the zeroing of partial blocks of unaligned AIO can result in data corruption in case it's overlapping another in flight IO. Currently we wait for all unwritten extents b

[PATCH 4.19 086/105] ext4: fix data corruption caused by overlapping unaligned and aligned IO

2019-05-20 Thread Greg Kroah-Hartman
From: Lukas Czerner commit 57a0da28ced8707cb9f79f071a016b9d005caf5a upstream. Unaligned AIO must be serialized because the zeroing of partial blocks of unaligned AIO can result in data corruption in case it's overlapping another in flight IO. Currently we wait for all unwritten extents b

[PATCH 4.9 42/44] ext4: fix data corruption caused by overlapping unaligned and aligned IO

2019-05-20 Thread Greg Kroah-Hartman
From: Lukas Czerner commit 57a0da28ced8707cb9f79f071a016b9d005caf5a upstream. Unaligned AIO must be serialized because the zeroing of partial blocks of unaligned AIO can result in data corruption in case it's overlapping another in flight IO. Currently we wait for all unwritten extents b

Re: [PATCH] fs/buffer.c: Fix data corruption when buffer write with IO error

2019-04-09 Thread Jan Kara
ll clear the uptodate flag. But the > > > data in the buffer maybe newer than disk. In some case, this > > > will lead data corruption. > > > > > > For example: ext4 flush metadata to disk failed, it will clear > > > the uptodate flag. when a new coming c

Re: [PATCH] fs/buffer.c: Fix data corruption when buffer write with IO error

2019-04-09 Thread zhangxiaoxu (A)
On 4/8/2019 7:11 PM, Jan Kara wrote: On Sat 06-04-19 15:13:13, ZhangXiaoxu wrote: When the buffer write failed, 'end_buffer_write_sync' and 'end_buffer_async_write' will clear the uptodate flag. But the data in the buffer maybe newer than disk. In some case, this will

Re: [PATCH] fs/buffer.c: Fix data corruption when buffer write with IO error

2019-04-08 Thread Jan Kara
On Sat 06-04-19 15:13:13, ZhangXiaoxu wrote: > When the buffer write failed, 'end_buffer_write_sync' and > 'end_buffer_async_write' will clear the uptodate flag. But the > data in the buffer maybe newer than disk. In some case, this > will lead data corrupti

[PATCH] fs/buffer.c: Fix data corruption when buffer write with IO error

2019-04-06 Thread ZhangXiaoxu
When the buffer write failed, 'end_buffer_write_sync' and 'end_buffer_async_write' will clear the uptodate flag. But the data in the buffer maybe newer than disk. In some case, this will lead data corruption. For example: ext4 flush metadata to disk failed, it will clear the u

[PATCH 4.4 008/131] ext4: fix data corruption caused by unaligned direct AIO

2019-04-01 Thread Greg Kroah-Hartman
result in data corruption. However it decides not to serialize if the potentially unaligned aio is past i_size with the rationale that no pending writes are possible past i_size. Unfortunately if the i_size is not block aligned and the second unaligned write lands past i_size, but still into the

[PATCH 3.18 04/50] ext4: fix data corruption caused by unaligned direct AIO

2019-04-01 Thread Greg Kroah-Hartman
result in data corruption. However it decides not to serialize if the potentially unaligned aio is past i_size with the rationale that no pending writes are possible past i_size. Unfortunately if the i_size is not block aligned and the second unaligned write lands past i_size, but still into the

[PATCH 5.0 34/52] ext4: fix data corruption caused by unaligned direct AIO

2019-03-25 Thread Greg Kroah-Hartman
result in data corruption. However it decides not to serialize if the potentially unaligned aio is past i_size with the rationale that no pending writes are possible past i_size. Unfortunately if the i_size is not block aligned and the second unaligned write lands past i_size, but still into the

[PATCH 4.19 27/45] ext4: fix data corruption caused by unaligned direct AIO

2019-03-25 Thread Greg Kroah-Hartman
result in data corruption. However it decides not to serialize if the potentially unaligned aio is past i_size with the rationale that no pending writes are possible past i_size. Unfortunately if the i_size is not block aligned and the second unaligned write lands past i_size, but still into the

[PATCH 4.14 16/41] ext4: fix data corruption caused by unaligned direct AIO

2019-03-25 Thread Greg Kroah-Hartman
result in data corruption. However it decides not to serialize if the potentially unaligned aio is past i_size with the rationale that no pending writes are possible past i_size. Unfortunately if the i_size is not block aligned and the second unaligned write lands past i_size, but still into the

[PATCH 4.9 12/30] ext4: fix data corruption caused by unaligned direct AIO

2019-03-25 Thread Greg Kroah-Hartman
result in data corruption. However it decides not to serialize if the potentially unaligned aio is past i_size with the rationale that no pending writes are possible past i_size. Unfortunately if the i_size is not block aligned and the second unaligned write lands past i_size, but still into the

[PATCH 4.19 252/313] xfs: fix shared extent data corruption due to missing cow reservation

2019-02-11 Thread Greg Kroah-Hartman
fork reservation. This ultimately causes writeback to the shared extent and data corruption that is detected across md5 checks of the filesystem across a mount cycle. The problem occurs when a buffered write lands over a shared extent that crosses an extent size hint boundary and that also happens

[PATCH 3.16 146/305] Btrfs: fix data corruption due to cloning of eof block

2019-02-03 Thread Ben Hutchings
lication that got recently fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files"). Fix this by not allowing such operations to be performed and return the errno -EINVAL to user space. This is what XFS is doing as well at the VFS level. Th

Re: r8152: data corruption in various scenarios

2019-01-07 Thread Mark Lord
On 2019-01-07 1:27 p.m., mario.limoncie...@dell.com wrote: .. > The xHCI overrun workaround should only be applied on TB16/TB16, correct. > > Can you double check the verbose information from lsusb for the r8153 device > on your WD15? Sure, see below for the full output. > If it's the same infor

RE: r8152: data corruption in various scenarios

2019-01-07 Thread Mario.Limonciello
c_s...@realtek.com; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org; ryan...@realtek.com > Subject: Re: r8152: data corruption in various scenarios > > > [EXTERNAL EMAIL] > > On 2019-01-07 11:01 a.m., mario.limoncie...@dell.com wrote: > > > > TB16 co

Re: r8152: data corruption in various scenarios

2019-01-07 Thread Mark Lord
On 2019-01-07 11:01 a.m., mario.limoncie...@dell.com wrote: > > TB16 contains ASMedia host controller. It's a Thunderbolt dock and all USB > devices > are connected to ASMedia host controller in the dock. > > WD15 does not contain an ASMedia host controller, it connected to system's > USB host c

RE: r8152: data corruption in various scenarios

2019-01-07 Thread Mario.Limonciello
u...@vger.kernel.org; Limonciello, Mario; Ryankao > Subject: RE: r8152: data corruption in various scenarios > > > [EXTERNAL EMAIL] > > Monday, January 07, 2019 5:17 AM > [...] > >> This is probably an xHC bug. A similar issue is fixed by commit > >> 9da5a1092b13 &g

Re: r8152: data corruption in various scenarios

2019-01-06 Thread Mark Lord
On 2019-01-07 1:46 a.m., Kai Heng Feng wrote: > > Do you happen to use a Dell system? We can do some test here. Yes. It is a Dell XPS 13 9360 i7-8550U notebook, with the Dell WD15 USB-C dock. -- Mark Lord Real-Time Remedies Inc. ml...@pobox.com

Re: r8152: data corruption in various scenarios

2019-01-06 Thread Kai Heng Feng
> On Jan 7, 2019, at 12:13, Mark Lord wrote: > > On 2019-01-06 11:09 p.m., Kai Heng Feng wrote: >> >> >>> On Jan 7, 2019, at 05:16, Mark Lord wrote: >>> >>> On 2019-01-06 4:13 p.m., Mark Lord wrote: On 2019-01-06 2:14 p.m., Kai Heng Feng wrote:>> On Jan 5, 2019, at 10:14 PM, Mar

Re: r8152: data corruption in various scenarios

2019-01-06 Thread Mark Lord
On 2019-01-06 11:09 p.m., Kai Heng Feng wrote: > > >> On Jan 7, 2019, at 05:16, Mark Lord wrote: >> >> On 2019-01-06 4:13 p.m., Mark Lord wrote: >>> On 2019-01-06 2:14 p.m., Kai Heng Feng wrote:>> On Jan 5, 2019, at 10:14 >>> PM, Mark Lord >>> wrote: >>> .. > There is even now a special ha

Re: r8152: data corruption in various scenarios

2019-01-06 Thread Kai Heng Feng
> On Jan 7, 2019, at 05:16, Mark Lord wrote: > > On 2019-01-06 4:13 p.m., Mark Lord wrote: >> On 2019-01-06 2:14 p.m., Kai Heng Feng wrote:>> On Jan 5, 2019, at 10:14 PM, >> Mark Lord >> wrote: >> .. There is even now a special hack in the upstream r8152.c to attempt to detect >>>

RE: r8152: data corruption in various scenarios

2019-01-06 Thread Hayes Wang
Monday, January 07, 2019 5:17 AM [...] >> This is probably an xHC bug. A similar issue is fixed by commit 9da5a1092b13 >> ("xhci: Bad Ethernet performance plugged in ASM1042A host”). >> >>> I just got that exact message above, with the r8152 in my 1-day old WD15 >>> dock, >>> with the TB16 "worka

Re: r8152: data corruption in various scenarios

2019-01-06 Thread Mark Lord
On 2019-01-06 4:13 p.m., Mark Lord wrote: > On 2019-01-06 2:14 p.m., Kai Heng Feng wrote:>> On Jan 5, 2019, at 10:14 PM, > Mark Lord > wrote: > .. >>> There is even now a special hack in the upstream r8152.c to attempt to >>> detect >>> a Dell TB16 dock and disable RX Aggregation in the driver t

Re: r8152: data corruption in various scenarios

2019-01-06 Thread Mark Lord
On 2019-01-06 2:14 p.m., Kai Heng Feng wrote:>> On Jan 5, 2019, at 10:14 PM, Mark Lord wrote: .. >> There is even now a special hack in the upstream r8152.c to attempt to detect >> a Dell TB16 dock and disable RX Aggregation in the driver to prevent such >> issues. >> >> Well.. I have a WD15 doc

Re: r8152: data corruption in various scenarios

2019-01-06 Thread Kai Heng Feng
> On Jan 5, 2019, at 10:14 PM, Mark Lord wrote: > > A couple of years back, I reported data corruption resulting from > a change in kernel 3.16 which enabled hardware checksums in the r8152 driver. > This was happening on an embedded system that was using a r8152 USB dongle. &

Re: r8152: data corruption in various scenarios

2019-01-05 Thread Mark Lord
On 2019-01-05 9:14 a.m., Mark Lord wrote: > A couple of years back, I reported data corruption resulting from > a change in kernel 3.16 which enabled hardware checksums in the r8152 driver. > This was happening on an embedded system that was using a r8152 USB dongle. > > At the ti

r8152: data corruption in various scenarios

2019-01-05 Thread Mark Lord
A couple of years back, I reported data corruption resulting from a change in kernel 3.16 which enabled hardware checksums in the r8152 driver. This was happening on an embedded system that was using a r8152 USB dongle. At the time, it was very difficult to figure out what could possibly be

[PATCH AUTOSEL 4.19 53/68] iomap: dio data corruption and spurious errors when pipes fill

2018-11-28 Thread Sasha Levin
From: Dave Chinner [ Upstream commit 4721a6010990971440b4ffefbdf014976b8eda2f ] When doing direct IO to a pipe for do_splice_direct(), then pipe is trivial to fill up and overflow as it can only hold 16 pages. At this point bio_iov_iter_get_pages() then returns -EFAULT, and we abort the IO submi

[PATCH 4.4 135/160] Btrfs: fix data corruption due to cloning of eof block

2018-11-19 Thread Greg Kroah-Hartman
lication that got recently fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files"). Fix this by not allowing such operations to be performed and return the errno -EINVAL to user space. This is what XFS is doing as well at the VFS level. Th

[PATCH 4.9 51/83] Btrfs: fix data corruption due to cloning of eof block

2018-11-19 Thread Greg Kroah-Hartman
lication that got recently fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files"). Fix this by not allowing such operations to be performed and return the errno -EINVAL to user space. This is what XFS is doing as well at the VFS level. Th

[PATCH 4.14 071/124] Btrfs: fix data corruption due to cloning of eof block

2018-11-19 Thread Greg Kroah-Hartman
lication that got recently fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files"). Fix this by not allowing such operations to be performed and return the errno -EINVAL to user space. This is what XFS is doing as well at the VFS level. Th

[PATCH 4.18 103/171] Btrfs: fix data corruption due to cloning of eof block

2018-11-19 Thread Greg Kroah-Hartman
lication that got recently fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files"). Fix this by not allowing such operations to be performed and return the errno -EINVAL to user space. This is what XFS is doing as well at the VFS level. Th

[PATCH 4.19 127/205] Btrfs: fix data corruption due to cloning of eof block

2018-11-19 Thread Greg Kroah-Hartman
lication that got recently fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files"). Fix this by not allowing such operations to be performed and return the errno -EINVAL to user space. This is what XFS is doing as well at the VFS level. Th

[PATCH 3.16 272/366] crypto: padlock-aes - Fix Nano workaround data corruption

2018-11-11 Thread Ben Hutchings
3.16.61-rc1 review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit 46d8c4b28652d35dc6cfb5adf7f54e102fc04384 upstream. This was detected by the self-test thanks to Ard's chunking patch. I finally got around to testing this out on my ancient

Re: BUG: aio/direct-io data corruption in 4.7

2018-11-09 Thread Jack Wang
Gregory Shapiro 于2018年11月6日周二 下午12:31写道: > > Hi Jack, > I tested it in 4.9.102 and I checked the latest code from elixir > (versions 4.19 and 4.20) and the error in code is still present there. > More on the scenario and the bug: > I experienced data corruption in my appli

Re: BUG: aio/direct-io data corruption in 4.7

2018-11-06 Thread Gregory Shapiro
Hi Jack, I tested it in 4.9.102 and I checked the latest code from elixir (versions 4.19 and 4.20) and the error in code is still present there. More on the scenario and the bug: I experienced data corruption in my application (nvme based storage). The issue was caused because of faulty hardware

Re: BUG: aio/direct-io data corruption in 4.7

2018-11-05 Thread Jack Wang
Gregory Shapiro 于2018年11月5日周一 下午4:19写道: > > Hello, my name is Gregory Shapiro and I am a newbie on this list. > I recently encountered data corruption as I got a kernel to > acknowledge write ("io_getevents" system call with a correct number of > bytes) but underg

Re: BUG: aio/direct-io data corruption in 4.7

2018-11-05 Thread Gregory Shapiro
Hello, my name is Gregory Shapiro and I am a newbie on this list. I recently encountered data corruption as I got a kernel to acknowledge write ("io_getevents" system call with a correct number of bytes) but undergoing write to disk failed. After investigating the problem I found it is

Re: [f2fs-dev] [PATCH] f2fs: fix data corruption issue with hardware encryption

2018-10-10 Thread Sahitya Tummala
gt; Direct IO can be used in case of hardware encryption. The following > > > > > scenario results into data corruption issue in this path - > > > > > > > > > > Thread A - Thread B- > > >

[PATCH 3.18 041/105] md/raid5: fix data corruption of replacements after originals dropped

2018-09-24 Thread Greg Kroah-Hartman
ted cannot read from the dropped device anymore. It prints lots of WARN_ON messages. And it results in data corruption because existing stripes write problematic data into its replacement device and update the progress. \# Erase disks (1MB + 2GB) dd if=/dev/zero of=/dev/sda bs=1MB count=2049 dd if=/d

[PATCH 4.18 065/158] md/raid5: fix data corruption of replacements after originals dropped

2018-09-17 Thread Greg Kroah-Hartman
ted cannot read from the dropped device anymore. It prints lots of WARN_ON messages. And it results in data corruption because existing stripes write problematic data into its replacement device and update the progress. \# Erase disks (1MB + 2GB) dd if=/dev/zero of=/dev/sda bs=1MB count=2049 dd if=/d

[PATCH 4.18 020/158] Btrfs: fix data corruption when deduplicating between different files

2018-09-17 Thread Greg Kroah-Hartman
147 ae ae ae ae ae ae ae ae ae ae ae ae ae ae ae ae * 11777540 ae ae ae ae ae ae ae ae 11777550 # The bytes in range 2515659 to 2519040 have a value of 0x00 and not a # value of 0xae, data corruption happened due to the deduplication # operation. So fix this by rounding down, to the

[PATCH 4.14 034/126] md/raid5: fix data corruption of replacements after originals dropped

2018-09-17 Thread Greg Kroah-Hartman
ted cannot read from the dropped device anymore. It prints lots of WARN_ON messages. And it results in data corruption because existing stripes write problematic data into its replacement device and update the progress. \# Erase disks (1MB + 2GB) dd if=/dev/zero of=/dev/sda bs=1MB count=2049 dd if=/d

[PATCH 4.14 010/126] Btrfs: fix data corruption when deduplicating between different files

2018-09-17 Thread Greg Kroah-Hartman
147 ae ae ae ae ae ae ae ae ae ae ae ae ae ae ae ae * 11777540 ae ae ae ae ae ae ae ae 11777550 # The bytes in range 2515659 to 2519040 have a value of 0x00 and not a # value of 0xae, data corruption happened due to the deduplication # operation. So fix this by rounding down, to the

[PATCH 4.9 25/70] md/raid5: fix data corruption of replacements after originals dropped

2018-09-17 Thread Greg Kroah-Hartman
ted cannot read from the dropped device anymore. It prints lots of WARN_ON messages. And it results in data corruption because existing stripes write problematic data into its replacement device and update the progress. \# Erase disks (1MB + 2GB) dd if=/dev/zero of=/dev/sda bs=1MB count=2049 dd if=/d

[PATCH 4.4 19/56] md/raid5: fix data corruption of replacements after originals dropped

2018-09-17 Thread Greg Kroah-Hartman
ted cannot read from the dropped device anymore. It prints lots of WARN_ON messages. And it results in data corruption because existing stripes write problematic data into its replacement device and update the progress. \# Erase disks (1MB + 2GB) dd if=/dev/zero of=/dev/sda bs=1MB count=2049 dd if=/d

Re: [PATCH 4.4 123/124] crypto: padlock-aes - Fix Nano workaround data corruption

2018-09-06 Thread Ben Hutchings
On Sat, 2018-08-04 at 11:01 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: Herbert Xu > > commit 46d8c4b28652d35dc6cfb5adf7f54e102fc04384 upstream. > > This was detected by the self-test thanks to

[PATCH AUTOSEL 4.18 024/131] md/raid5: fix data corruption of replacements after originals dropped

2018-09-02 Thread Sasha Levin
it will result in data corruption. Actually, it's just an unhandled case of replacement. In commit (md/raid5: fix interaction of 'replace' and 'recovery'.), if a NeedReplace device is not UPTODATE then that is an error, the commit just simply print WARN_ON but also mark

[PATCH AUTOSEL 4.14 16/89] md/raid5: fix data corruption of replacements after originals dropped

2018-09-02 Thread Sasha Levin
it will result in data corruption. Actually, it's just an unhandled case of replacement. In commit (md/raid5: fix interaction of 'replace' and 'recovery'.), if a NeedReplace device is not UPTODATE then that is an error, the commit just simply print WARN_ON but also mark

[PATCH AUTOSEL 4.4 07/47] md/raid5: fix data corruption of replacements after originals dropped

2018-09-02 Thread Sasha Levin
it will result in data corruption. Actually, it's just an unhandled case of replacement. In commit (md/raid5: fix interaction of 'replace' and 'recovery'.), if a NeedReplace device is not UPTODATE then that is an error, the commit just simply print WARN_ON but also mark

[PATCH AUTOSEL 4.9 08/62] md/raid5: fix data corruption of replacements after originals dropped

2018-09-02 Thread Sasha Levin
it will result in data corruption. Actually, it's just an unhandled case of replacement. In commit (md/raid5: fix interaction of 'replace' and 'recovery'.), if a NeedReplace device is not UPTODATE then that is an error, the commit just simply print WARN_ON but also mark

[PATCH 3.18 80/85] crypto: padlock-aes - Fix Nano workaround data corruption

2018-08-07 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit 46d8c4b28652d35dc6cfb5adf7f54e102fc04384 upstream. This was detected by the self-test thanks to Ard's chunking patch. I finally got around to testing this out on my ancient

[PATCH 4.9 12/17] Btrfs: fix file data corruption after cloning a range and fsync

2018-08-07 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Filipe Manana commit bd3599a0e142cd73edd3b6801068ac3f48ac771a upstream. When we clone a range into a file we can end up dropping existing extent maps (or trimming them) and replacing them with

[PATCH 4.14 13/21] Btrfs: fix file data corruption after cloning a range and fsync

2018-08-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Filipe Manana commit bd3599a0e142cd73edd3b6801068ac3f48ac771a upstream. When we clone a range into a file we can end up dropping existing extent maps (or trimming them) and replacing them with

  1   2   3   4   5   6   7   8   9   >