Re: DNAME_INLINE_LEN versus CONFIG_GENERIC_LOCKBREAK

2014-07-03 Thread Andi Kleen
> IF you've turned on debugging options, then you've already lost more > performance that careful packing of the dentry slab cache gains you. > There's no point in carefully tuning DNAME_INLINE_LEN for debug > options - it's just code that will break and annoy people as debug > implementations chan

Re: DNAME_INLINE_LEN versus CONFIG_GENERIC_LOCKBREAK

2014-07-03 Thread Dave Chinner
On Thu, Jul 03, 2014 at 12:53:01PM -0700, Andi Kleen wrote: > Rasmus Villemoes writes: > > > In dcache.h, DNAME_INLINE_LEN is carefully chosen so that sizeof(struct > > dentry) is a (specific) multiple of 64 bytes. Obviously this breaks when > > certain debug options are chosen (DEBUG_LOCK_ALLOC

Re: DNAME_INLINE_LEN versus CONFIG_GENERIC_LOCKBREAK

2014-07-03 Thread Andi Kleen
Rasmus Villemoes writes: > In dcache.h, DNAME_INLINE_LEN is carefully chosen so that sizeof(struct > dentry) is a (specific) multiple of 64 bytes. Obviously this breaks when > certain debug options are chosen (DEBUG_LOCK_ALLOC and DEBUG_SPINLOCK), > but also, AFAICT, on architectures with CONFIG_

DNAME_INLINE_LEN versus CONFIG_GENERIC_LOCKBREAK

2014-07-03 Thread Rasmus Villemoes
Hi, In dcache.h, DNAME_INLINE_LEN is carefully chosen so that sizeof(struct dentry) is a (specific) multiple of 64 bytes. Obviously this breaks when certain debug options are chosen (DEBUG_LOCK_ALLOC and DEBUG_SPINLOCK), but also, AFAICT, on architectures with CONFIG_GENERIC_LOCKBREAK. I'm not su