Re: Cross-referencing frenzy

2001-04-19 Thread Jim Treadway
On Thu, 19 Apr 2001, Eric S. Raymond wrote: > Andreas Dilger <[EMAIL PROTECTED]>: > > However, I'm not sure that your reasoning for removing these is correct. > > For example, one symbol that I saw was CONFIG_EXT2_CHECK, which is code > > that used to be enabled in the kernel, but is currently #i

Re: [kbuild-devel] Re: Cross-referencing frenzy

2001-04-19 Thread Peter Samuelson
[esr] > > CONFIG_SOUND_YMPCI: arch/ppc/configs/power3_defconfig >arch/arm/def-configs/footbridge arch/arm/def-configs/rpc arch/arm/def-configs/lart >arch/arm/def-configs/shark [jgarzik] > typo, that should be ...YMFPCI. Actually it's not a typo (although the fix is the same). The old "SB-c

Re: Cross-referencing frenzy

2001-04-19 Thread Eric S. Raymond
Andreas Dilger <[EMAIL PROTECTED]>: > Could you make a list that splits the symbols up by each of the above > failure conditions? It would make the task of deciding how to fix the > "problem" more apparent. There are 32 possible categories. I need to eyeball them and decide which ones are signi

Re: [kbuild-devel] Re: Cross-referencing frenzy

2001-04-19 Thread Rogier Wolff
Eric S. Raymond wrote: > Rogier Wolff <[EMAIL PROTECTED]>: > > I think it should be possible to do: > > > > /* to enable the special stuff, change the "undef" to "define", > >If you really want you can add this to Config.in so that you're presented > >with this choice when configuring yo

Re: Cross-referencing frenzy

2001-04-19 Thread Eric S. Raymond
Jeff Garzik <[EMAIL PROTECTED]>: > "Eric S. Raymond" wrote: > > CONFIG_SOUND_YMPCI: arch/ppc/configs/power3_defconfig >arch/arm/def-configs/footbridge arch/arm/def-configs/rpc arch/arm/def-configs/lart >arch/arm/def-configs/shark > > typo, that should be ...YMFPCI. > > maybe you could add soun

Re: Cross-referencing frenzy

2001-04-19 Thread Jeff Garzik
"Eric S. Raymond" wrote: > CONFIG_SOUND_YMPCI: arch/ppc/configs/power3_defconfig >arch/arm/def-configs/footbridge arch/arm/def-configs/rpc arch/arm/def-configs/lart >arch/arm/def-configs/shark typo, that should be ...YMFPCI. maybe you could add soundex to catch misspellings ;-) -- Jeff Garzi

Re: Cross-referencing frenzy

2001-04-19 Thread Eric S. Raymond
Russell King <[EMAIL PROTECTED]>: > On Wed, Apr 18, 2001 at 11:34:45PM -0400, Eric S. Raymond wrote: > > Especially look for CONFIG_* symbols that only occur in .c or .h files. > > I think almost every one of those lines represents a bug that needs to be > > fixed. > > It'd be easier to read if t

Re: [kbuild-devel] Re: Cross-referencing frenzy

2001-04-19 Thread Eric S. Raymond
Rogier Wolff <[EMAIL PROTECTED]>: > I think it should be possible to do: > > /* to enable the special stuff, change the "undef" to "define", >If you really want you can add this to Config.in so that you're presented >with this choice when configuring your kernel. But it's not neccesary >

Re: Cross-referencing frenzy

2001-04-19 Thread Mike Castle
On Wed, Apr 18, 2001 at 10:49:01PM -0600, Andreas Dilger wrote: > However, I'm not sure that your reasoning for removing these is correct. > For example, one symbol that I saw was CONFIG_EXT2_CHECK, which is code > that used to be enabled in the kernel, but is currently #ifdef'd out with > the abo

Re: Cross-referencing frenzy

2001-04-19 Thread Alan Cox
> > > CONFIG_DEVFS: Documentation/filesystems/devfs/ChangeLog > > > > These are options that used to be used, > > > These should not be removed > > This makes no sense at all. Do you have any particular > reason for keeping this deadwood around ? Because its a changelog ? - To unsubsc

Re: Cross-referencing frenzy

2001-04-19 Thread Rogier Wolff
Eric S. Raymond wrote: > Richard Gooch <[EMAIL PROTECTED]>: > > > Look at the filename. ;-) They're not being kept around, they just > > > happen to be mentioned in the devfs ChangeLog, and esr's overzealous > > > crossref tool caught them. *grin* > > I've already fixed that. > > > A cleaner so

Re: Cross-referencing frenzy

2001-04-19 Thread Russell King
On Wed, Apr 18, 2001 at 11:34:45PM -0400, Eric S. Raymond wrote: > Especially look for CONFIG_* symbols that only occur in .c or .h files. > I think almost every one of those lines represents a bug that needs to be > fixed. It'd be easier to read if they were alphanumerically sorted. The ones th

Re: Cross-referencing frenzy

2001-04-18 Thread Jeff Garzik
Richard Gooch wrote: > Exactly. A ChangeLog should pre preserved for all time. It is an > incredibly useful tool. Many times I've gone back and checked when > something was done, and in relation to other changes before, after or > around the same time. agreed > Except the CONFIG_APM_IGNORE_SUSPE

Re: Cross-referencing frenzy

2001-04-18 Thread Eric S. Raymond
Richard Gooch <[EMAIL PROTECTED]>: > > Look at the filename. ;-) They're not being kept around, they just > > happen to be mentioned in the devfs ChangeLog, and esr's overzealous > > crossref tool caught them. *grin* I've already fixed that. > A cleaner solution is to parse the source code, ign

Re: Cross-referencing frenzy

2001-04-18 Thread Eric S. Raymond
Edward S. Marshall <[EMAIL PROTECTED]>: > Look at the filename. ;-) They're not being kept around, they just happen > to be mentioned in the devfs ChangeLog, and esr's overzealous crossref > tool caught them. *grin* > > Perhaps the tool should be modified to exempt comments in code and files > in

Re: Cross-referencing frenzy

2001-04-18 Thread Richard Gooch
Edward S. Marshall writes: > On Thu, Apr 19, 2001 at 01:11:07AM -0300, Rik van Riel wrote: > > On Thu, 19 Apr 2001, Richard Gooch wrote: > > > esr wrote: > > > > CONFIG_DEVFS: Documentation/filesystems/devfs/ChangeLog > > > > > > These are options that used to be used, > > > > > These sh

Re: Cross-referencing frenzy

2001-04-18 Thread Andreas Dilger
Eric writes: > So. I've written a cross-reference analyzer for the configuration symbol > namespace. It's included with CML 1.2.0, which I just released. The > main reason I wrote it was to detect broken symbols. > > A symbol is non-broken when: > * It is used in either code or a Makefil

Re: Cross-referencing frenzy

2001-04-18 Thread Edward S. Marshall
On Thu, Apr 19, 2001 at 01:11:07AM -0300, Rik van Riel wrote: > On Thu, 19 Apr 2001, Richard Gooch wrote: > > esr wrote: > > > CONFIG_DEVFS: Documentation/filesystems/devfs/ChangeLog > > > > These are options that used to be used, > > > These should not be removed > > This makes no sens

Re: Cross-referencing frenzy

2001-04-18 Thread Rik van Riel
On Thu, 19 Apr 2001, Richard Gooch wrote: > > CONFIG_APM_IGNORE_SUSPEND_BOUNCE: arch/i386/kernel/apm.c > > CONFIG_DEVFS_TTY_COMPAT: Documentation/filesystems/devfs/ChangeLog > > CONFIG_DEVFS_BOOT_OPTIONS: Documentation/filesystems/devfs/ChangeLog > > CONFIG_DEVFS_DISABLE_OLD_NAMES: Documentation/

Re: Cross-referencing frenzy

2001-04-18 Thread Richard Gooch
Eric S. Raymond writes: > So. I've written a cross-reference analyzer for the configuration symbol > namespace. It's included with CML 1.2.0, which I just released. The > main reason I wrote it was to detect broken symbols. > > A symbol is non-broken when: > * It is used in either code o

Cross-referencing frenzy

2001-04-18 Thread Eric S. Raymond
So. I've written a cross-reference analyzer for the configuration symbol namespace. It's included with CML 1.2.0, which I just released. The main reason I wrote it was to detect broken symbols. A symbol is non-broken when: * It is used in either code or a Makefile * It is set i