Re: Crash in elevator_dispatch_fn() (e.g. deadline_dispatch()) when changing elevators.

2014-01-23 Thread Frank Mayhar
On Thu, 2014-01-23 at 13:56 -0500, Tejun Heo wrote: > On Thu, Jan 23, 2014 at 10:38:33AM -0800, Frank Mayhar wrote: > > On Wed, 2014-01-22 at 07:46 -0800, Frank Mayhar wrote: > > > On Tue, 2014-01-21 at 07:58 -0800, Frank Mayhar wrote: > > > > Replacing? Or adding to? Is BYPASS always set when DY

Re: Crash in elevator_dispatch_fn() (e.g. deadline_dispatch()) when changing elevators.

2014-01-23 Thread Tejun Heo
On Thu, Jan 23, 2014 at 10:38:33AM -0800, Frank Mayhar wrote: > On Wed, 2014-01-22 at 07:46 -0800, Frank Mayhar wrote: > > On Tue, 2014-01-21 at 07:58 -0800, Frank Mayhar wrote: > > > Replacing? Or adding to? Is BYPASS always set when DYING is set? (My > > > guess is not but I haven't done an ex

Re: Crash in elevator_dispatch_fn() (e.g. deadline_dispatch()) when changing elevators.

2014-01-23 Thread Frank Mayhar
On Wed, 2014-01-22 at 07:46 -0800, Frank Mayhar wrote: > On Tue, 2014-01-21 at 07:58 -0800, Frank Mayhar wrote: > > Replacing? Or adding to? Is BYPASS always set when DYING is set? (My > > guess is not but I haven't done an exhaustive analysis.) So the > > relevant code snippet in __elv_next_re

Re: Crash in elevator_dispatch_fn() (e.g. deadline_dispatch()) when changing elevators.

2014-01-22 Thread Frank Mayhar
On Tue, 2014-01-21 at 07:58 -0800, Frank Mayhar wrote: > Replacing? Or adding to? Is BYPASS always set when DYING is set? (My > guess is not but I haven't done an exhaustive analysis.) So the > relevant code snippet in __elv_next_request() would be: > if (unlikely(blk_queue_dying(

Crash in elevator_dispatch_fn() (e.g. deadline_dispatch()) when changing elevators.

2014-01-21 Thread Frank Mayhar
On Sat, 2014-01-18 at 09:31 -0500, Tejun Heo wrote: > Hello, Frank. > > On Fri, Jan 17, 2014 at 01:59:36PM -0800, Frank Mayhar wrote: > > After investigation, it's clear that the elevator switch code is trying > > to quiesce the request queue and sets the bypass flag. Unfortunately, > > scsi_mode