Re: Commit fcd8843c40 breaks old compilers

2017-11-20 Thread Boris Ostrovsky
On 11/20/2017 07:52 AM, Arnd Bergmann wrote: > On Sat, Nov 18, 2017 at 7:07 PM, Boris Ostrovsky > wrote: >> >> On 11/18/2017 12:39 PM, Trond Myklebust wrote: >>> On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote: A similar bug was fixed by e0714ec4f9efe7b86828b0dcc077fd8f5d8e5e91

Re: Commit fcd8843c40 breaks old compilers

2017-11-20 Thread Arnd Bergmann
On Sat, Nov 18, 2017 at 7:07 PM, Boris Ostrovsky wrote: > > > On 11/18/2017 12:39 PM, Trond Myklebust wrote: >> >> On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote: >>> >>> A similar bug was fixed by e0714ec4f9efe7b86828b0dcc077fd8f5d8e5e91 >>> but >>> I don't think the same approach can

Re: Commit fcd8843c40 breaks old compilers

2017-11-18 Thread Boris Ostrovsky
On 11/18/2017 01:12 PM, Trond Myklebust wrote: Sigh OK, how about something like the following then: { .data = { 0xff, 0xff, 0xff, 0xff, 0 }, } Yes, this does build. diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index 54fd56d..daa6085 100644 --- a/fs/nfs/nfs4state.c +++ b/fs

Re: Commit fcd8843c40 breaks old compilers

2017-11-18 Thread Trond Myklebust
On Sat, 2017-11-18 at 13:07 -0500, Boris Ostrovsky wrote: > > On 11/18/2017 12:39 PM, Trond Myklebust wrote: > > On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote: > > > Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older > > > compilers which cannot process initializers for ano

Re: Commit fcd8843c40 breaks old compilers

2017-11-18 Thread Boris Ostrovsky
On 11/18/2017 12:39 PM, Trond Myklebust wrote: On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote: Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older compilers which cannot process initializers for anonymous structures: +const nfs4_stateid invalid_stateid = { + { +

Re: Commit fcd8843c40 breaks old compilers

2017-11-18 Thread Trond Myklebust
On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote: > Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older > compilers which cannot process initializers for anonymous structures: > > +const nfs4_stateid invalid_stateid = { > + { > + .seqid = cpu_to_be32(0xf

Commit fcd8843c40 breaks old compilers

2017-11-18 Thread Boris Ostrovsky
Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older compilers which cannot process initializers for anonymous structures: +const nfs4_stateid invalid_stateid = { + { + .seqid = cpu_to_be32(0xU), + .other = { 0 }, + }, + .type = NFS4