Re: CVE-2016-7097 causes acl leak

On Thu 15-12-16 07:22:30, Mark Salyzyn wrote: > On 12/14/2016 03:30 PM, Greg KH wrote: > >On Wed, Dec 14, 2016 at 12:20:50PM -0800, Mark Salyzyn wrote: > >>On 12/13/2016 04:00 PM, Greg KH wrote: > >>>On Tue, Dec 13, 2016 at 03:42:58PM -0800, Mark Salyzyn wrote: > On 12/12/2016 10:26 PM, Cong Wa

Re: CVE-2016-7097 causes acl leak

On 12/14/2016 03:30 PM, Greg KH wrote: On Wed, Dec 14, 2016 at 12:20:50PM -0800, Mark Salyzyn wrote: On 12/13/2016 04:00 PM, Greg KH wrote: On Tue, Dec 13, 2016 at 03:42:58PM -0800, Mark Salyzyn wrote: On 12/12/2016 10:26 PM, Cong Wang wrote: On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wro

Re: CVE-2016-7097 causes acl leak

On Wed, Dec 14, 2016 at 12:20:50PM -0800, Mark Salyzyn wrote: > On 12/13/2016 04:00 PM, Greg KH wrote: > > On Tue, Dec 13, 2016 at 03:42:58PM -0800, Mark Salyzyn wrote: > > > On 12/12/2016 10:26 PM, Cong Wang wrote: > > > > On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn > > > > wrote: > > > > > Th

Re: CVE-2016-7097 causes acl leak

On 12/13/2016 04:00 PM, Greg KH wrote: On Tue, Dec 13, 2016 at 03:42:58PM -0800, Mark Salyzyn wrote: On 12/12/2016 10:26 PM, Cong Wang wrote: On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. Only the 9p case is obvious to m

Re: CVE-2016-7097 causes acl leak

On Tue, Dec 13, 2016 at 03:42:58PM -0800, Mark Salyzyn wrote: > On 12/12/2016 10:26 PM, Cong Wang wrote: > > On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: > > > The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. > > > > Only the 9p case is obvious to me: > > > > diff --git a

Re: CVE-2016-7097 causes acl leak

On Tue, Dec 13, 2016 at 3:28 AM, Jan Kara wrote: > On Mon 12-12-16 22:26:09, Cong Wang wrote: >> On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: >> > >> > The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. >> >> >> Only the 9p case is obvious to me: > > Agreed and the patch bel

Re: CVE-2016-7097 causes acl leak

On 12/12/2016 10:26 PM, Cong Wang wrote: On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. Only the 9p case is obvious to me: diff --git a/fs/9p/acl.c b/fs/9p/acl.c index b3c2cc7..082d227 100644 --- a/fs/9p/acl.c +++ b/fs/9p

Re: CVE-2016-7097 causes acl leak

On Tue 13-12-16 07:55:23, Mark Salyzyn wrote: > On 12/12/2016 10:26 PM, Cong Wang wrote: > >On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: > >>The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. > > > >Only the 9p case is obvious to me: > > > >diff --git a/fs/9p/acl.c b/fs/9p/ac

Re: CVE-2016-7097 causes acl leak

On 12/12/2016 10:26 PM, Cong Wang wrote: On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. Only the 9p case is obvious to me: diff --git a/fs/9p/acl.c b/fs/9p/acl.c index b3c2cc7..082d227 100644 --- a/fs/9p/acl.c +++ b/fs/9p

Re: CVE-2016-7097 causes acl leak

On Mon 12-12-16 22:26:09, Cong Wang wrote: > On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: > > > > The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. > > > Only the 9p case is obvious to me: Agreed and the patch below looks good to me. Please make it a proper patch (includi

Re: CVE-2016-7097 causes acl leak

On Mon 12-12-16 16:26:00, Mark Salyzyn wrote: > On 12/11/2016 04:34 PM, Cong Wang wrote: > >On Mon, Dec 5, 2016 at 9:16 AM, Mark Salyzyn wrote: > >>Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of > >>an acl leak. > >> > >>posix_acl_update_mode(inose, &mode, &acl); > >> >

Re: CVE-2016-7097 causes acl leak

On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn wrote: > > The leaks were introduced in 9p, gfs2, jfs and xfs drivers only. Only the 9p case is obvious to me: diff --git a/fs/9p/acl.c b/fs/9p/acl.c index b3c2cc7..082d227 100644 --- a/fs/9p/acl.c +++ b/fs/9p/acl.c @@ -277,6 +277,7 @@ static int v9

Re: CVE-2016-7097 causes acl leak

On 12/11/2016 04:34 PM, Cong Wang wrote: On Mon, Dec 5, 2016 at 9:16 AM, Mark Salyzyn wrote: Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of an acl leak. posix_acl_update_mode(inose, &mode, &acl); . . . posix_acl_release(acl); acl is NULLed in posix_acl_update_mo

Re: CVE-2016-7097 causes acl leak

On Mon, Dec 12, 2016 at 2:46 AM, Jan Kara wrote: > So I agree with you the mentioned commit didn't change anything. I took > care to keep the previous behavior wrt NULLing the acl pointer (obviously I > could have made mistake somewhere but I don't see where). However your > patch is definitely wr

Re: CVE-2016-7097 causes acl leak

On Sun 11-12-16 16:34:31, Cong Wang wrote: > On Mon, Dec 5, 2016 at 9:16 AM, Mark Salyzyn wrote: > > Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of > > an acl leak. > > > > posix_acl_update_mode(inose, &mode, &acl); > > > > . . . > > > > posix_acl_release(acl); > > > >

Re: CVE-2016-7097 causes acl leak

On Mon, Dec 5, 2016 at 9:16 AM, Mark Salyzyn wrote: > Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of > an acl leak. > > posix_acl_update_mode(inose, &mode, &acl); > > . . . > > posix_acl_release(acl); > > > acl is NULLed in posix_acl_update_mode to signal caller to not

Re: CVE-2016-7097 causes acl leak

On Mon, Dec 05, 2016 at 09:16:31AM -0800, Mark Salyzyn wrote: > Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of > an acl leak. > > posix_acl_update_mode(inose, &mode, &acl); > > . . . > > posix_acl_release(acl); > > > acl is NULLed in posix_acl_update_mode to signal

CVE-2016-7097 causes acl leak

Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of an acl leak. posix_acl_update_mode(inose, &mode, &acl); . . . posix_acl_release(acl); acl is NULLed in posix_acl_update_mode to signal caller to not update the acl; but because it is nulled, it is never released.