Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-24 Thread Fabio Aiuto
On Sat, Mar 20, 2021 at 04:28:51AM -0700, Joe Perches wrote: > > Actually, these would seem to be better as one or multiple functions with > local statics or even as static inlines functions in the .h file > > $ git grep -w RTW_WPA_OUI drivers/staging/rtl8723bs/core > drivers/staging/rtl8723bs/co

Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-21 Thread Greg KH
On Sat, Mar 20, 2021 at 03:49:12PM +0100, Fabio Aiuto wrote: > On Sat, Mar 20, 2021 at 11:59:44AM +0100, Greg KH wrote: > > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > > Hi, > > > > > > here's an issue in checkpatch.pl > > > > > > $ perl script/checkpatch.pl -f drivers/stagin

Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-20 Thread Fabio Aiuto
On Sat, Mar 20, 2021 at 11:59:44AM +0100, Greg KH wrote: > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > Hi, > > > > here's an issue in checkpatch.pl > > > > $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c > > > > I get three warning related to an extern

Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-20 Thread Fabio Aiuto
On Sat, Mar 20, 2021 at 04:28:51AM -0700, Joe Perches wrote: > On Sat, 2021-03-20 at 11:59 +0100, Greg KH wrote: > > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > > Hi, > > > > > > here's an issue in checkpatch.pl > > > > > > $ perl script/checkpatch.pl -f drivers/staging/rtl87

Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-20 Thread Joe Perches
On Sat, 2021-03-20 at 11:59 +0100, Greg KH wrote: > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > Hi, > > > > here's an issue in checkpatch.pl > > > > $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c > > > > I get three warning related to an extern declar

CHECKPATCH: missing a warning soon after include files decl -c

2021-03-20 Thread Fabio Aiuto
Hi, here's an issue in checkpatch.pl $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c I get three warning related to an extern declaration WARNING: externs should be avoided in .c files #14: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:14: +extern unsigned char WMM_OUI[];

Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-20 Thread Greg KH
On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > Hi, > > here's an issue in checkpatch.pl > > $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c > > I get three warning related to an extern declaration > > WARNING: externs should be avoided in .c files > #14: F