Re: CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-08 Thread Sebastian Andrzej Siewior
On 2019-01-08 10:06:25 [+0100], Peter Zijlstra wrote: > Much appreciated; I queued it as the below. thank you, queued, too. Sebastian

Re: CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-08 Thread Peter Zijlstra
On Tue, Jan 08, 2019 at 06:30:59AM +0100, Mike Galbraith wrote: > On Mon, 2019-01-07 at 13:52 +0100, Peter Zijlstra wrote: > > On Mon, Jan 07, 2019 at 01:28:34PM +0100, Mike Galbraith wrote: > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > > index 960ad0ce77d7..420624c49f38 100644 >

Re: CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-07 Thread Mike Galbraith
On Mon, 2019-01-07 at 13:52 +0100, Peter Zijlstra wrote: > On Mon, Jan 07, 2019 at 01:28:34PM +0100, Mike Galbraith wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 960ad0ce77d7..420624c49f38 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -5007,

Re: CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-07 Thread Peter Zijlstra
On Mon, Jan 07, 2019 at 01:28:34PM +0100, Mike Galbraith wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 960ad0ce77d7..420624c49f38 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5007,9 +5007,9 @@ void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) >

Re: CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-07 Thread Mike Galbraith
On Mon, 2019-01-07 at 11:26 +0100, Peter Zijlstra wrote: > > I would expect lockdep you also complain about this... And grumble it did. commit df7e8acc0c9a84979a448d215b8ef889efe4ac5a Author: Mike Galbraith Date: Fri May 4 08:14:38 2018 +0200 sched/fair: Fix CFS bandwidth control lockdep

Re: CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-07 Thread Peter Zijlstra
On Fri, Jan 04, 2019 at 12:42:27PM +, Tom Putzeys wrote: > Dear Ingo and Peter, > > I would like to report a possible bug in the CFS scheduler causing a > dead lock.  > > We suspect this bug to have caused intermittent yet highly-persistent > system freezes on our quad-core SMP systems. > >

CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-04 Thread Tom Putzeys
Dear Ingo and Peter, I would like to report a possible bug in the CFS scheduler causing a dead lock.  We suspect this bug to have caused intermittent yet highly-persistent system freezes on our quad-core SMP systems. We noticed the problem on 4.1.17 preempt-rt but we suspect the problematic cod