Re: Bug introduced in the of_get_named_gpiod_flags function.

2018-10-15 Thread Wojciech Zabołotny
On 13.10.2018 18:23, Linus Walleij wrote: > On Sat, Oct 13, 2018 at 5:53 PM wzabo...@elektron.elka.pw.edu.pl > wrote: > >> The question is, if there may be any other in-tree GPIO controller >> driver that does not initialize those flags? > So as I said, I looked over them and they all initialize >

Re: Bug introduced in the of_get_named_gpiod_flags function.

2018-10-13 Thread Linus Walleij
On Sat, Oct 13, 2018 at 5:53 PM wzabo...@elektron.elka.pw.edu.pl wrote: > The question is, if there may be any other in-tree GPIO controller > driver that does not initialize those flags? So as I said, I looked over them and they all initialize their flags. > Anyway the current situation is som

Re: Bug introduced in the of_get_named_gpiod_flags function.

2018-10-13 Thread wzabo...@elektron.elka.pw.edu.pl
On 10/12/18 10:54 AM, Michal Simek wrote: > Hi, > > On 11.10.2018 10:27, Linus Walleij wrote: >> Hi Wojciech, >> >> (Thanks also Randy for forwarding this!) >> >> On Wed, Oct 10, 2018 at 6:32 PM wzab wrote: >> >>> The function of_get_named_gpiod_flags in older versions of the kernel >>> (up to 4.7

Re: Bug introduced in the of_get_named_gpiod_flags function.

2018-10-12 Thread Michal Simek
Hi, On 11.10.2018 10:27, Linus Walleij wrote: > Hi Wojciech, > > (Thanks also Randy for forwarding this!) > > On Wed, Oct 10, 2018 at 6:32 PM wzab wrote: > >> The function of_get_named_gpiod_flags in older versions of the kernel >> (up to 4.7.10 - >> https://elixir.bootlin.com/linux/v4.7.10/s

Re: Bug introduced in the of_get_named_gpiod_flags function.

2018-10-11 Thread Linus Walleij
Hi Wojciech, (Thanks also Randy for forwarding this!) On Wed, Oct 10, 2018 at 6:32 PM wzab wrote: > The function of_get_named_gpiod_flags in older versions of the kernel > (up to 4.7.10 - > https://elixir.bootlin.com/linux/v4.7.10/source/drivers/gpio/gpiolib-of.c#L75 > ) > contained an import

Bug introduced in the of_get_named_gpiod_flags function.

2018-10-10 Thread Wojciech Zabołotny
Hi, The function of_get_named_gpiod_flags in older versions of the kernel (up to 4.7.10 - https://elixir.bootlin.com/linux/v4.7.10/source/drivers/gpio/gpiolib-of.c#L75 ) contained an important workaround: /* .of_xlate might decide to not fill in the flags, so clear it. */if (flags)  *flags = 0;

Re: Bug introduced in the of_get_named_gpiod_flags function.

2018-10-10 Thread Randy Dunlap
[adding linux-gpio + Linus W.] On 10/10/18 9:13 AM, wzab wrote: > Hi, > > The function of_get_named_gpiod_flags in older versions of the kernel > (up to 4.7.10 - > https://elixir.bootlin.com/linux/v4.7.10/source/drivers/gpio/gpiolib-of.c#L75 > ) > contained an important workaround: > > /* .of

Bug introduced in the of_get_named_gpiod_flags function.

2018-10-10 Thread wzab
Hi, The function of_get_named_gpiod_flags in older versions of the kernel (up to 4.7.10 - https://elixir.bootlin.com/linux/v4.7.10/source/drivers/gpio/gpiolib-of.c#L75 ) contained an important workaround: /* .of_xlate might decide to not fill in the flags, so clear it. */if (flags) *flags =