george anzinger writes:
> All that is cool. Still, most places we don't really address the
> processor, so the logical cpu number is all we need. Places like
> sched_yield, for example, should be using this, not the actual number,
> which IMO should only be used when, for some reason, we NEED th
Hubertus Franke writes:
> I think that all data accesses particularly to __aligned_data
> should be performed through logical ids. There's a lot of remapping
> going on, due to the mix of logical and physical IDs.
>
> If indeed the physical numbers are sparse (like we had on a 4x4
> NUMA system)
>
>
> George, while this is needed as pointed out in a previous message,
> due to non-contiguous physical IDs, I think the current usage is
> pretty bad (at least looking from a x86 perspective). Maybe somebody
> can chime in from a different architecture.
>
> I think that all data accesses par
Walt Drummond wrote:
>
> george anzinger writes:
> > Uh... I do know about this map, but I wonder if it is at all needed.
> > What is the real difference between a logical cpu and the physical one.
> > Or is this only interesting if the machine is not Smp, i.e. all the cpus
> > are not the same?
george anzinger writes:
> Uh... I do know about this map, but I wonder if it is at all needed.
> What is the real difference between a logical cpu and the physical one.
> Or is this only interesting if the machine is not Smp, i.e. all the cpus
> are not the same? It just seems to me that intro
Hubertus Franke wrote:
>
> In the recent optimizations to sys_sched_yield a bug was introduced.
> In the current implementation of sys_sched_yield()
> the aligned_data and idle_tasks are indexed by logical cpu-#.
>
> They should however be indexed by physical cpu-#.
> Since logical==physical on
On Wed, Apr 11, 2001 at 03:31:37PM -0400, Hubertus Franke wrote:
> Below is the fix.
correct. Could you also use cpu_curr(cpu) instead of the longer expression?
(for the mainline it's only a beauty issue of course)
Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
In the recent optimizations to sys_sched_yield a bug was introduced.
In the current implementation of sys_sched_yield()
the aligned_data and idle_tasks are indexed by logical cpu-#.
They should however be indexed by physical cpu-#.
Since logical==physical on the x86 platform, it doesn't matter
8 matches
Mail list logo
