Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-03 Thread Andrew Morton
On Fri, 3 Jun 2016 17:46:25 +0100 Mel Gorman wrote: > On Fri, Jun 03, 2016 at 09:35:18AM -0700, Andrew Morton wrote: > > On Fri, 3 Jun 2016 11:00:30 +0200 Geert Uytterhoeven > > wrote: > > > > > In the mean time my tests completed successfully with both patches > > > applied. > > > > Can we

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-03 Thread Mel Gorman
On Fri, Jun 03, 2016 at 09:35:18AM -0700, Andrew Morton wrote: > On Fri, 3 Jun 2016 11:00:30 +0200 Geert Uytterhoeven > wrote: > > > In the mean time my tests completed successfully with both patches applied. > > Can we please identify "both patches" with specificity? I have the > below one. >

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-03 Thread Andrew Morton
On Fri, 3 Jun 2016 11:00:30 +0200 Geert Uytterhoeven wrote: > In the mean time my tests completed successfully with both patches applied. Can we please identify "both patches" with specificity? I have the below one. From: Mel Gorman Subject: mm, page_alloc: recalculate the preferred zoneref

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-03 Thread Geert Uytterhoeven
Hi Mel, On Fri, Jun 3, 2016 at 10:41 AM, Mel Gorman wrote: > On Fri, Jun 03, 2016 at 09:57:22AM +0200, Geert Uytterhoeven wrote: >> On Thu, Jun 2, 2016 at 8:43 PM, Andrew Morton >> wrote: >> > On Thu, 2 Jun 2016 13:19:36 +0100 Mel Gorman >> > wrote: >> >> > >Signed-off-by: Mel Gorman >> >> >

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-03 Thread Mel Gorman
On Fri, Jun 03, 2016 at 09:57:22AM +0200, Geert Uytterhoeven wrote: > Hi Andrew, Mel, > > On Thu, Jun 2, 2016 at 8:43 PM, Andrew Morton > wrote: > > On Thu, 2 Jun 2016 13:19:36 +0100 Mel Gorman > > wrote: > >> > >Signed-off-by: Mel Gorman > >> > > >> > Acked-by: Vlastimil Babka > >> > > >> >

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-03 Thread Geert Uytterhoeven
Hi Andrew, Mel, On Thu, Jun 2, 2016 at 8:43 PM, Andrew Morton wrote: > On Thu, 2 Jun 2016 13:19:36 +0100 Mel Gorman > wrote: >> > >Signed-off-by: Mel Gorman >> > >> > Acked-by: Vlastimil Babka >> > >> >> Thanks. > > I queued this. A tested-by:Geert would be nice? > > > From: Mel Gorman > Su

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-02 Thread Stephen Rothwell
Hi Andrew, On Thu, 2 Jun 2016 11:43:41 -0700 Andrew Morton wrote: > > On Thu, 2 Jun 2016 13:19:36 +0100 Mel Gorman > wrote: > > > > >Signed-off-by: Mel Gorman > > > > > > Acked-by: Vlastimil Babka > > > > > > > Thanks. > > I queued this. A tested-by:Geert would be nice? > > > F

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-02 Thread Andrew Morton
On Thu, 2 Jun 2016 13:19:36 +0100 Mel Gorman wrote: > > >Signed-off-by: Mel Gorman > > > > Acked-by: Vlastimil Babka > > > > Thanks. I queued this. A tested-by:Geert would be nice? From: Mel Gorman Subject: mm, page_alloc: recalculate the preferred zoneref if the context can ignore me

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-02 Thread Mel Gorman
On Thu, Jun 02, 2016 at 02:04:42PM +0200, Vlastimil Babka wrote: > On 06/02/2016 12:39 PM, Mel Gorman wrote: > >On Wed, Jun 01, 2016 at 12:01:24PM +0200, Vlastimil Babka wrote: > >>>Why? > >>> > >>>The comment is fine but I do not see why the recalculation would occur. > >>> > >>>In the original co

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-02 Thread Vlastimil Babka
On 06/02/2016 12:39 PM, Mel Gorman wrote: On Wed, Jun 01, 2016 at 12:01:24PM +0200, Vlastimil Babka wrote: Why? The comment is fine but I do not see why the recalculation would occur. In the original code, the preferred_zoneref for statistics is calculated based on either the supplied nodemask

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-02 Thread Mel Gorman
On Wed, Jun 01, 2016 at 12:01:24PM +0200, Vlastimil Babka wrote: > > Why? > > > > The comment is fine but I do not see why the recalculation would occur. > > > > In the original code, the preferred_zoneref for statistics is calculated > > based on either the supplied nodemask or cpuset_current_me

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

2016-06-01 Thread Vlastimil Babka
On 06/01/2016 11:19 AM, Mel Gorman wrote: > On Tue, May 31, 2016 at 11:44:24PM +0200, Vlastimil Babka wrote: >> On 05/30/2016 05:56 PM, Mel Gorman wrote: >>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>> index dba8cfd0b2d6..f2c1e47adc11 100644 >>> --- a/mm/page_alloc.c >>> +++ b/mm/page_alloc.

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-06-01 Thread Mel Gorman
On Tue, May 31, 2016 at 11:44:24PM +0200, Vlastimil Babka wrote: > On 05/30/2016 05:56 PM, Mel Gorman wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index dba8cfd0b2d6..f2c1e47adc11 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -3232,6 +3232,9 @@ __alloc_pages_slo

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-05-31 Thread Vlastimil Babka
On 05/30/2016 05:56 PM, Mel Gorman wrote: > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index dba8cfd0b2d6..f2c1e47adc11 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3232,6 +3232,9 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int > order, >* allocations a

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-05-31 Thread Mel Gorman
On Tue, May 31, 2016 at 11:28:05AM +0200, Geert Uytterhoeven wrote: > Hi Mel, > > On Mon, May 30, 2016 at 8:56 PM, Mel Gorman > wrote: > > Thanks. Please try the following instead > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index bb320cde4d6d..557549c81083 100644 > > --- a/mm/page

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-05-31 Thread Geert Uytterhoeven
Hi Mel, On Mon, May 30, 2016 at 8:56 PM, Mel Gorman wrote: > Thanks. Please try the following instead > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index bb320cde4d6d..557549c81083 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3024,6 +3024,7 @@ get_page_from_freelist(gfp_t g

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-05-30 Thread Mel Gorman
On Mon, May 30, 2016 at 07:37:39PM +0200, Geert Uytterhoeven wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index dba8cfd0b2d6..f2c1e47adc11 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -3232,6 +3232,9 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int > > o

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-05-30 Thread Geert Uytterhoeven
Hi Mel, On Mon, May 30, 2016 at 5:56 PM, Mel Gorman wrote: > On Mon, May 30, 2016 at 03:13:40PM +0200, Geert Uytterhoeven wrote: >> > The benefit is negligible and the results are within the noise but each >> > cycle counts. >> > >> > Signed-off-by: Mel Gorman >> > Cc: Vlastimil

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-05-30 Thread Mel Gorman
On Mon, May 30, 2016 at 03:13:40PM +0200, Geert Uytterhoeven wrote: > > The benefit is negligible and the results are within the noise but each > > cycle counts. > > > > Signed-off-by: Mel Gorman > > Cc: Vlastimil Babka > > Cc: Jesper Dangaard Brouer > > Signed-off-by: An

BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)

2016-05-30 Thread Geert Uytterhoeven
eing unused kernel memory: 148K (003f7000 - 0041c000) This architecture does not have kernel memory protection. random: nonblocking pool is initialized Detected scancode offset = 8 (key: 'left ctrl' with scancode $25) Adding 137800k swap on /dev/hda2. Priority:-1 extents:1 across:137800