Re: Automatic clock disabling on clk_put()

2015-05-13 Thread Russell King - ARM Linux
On Wed, May 13, 2015 at 12:45:12PM -0700, Stephen Boyd wrote: > On 05/12/15 23:45, Uwe Kleine-König wrote: > > > >> that hard to call clk_disable_unprepare() on a clock at the end of an > >> error path? Maybe you could add a devm_clk_get_prepare_enable() that > >> does what you want and then call c

Re: Automatic clock disabling on clk_put()

2015-05-13 Thread Stephen Boyd
On 05/12/15 23:45, Uwe Kleine-König wrote: > >> that hard to call clk_disable_unprepare() on a clock at the end of an >> error path? Maybe you could add a devm_clk_get_prepare_enable() that >> does what you want and then call clk_disable_unprepare on the exit path? > You mean clk_disable_unprepare

Re: Automatic clock disabling on clk_put()

2015-05-12 Thread Sascha Hauer
On Tue, May 12, 2015 at 04:23:48PM -0700, Stephen Boyd wrote: > On 05/10/15 23:01, Sascha Hauer wrote: > > Hi, > > > > Since we now have per-user clks we could automatically disable clks on > > clk_put() to make the drivers errors paths easier. AFAIR that was one > > of the motivations to switch to

Re: Automatic clock disabling on clk_put()

2015-05-12 Thread Uwe Kleine-König
Hello, On Tue, May 12, 2015 at 04:23:48PM -0700, Stephen Boyd wrote: > On 05/10/15 23:01, Sascha Hauer wrote: > > Hi, > > > > Since we now have per-user clks we could automatically disable clks on > > clk_put() to make the drivers errors paths easier. AFAIR that was one > > of the motivations to s

Re: Automatic clock disabling on clk_put()

2015-05-12 Thread Stephen Boyd
On 05/10/15 23:01, Sascha Hauer wrote: > Hi, > > Since we now have per-user clks we could automatically disable clks on > clk_put() to make the drivers errors paths easier. AFAIR that was one > of the motivations to switch to per user clks. Is this just not yet > implemented or are there problems i

Automatic clock disabling on clk_put()

2015-05-10 Thread Sascha Hauer
Hi, Since we now have per-user clks we could automatically disable clks on clk_put() to make the drivers errors paths easier. AFAIR that was one of the motivations to switch to per user clks. Is this just not yet implemented or are there problems implementing this? Sascha -- Pengutronix e.K.