Re: Another HID problem this merge window..

2018-10-29 Thread Benjamin Tissoires
Hi, On Sat, Oct 27, 2018 at 11:45 PM Jiri Kosina wrote: > > On Sat, 27 Oct 2018, Linus Torvalds wrote: > > > I wonder if there is some truly old historical legacy there, ie the old > > PC keyboard support would have been configurable out only for expert > > users to avoid errors, and maybe the HI

Re: drivers by default (was Re: Another HID problem this merge window..)

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 4:16 AM Adam Borowski wrote: > > Amen to that. But, perhaps you could encourage people to do enable drivers > once they become very popular? For example, I just (72a9c673636) got hit by > USB 3.0 being off in defconfigs, and not having keyboard is not that cool. Yes, tha

drivers by default (was Re: Another HID problem this merge window..)

2018-10-28 Thread Adam Borowski
On Sat, Oct 27, 2018 at 11:13:17AM -0700, Linus Torvalds wrote: > Ok, so this is a much smaller issue than the i2c one that cause boot > problems, but it's annoying. > > We do *not* enable new random drivers by default. And we most > *definitely* don't do it when they are odd-ball ones that most p

Re: Another HID problem this merge window..

2018-10-27 Thread Jiri Kosina
On Sat, 27 Oct 2018, Linus Torvalds wrote: > I wonder if there is some truly old historical legacy there, ie the old > PC keyboard support would have been configurable out only for expert > users to avoid errors, and maybe the HID Kconfig file started getting > ideas from that... This really g

Re: Another HID problem this merge window..

2018-10-27 Thread Linus Torvalds
On Sat, Oct 27, 2018 at 12:36 PM Joe Perches wrote: > > In fairness, it seems many of the HID drivers do exactly that > and this could have been a "copy from example" addition. Interesting, and I think you're right. I wonder why I haven't noticed this before. Some of those might be hidden by oth

Re: Another HID problem this merge window..

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 11:13 -0700, Linus Torvalds wrote: > Ok, so this is a much smaller issue than the i2c one that cause boot > problems, but it's annoying. > > We do *not* enable new random drivers by default. And we most > *definitely* don't do it when they are odd-ball ones that most people >

Another HID problem this merge window..

2018-10-27 Thread Linus Torvalds
Ok, so this is a much smaller issue than the i2c one that cause boot problems, but it's annoying. We do *not* enable new random drivers by default. And we most *definitely* don't do it when they are odd-ball ones that most people have never heard of. Yet the new "BigBen Interactive" driver that w