Re: Additional debug info to aid cacheline analysis

2020-11-02 Thread Namhyung Kim
Hi Masami, On Mon, Nov 2, 2020 at 5:27 PM Masami Hiramatsu wrote: > > Hi, > > On Fri, 30 Oct 2020 11:10:04 +0100 > Peter Zijlstra wrote: > > > On Fri, Oct 30, 2020 at 10:16:49AM +0100, Mark Wielaard wrote: > > > Hi Namhyung, > > > > > > On Fri, Oct 30, 2020 at 02:26:19PM +0900, Namhyung Kim wrot

Re: Additional debug info to aid cacheline analysis

2020-11-02 Thread Masami Hiramatsu
Hi, On Fri, 30 Oct 2020 11:10:04 +0100 Peter Zijlstra wrote: > On Fri, Oct 30, 2020 at 10:16:49AM +0100, Mark Wielaard wrote: > > Hi Namhyung, > > > > On Fri, Oct 30, 2020 at 02:26:19PM +0900, Namhyung Kim wrote: > > > On Thu, Oct 8, 2020 at 6:38 PM Mark Wielaard wrote: > > > > GCC using -fvar

Re: Additional debug info to aid cacheline analysis

2020-10-30 Thread Peter Zijlstra
On Fri, Oct 30, 2020 at 10:16:49AM +0100, Mark Wielaard wrote: > Hi Namhyung, > > On Fri, Oct 30, 2020 at 02:26:19PM +0900, Namhyung Kim wrote: > > On Thu, Oct 8, 2020 at 6:38 PM Mark Wielaard wrote: > > > GCC using -fvar-tracking and -fvar-tracking-assignments is pretty good > > > at keeping tra

Re: Additional debug info to aid cacheline analysis

2020-10-30 Thread Mark Wielaard
Hi Namhyung, On Fri, Oct 30, 2020 at 02:26:19PM +0900, Namhyung Kim wrote: > On Thu, Oct 8, 2020 at 6:38 PM Mark Wielaard wrote: > > GCC using -fvar-tracking and -fvar-tracking-assignments is pretty good > > at keeping track of where variables are held (in memory or registers) > > when in the pro

Re: Additional debug info to aid cacheline analysis

2020-10-29 Thread Namhyung Kim
Hello, On Thu, Oct 8, 2020 at 6:38 PM Mark Wielaard wrote: > > Hi, > > On Thu, 2020-10-08 at 09:02 +0200, Peter Zijlstra wrote: > > Some time ago, I had my intern pursue the other 2 approaches for > > > symbolization. The one I see as most promising is by using the DWARF > > > information (no BPF

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Florian Weimer
* Mark Wielaard: > On Sun, Oct 11, 2020 at 02:15:18PM +0200, Florian Weimer wrote: >> * Mark Wielaard: >> >> > Yes, that would work. I don't know what the lowest supported GCC >> > version is, but technically it was definitely fixed in 4.10.0, 4.8.4 >> > and 4.9.2. And various distros would proba

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Mark Wielaard
On Sun, Oct 11, 2020 at 02:15:18PM +0200, Florian Weimer wrote: > * Mark Wielaard: > > > Yes, that would work. I don't know what the lowest supported GCC > > version is, but technically it was definitely fixed in 4.10.0, 4.8.4 > > and 4.9.2. And various distros would probably have backported the >

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Florian Weimer
* Mark Wielaard: > Yes, that would work. I don't know what the lowest supported GCC > version is, but technically it was definitely fixed in 4.10.0, 4.8.4 > and 4.9.2. And various distros would probably have backported the > fix. But checking for 5.0+ would certainly give you a good version. > > H

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Segher Boessenkool
Hi! On Sat, Oct 10, 2020 at 10:58:36PM +0200, Mark Wielaard wrote: > On Thu, Oct 08, 2020 at 02:23:00PM -0700, Andi Kleen wrote: > > So I guess could disable it for 5.0+ only. > > Yes, that would work. I don't know what the lowest supported GCC > version is, but technically it was definitely fix

Re: Additional debug info to aid cacheline analysis

2020-10-10 Thread Mark Wielaard
On Thu, Oct 08, 2020 at 02:23:00PM -0700, Andi Kleen wrote: > > Basically you simply want to remove this line in the top-level > > Makefile: > > > > DEBUG_CFLAGS:= $(call cc-option, -fno-var-tracking-assignments) > > It looks like this was needed as a workaround for a gcc bug that was there >

Re: Additional debug info to aid cacheline analysis

2020-10-10 Thread Mark Wielaard
On Sat, Oct 10, 2020 at 10:58:36PM +0200, Mark Wielaard wrote: > Yes, that would work. I don't know what the lowest supported GCC > version is, but technically it was definitely fixed in 4.10.0, 4.8.4 > and 4.9.2. And various distros would probably have backported the > fix. But checking for 5.0+ w

Re: Additional debug info to aid cacheline analysis

2020-10-08 Thread Andi Kleen
> Basically you simply want to remove this line in the top-level > Makefile: > > DEBUG_CFLAGS:= $(call cc-option, -fno-var-tracking-assignments) It looks like this was needed as a workaround for a gcc bug that was there from 4.5 to 4.9. So I guess could disable it for 5.0+ only. -Andi

Re: Additional debug info to aid cacheline analysis

2020-10-08 Thread Mark Wielaard
Hi, On Thu, 2020-10-08 at 09:02 +0200, Peter Zijlstra wrote: > Some time ago, I had my intern pursue the other 2 approaches for > > symbolization. The one I see as most promising is by using the DWARF > > information (no BPF needed). The good news is that I believe we do not > > need more informat

Re: Additional debug info to aid cacheline analysis

2020-10-08 Thread Peter Zijlstra
My appologies for adding a typo to the linux-kernel address, corrected now. On Wed, Oct 07, 2020 at 10:58:00PM -0700, Stephane Eranian wrote: > Hi Peter, > > On Tue, Oct 6, 2020 at 6:17 AM Peter Zijlstra wrote: > > > > Hi all, > > > > I've been trying to float this idea for a fair number of ye