Re: Adding a security parameter to VFS functions

2007-08-20 Thread David Howells
Linus Torvalds <[EMAIL PROTECTED]> wrote: > > Would you object greatly to functions like vfs_mkdir() gaining a security > > parameter? What I'm thinking of is this: > ... > Why the *hell* would mkdir() be so magical as to need something like that? If you look again, you'll notice that I said "fu

Re: Adding a security parameter to VFS functions

2007-08-17 Thread Andreas Gruenbacher
On Friday 17 August 2007 01:34, Al Viro wrote: > On Thu, Aug 16, 2007 at 03:57:24PM -0700, Linus Torvalds wrote: > > I personally consider this an affront to everythign that is decent. > > > > Why the *hell* would mkdir() be so magical as to need something like that? > > > > Make it something san

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Al Viro
On Thu, Aug 16, 2007 at 03:57:24PM -0700, Linus Torvalds wrote: > I personally consider this an affront to everythign that is decent. > > Why the *hell* would mkdir() be so magical as to need something like that? > > Make it something sane, like a "struct nameidata" instead, and make it at > lea

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Kyle Moffett
On Aug 16, 2007, at 18:57:24, Linus Torvalds wrote: On Wed, 15 Aug 2007, David Howells wrote: Would you object greatly to functions like vfs_mkdir() gaining a security parameter? What I'm thinking of is this: int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, struct security *

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Linus Torvalds
On Wed, 15 Aug 2007, David Howells wrote: > > Would you object greatly to functions like vfs_mkdir() gaining a security > parameter? What I'm thinking of is this: > > int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, > struct security *security) I per

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Andreas Gruenbacher
On Wednesday 15 August 2007 13:40, David Howells wrote: > > Hi Linus, Al, > > Would you object greatly to functions like vfs_mkdir() gaining a security > parameter? What I'm thinking of is this: > > int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, > st

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Andreas Gruenbacher
On Wednesday 15 August 2007 18:23, Casey Schaufler wrote: > > Hi Linus, Al, > > > > Would you object greatly to functions like vfs_mkdir() gaining a security > > parameter? > > Could you describe how this compares to the proposal that the > AppArmor developers suggested recently? I expect that we

Re: Adding a security parameter to VFS functions

2007-08-15 Thread David Howells
Casey Schaufler <[EMAIL PROTECTED]> wrote: > > Could you describe how this compares to the proposal that the > AppArmor developers suggested recently? I expect that we can > reduce the amount of discussion required, and maybe avoid some > confusion if you could do that. I don't know what that i

Re: Adding a security parameter to VFS functions

2007-08-15 Thread Casey Schaufler
--- David Howells <[EMAIL PROTECTED]> wrote: > > Hi Linus, Al, > > Would you object greatly to functions like vfs_mkdir() gaining a security > parameter? Could you describe how this compares to the proposal that the AppArmor developers suggested recently? I expect that we can reduce the amoun

Adding a security parameter to VFS functions

2007-08-15 Thread David Howells
Hi Linus, Al, Would you object greatly to functions like vfs_mkdir() gaining a security parameter? What I'm thinking of is this: int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, struct security *security) Where the security context is the state of