Re: Add INPUT support to toshiba_acpi

2007-07-03 Thread Renato S. Yamane
Rolf Eike Beer wrote: Renato S. Yamane wrote: Rolf Eike Beer wrote: Richard Hughes wrote: Yes, although this is out of my area or expertise, sorry. I've looked a bit but can't find any driver interaction of those programs. Any further ideas welcome. Do you try omnibook driver? svn export

Re: Add INPUT support to toshiba_acpi

2007-07-02 Thread Rolf Eike Beer
Renato S. Yamane wrote: > Rolf Eike Beer wrote: > > Richard Hughes wrote: > >> Yes, although this is out of my area or expertise, sorry. > > > > I've looked a bit but can't find any driver interaction of those > > programs. Any further ideas welcome. > > Do you try omnibook driver? > svn export htt

Re: Add INPUT support to toshiba_acpi

2007-06-28 Thread Renato S. Yamane
Rolf Eike Beer wrote: Richard Hughes wrote: Yes, although this is out of my area or expertise, sorry. I've looked a bit but can't find any driver interaction of those programs. Any further ideas welcome. Do you try omnibook driver? svn export https://svn.sourceforge.net/svnroot/omnibook/omn

Re: Add INPUT support to toshiba_acpi

2007-06-28 Thread Rolf Eike Beer
Richard Hughes wrote: > On Tue, 2007-06-26 at 07:03 +0200, Rolf Eike Beer wrote: >> Richard Hughes wrote: >>> On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: None of the above keys generated a key event. Neither does "Brightness down", but it still works. "Brightness up" generate

Re: Add INPUT support to toshiba_acpi

2007-06-26 Thread Richard Hughes
On Tue, 2007-06-26 at 07:03 +0200, Rolf Eike Beer wrote: > Richard Hughes wrote: > > On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: > > > None of the above keys generated a key event. Neither does > "Brightness > > > down", but it still works. "Brightness up" generates an event and > work

Re: Add INPUT support to toshiba_acpi

2007-06-25 Thread Rolf Eike Beer
Richard Hughes wrote: > On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: > > None of the above keys generated a key event. Neither does "Brightness > > down", but it still works. "Brightness up" generates an event and works. > > Kpowersave tells me it can't do brightness switching in softwa

Re: Add INPUT support to toshiba_acpi

2007-06-25 Thread Rolf Eike Beer
Richard Hughes wrote: > On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: > > None of the above keys generated a key event. Neither does "Brightness > > down", but it still works. "Brightness up" generates an event and works. > > Kpowersave tells me it can't do brightness switching in softwa

Re: Add INPUT support to toshiba_acpi

2007-06-25 Thread Richard Hughes
On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: > None of the above keys generated a key event. Neither does "Brightness down", > but it still works. "Brightness up" generates an event and works. Kpowersave > tells me it can't do brightness switching in software (which works in > WinXtr

Re: Add INPUT support to toshiba_acpi

2007-06-25 Thread Rolf Eike Beer
Richard Hughes wrote: > Attached patch adds a kernel thread to do polling on Toshiba hardware. Is there something similar available to support other Toshiba laptops? I own a A110-178 that is not supported by the driver but has a lot of keys that I can't use currently: Fn: -screen zoom (I actual

Re: Add INPUT support to toshiba_acpi

2007-06-11 Thread Renato S. Yamane
Richard Hughes wrote: What's the status of this patch? Good for merging? Do you want me to redo the current patch using input-polldev and the new setkeycode stuff? A detail: I receive error message (no such device) when I try load toshiba_acpi on my Toshiba M45-S355 (BIOS is Toshiba and NOT Ph

Re: Add INPUT support to toshiba_acpi

2007-06-08 Thread Richard Hughes
On Fri, 2007-06-08 at 10:23 -0400, Dmitry Torokhov wrote: > On 6/7/07, Richard Hughes <[EMAIL PROTECTED]> wrote: > > On Sun, 2007-06-03 at 00:48 -0400, Dmitry Torokhov wrote: > > > > > > > > > It looks like KEY_COFFE comes from 0x0c/0x19e - AL Terminal > > > Lock/Screensaver > > > so your interpret

Re: Add INPUT support to toshiba_acpi

2007-06-08 Thread Dmitry Torokhov
On 6/7/07, Richard Hughes <[EMAIL PROTECTED]> wrote: On Sun, 2007-06-03 at 00:48 -0400, Dmitry Torokhov wrote: > > > It looks like KEY_COFFE comes from 0x0c/0x19e - AL Terminal > Lock/Screensaver > so your interpretation is indeed correct. I guess I better add an > alias to > input.h What's the

Re: Add INPUT support to toshiba_acpi

2007-06-07 Thread Richard Hughes
On Sun, 2007-06-03 at 00:48 -0400, Dmitry Torokhov wrote: > > > It looks like KEY_COFFE comes from 0x0c/0x19e - AL Terminal > Lock/Screensaver > so your interpretation is indeed correct. I guess I better add an > alias to > input.h What's the status of this patch? Good for merging? Do you want m

Re: Add INPUT support to toshiba_acpi

2007-06-02 Thread Dmitry Torokhov
On Saturday 02 June 2007 10:23, Matthew Garrett wrote: > On Sat, Jun 02, 2007 at 01:50:52PM +0100, Richard Hughes wrote: > > > KEY_SCREENLOCK? KEY_SCREENSAVER? > > > > Either of these keys would be good to add. > > We've been interpreting "KEY_COFFEE" as screenlock (as in "I've gone for > a coff

Re: Add INPUT support to toshiba_acpi

2007-06-02 Thread Matthew Garrett
On Sat, Jun 02, 2007 at 01:50:52PM +0100, Richard Hughes wrote: > > KEY_SCREENLOCK? KEY_SCREENSAVER? > > Either of these keys would be good to add. We've been interpreting "KEY_COFFEE" as screenlock (as in "I've gone for a coffee break, lock the screen"). -- Matthew Garrett | [EMAIL PROTECTED]

Re: Add INPUT support to toshiba_acpi

2007-06-02 Thread Richard Hughes
On Fri, 2007-06-01 at 12:45 -0400, Dmitry Torokhov wrote: > The patch was pretty good, I did not quite like the driver > registration code so I tried to clean it up. Cool, cheers. > What do you think about > the attached patch (not tested due to the lack of hardware). If you > are OK with it plea

Re: Add INPUT support to toshiba_acpi

2007-06-01 Thread Dmitry Torokhov
Hi Richard, On 5/31/07, Richard Hughes <[EMAIL PROTECTED]> wrote: On Thu, 2007-05-31 at 14:44 +0100, Richard Hughes wrote: > Nope, impossible AFAICS. The hardware is just broken. Windows XP has an > toshiba supplied daemon that polls, so I think we have to just bite the > bullet. ... adding in

Re: Add INPUT support to toshiba_acpi

2007-05-31 Thread Richard Hughes
On Thu, 2007-05-31 at 18:46 +0200, Andreas Mohr wrote: > HCI_EMPTY is *by far* the most frequent state to occur I think > (users won't press keys all the time), thus it's probably better(?) > for branch prediction to have this placed first, right? > Not that it matters too much instruction-wise, bu

Re: Add INPUT support to toshiba_acpi

2007-05-31 Thread Andreas Mohr
Hi, On Thu, May 31, 2007 at 04:46:56PM +0100, Richard Hughes wrote: + if (!hotkeys_over_input) { + if (!key_event_valid) { + hci_read1(HCI_SYSTEM_EVENT, &value, &hci_result); + if (hci_result == HCI_SUCCESS) { +

Re: Add INPUT support to toshiba_acpi

2007-05-31 Thread Richard Hughes
On Thu, 2007-05-31 at 14:44 +0100, Richard Hughes wrote: > Nope, impossible AFAICS. The hardware is just broken. Windows XP has an > toshiba supplied daemon that polls, so I think we have to just bite the > bullet. ... adding in reply in different thread... On Thu, 2007-05-31 at 10:37 -0400, Dmit

Re: Add INPUT support to toshiba_acpi

2007-05-31 Thread Bastien Nocera
On Thu, 2007-05-31 at 13:36 +0100, Richard Hughes wrote: > Attached patch adds a kernel thread to do polling on Toshiba hardware. > > Toshiba hardware is a little oddball, and does not provide ACPI events > on some key presses, typically Fn hotkey buttons. The key interface is > now polled, and ev

Re: Add INPUT support to toshiba_acpi

2007-05-31 Thread Richard Hughes
On Thu, 2007-05-31 at 13:53 +0100, Bastien Nocera wrote: > On Thu, 2007-05-31 at 13:36 +0100, Richard Hughes wrote: > > Attached patch adds a kernel thread to do polling on Toshiba hardware. > > > > Toshiba hardware is a little oddball, and does not provide ACPI events > > on some key presses, typ

Add INPUT support to toshiba_acpi

2007-05-31 Thread Richard Hughes
Attached patch adds a kernel thread to do polling on Toshiba hardware. Toshiba hardware is a little oddball, and does not provide ACPI events on some key presses, typically Fn hotkey buttons. The key interface is now polled, and events now matched to a list of toshiba specific scancodes, and are s