Re: ARM i.MX serial: fix tx buffer overflows

2007-01-29 Thread Konstantin Kletschke
Am 2007-01-29 15:37 + schrieb Russell King: > Is it really worth adding additional code to shut up this (imho) silly > warning? It's just adding needless complexity to drivers. As I pointed out in http://lists.arm.linux.org.uk/pipermail/linux-arm-kernel/2006-November/037192.html the console

Re: ARM i.MX serial: fix tx buffer overflows

2007-01-29 Thread Russell King
On Mon, Jan 29, 2007 at 03:47:59PM +0100, Konstantin Kletschke wrote: > Am 2007-01-05 19:01 +0100 schrieb Pavel Pisa: > > > It applies only for interrupts going through GPIO layer. > > The problem has been noticed by Konstantin Kletschke > > some time ago. > > > > No IRQF_TRIGGER set_type funct

Re: ARM i.MX serial: fix tx buffer overflows

2007-01-29 Thread Konstantin Kletschke
Am 2007-01-05 19:01 +0100 schrieb Pavel Pisa: > It applies only for interrupts going through GPIO layer. > The problem has been noticed by Konstantin Kletschke > some time ago. > > No IRQF_TRIGGER set_type function for IRQ 26 (MPU) Yes. I reported this also. > drivers/serial/imx.c |3 ++-

Re: ARM i.MX serial: fix tx buffer overflows

2007-01-05 Thread Pavel Pisa
On Friday 05 January 2007 16:51, Sascha Hauer wrote: > This patch fixes occasional tx buffer overflows in the i.MX serial > driver which came from the fact that space in the buffer was checked > after sending the first byte. Also, fifosize is 32 bytes, not 8. > > Signed-off-by: Sascha Hauer <[EMAIL

ARM i.MX serial: fix tx buffer overflows

2007-01-05 Thread Sascha Hauer
This patch fixes occasional tx buffer overflows in the i.MX serial driver which came from the fact that space in the buffer was checked after sending the first byte. Also, fifosize is 32 bytes, not 8. Signed-off-by: Sascha Hauer <[EMAIL PROTECTED] --- drivers/serial/imx.c | 11 +-- 1 f