Re: ARM: Section mismatch warnings

2007-05-28 Thread Russell King
On Mon, May 28, 2007 at 09:58:47PM +0200, Sam Ravnborg wrote: > Declaring neponset_probe __init cured it. > Sorry for posting the wrong patch in the first place. Arguably, making neponset_probe __devinit and neponset_port_fns __devinitdata is arguably more correct since any device driver can be bo

Re: ARM: Section mismatch warnings

2007-05-28 Thread Sam Ravnborg
On Mon, May 28, 2007 at 08:25:48PM +0100, Russell King wrote: > On Mon, May 28, 2007 at 08:36:29PM +0200, Sam Ravnborg wrote: > > > > > > > o-arm-neponset/log.out:WARNING: > > > > arch/arm/mach-sa1100/built-in.o(.text+0x1748): > > > Section mismatch: reference to .init.text:sa1110_mb_disable > >

Re: ARM: Section mismatch warnings

2007-05-28 Thread Russell King
On Mon, May 28, 2007 at 08:36:29PM +0200, Sam Ravnborg wrote: > > > > > o-arm-neponset/log.out:WARNING: > > > arch/arm/mach-sa1100/built-in.o(.text+0x1748): > > Section mismatch: reference to .init.text:sa1110_mb_disable > > (between 'neponset_init' and 'neponset_resume') > > > > This one look

Re: ARM: Section mismatch warnings

2007-05-28 Thread Sam Ravnborg
> > > o-arm-neponset/log.out:WARNING: > > arch/arm/mach-sa1100/built-in.o(.text+0x1748): > Section mismatch: reference to .init.text:sa1110_mb_disable > (between 'neponset_init' and 'neponset_resume') > > This one looks quite bogus. sa1110_mb_disable() is marked __init, and > it's called from

Re: ARM: Section mismatch warnings

2007-05-28 Thread Andrew Victor
hi Russell, > > o-arm-ks8695/log.out:WARNING: arch/arm/mach-ks8695/built-in.o(.data+0x108): > Section mismatch: reference to .init.text:micrel_pci_map_irq > (after 'micrel_pci') > > If this platform can have PCI stuff hotplugged, then this is a problem. > If it's fixed then it isn't - PCI IRQ r

Re: ARM: Section mismatch warnings

2007-05-28 Thread Russell King
On Mon, May 28, 2007 at 06:32:53PM +0200, Sam Ravnborg wrote: > # These are all almost trivial if one knows the device-model. I did not > know enough about the devicemodel to fix them. > # I suspect several symbols should NOT be marked __init since they are > used in .add assignments and the like >

ARM: Section mismatch warnings

2007-05-28 Thread Sam Ravnborg
Hi Russell. I've been building all defconfigs for ARM on latest -linus tree and got the following results with respect to section mismatch warnings. Unpatched: 105 section mismatch warnings Applied a path to ignore section mismatch warnings from variables named *_timer. Result: 39 section mismat