Re: APUv2/v3 board support V3

2019-02-20 Thread Linus Walleij
On Fri, Feb 15, 2019 at 7:16 PM Andy Shevchenko wrote: > On Fri, Feb 15, 2019 at 12:05 AM Enrico Weigelt, metux IT consult > Linus, this one looks good enough, though some style minors can be addressed: > - redundant parens (and actually I prefer to see x = readl(); x |= > ...; writel(); in three

Re: APUv2/v3 board support V3

2019-02-15 Thread Andy Shevchenko
On Fri, Feb 15, 2019 at 12:05 AM Enrico Weigelt, metux IT consult wrote: > > Hi folks, > > Thanks for an update. Linus, this one looks good enough, though some style minors can be addressed: - redundant parens (and actually I prefer to see x = readl(); x |= ...; writel(); in three lines) - usele

APUv2/v3 board support V3

2019-02-14 Thread Enrico Weigelt, metux IT consult
Hi folks, this is version 3 of my APUv2/APUv3 series. change in V3: * gpio driver * drop unncessary gpio id checks * cleanup amd_fch_gpio_set() * move iores outside probe() * shorter NULL checks and correct error in probe() * apu board driver * drop unneeded init.h * drop un