Re: 3.15 regression: wrong cgroup magic

2014-06-03 Thread Tejun Heo
On Tue, Jun 03, 2014 at 01:52:51PM -0400, Tejun Heo wrote: > On Tue, Jun 03, 2014 at 10:23:03AM -0700, Linus Torvalds wrote: > > Tejun, just to be anal, can you please test and verify current -git > > (preferably both 'master' and 'next') with your app that cared about > > the f_type information fo

Re: 3.15 regression: wrong cgroup magic

2014-06-03 Thread Tejun Heo
On Tue, Jun 03, 2014 at 10:23:03AM -0700, Linus Torvalds wrote: > Tejun, just to be anal, can you please test and verify current -git > (preferably both 'master' and 'next') with your app that cared about > the f_type information for statfs().. It was Andy. Andy, can you please verify the latest

Re: 3.15 regression: wrong cgroup magic

2014-06-03 Thread Linus Torvalds
On Tue, Jun 3, 2014 at 10:48 AM, Andy Lutomirski wrote: > > Did you mean me? I did. Lost track of the people involved. Oops. Thanks, Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: 3.15 regression: wrong cgroup magic

2014-06-03 Thread Andy Lutomirski
On Tue, Jun 3, 2014 at 10:23 AM, Linus Torvalds wrote: > On Mon, Jun 2, 2014 at 6:30 PM, Linus Torvalds > wrote: >> >> Of course, Greg could just send it to me for my next branch (since the >> merge window for 3.16 is already open) and tell me that it's also >> stable material for 3.15. At _that_

Re: 3.15 regression: wrong cgroup magic

2014-06-03 Thread Linus Torvalds
On Mon, Jun 2, 2014 at 6:30 PM, Linus Torvalds wrote: > > Of course, Greg could just send it to me for my next branch (since the > merge window for 3.16 is already open) and tell me that it's also > stable material for 3.15. At _that_ point I'll happily cherry-pick it > into master... Ok, so that

Re: 3.15 regression: wrong cgroup magic

2014-06-02 Thread Greg Kroah-Hartman
On Mon, Jun 02, 2014 at 06:30:20PM -0700, Linus Torvalds wrote: > On Mon, Jun 2, 2014 at 6:22 PM, Tejun Heo wrote: > > > > Linus, can you please cherry-pick the commit? > > I'd much rather see it go through the proper channels than go ahead > and cherry-pick from some branch that hasn't even been

Re: 3.15 regression: wrong cgroup magic

2014-06-02 Thread Linus Torvalds
On Mon, Jun 2, 2014 at 6:22 PM, Tejun Heo wrote: > > Linus, can you please cherry-pick the commit? I'd much rather see it go through the proper channels than go ahead and cherry-pick from some branch that hasn't even been sent to me yet. The whole "you have to send things to me for me to take the

Re: 3.15 regression: wrong cgroup magic

2014-06-02 Thread Tejun Heo
On Tue, Jun 03, 2014 at 09:18:25AM +0800, Li Zefan wrote: > > commit 2bd59d48ebfb3df41ee56938946ca0dd30887312 > > Author: Tejun Heo > > Date: Tue Feb 11 11:52:49 2014 -0500 > > > > cgroup: convert to kernfs > > > > In particular, this piece: > > > > - sb->s_magic = CGROUP_SUPER_MAGI

Re: 3.15 regression: wrong cgroup magic

2014-06-02 Thread Li Zefan
Cc: Greg Cc: Jianyu Zhan On 2014/6/3 8:56, Andy Lutomirski wrote: > Sorry I didn't notice this earlier. Linux 3.15 breaks my production But 3.15 hasn't been released. :) > system :( The cause appears to be: > > commit 2bd59d48ebfb3df41ee56938946ca0dd30887312 > Author: Tejun Heo > Date: Tue

Re: 3.15 regression: wrong cgroup magic

2014-06-02 Thread Linus Torvalds
On Mon, Jun 2, 2014 at 5:56 PM, Andy Lutomirski wrote: > > In particular, this piece: > > - sb->s_magic = CGROUP_SUPER_MAGIC; > > The result is that cgroup shows up with the wrong magic number, so my > code goes "oh crap, cgroupfs isn't mounted" and fails. > > I can change my code to hack ar

3.15 regression: wrong cgroup magic

2014-06-02 Thread Andy Lutomirski
Sorry I didn't notice this earlier. Linux 3.15 breaks my production system :( The cause appears to be: commit 2bd59d48ebfb3df41ee56938946ca0dd30887312 Author: Tejun Heo Date: Tue Feb 11 11:52:49 2014 -0500 cgroup: convert to kernfs In particular, this piece: - sb->s_magic = CGROU