Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Jiri Kosina
On Thu, 27 Sep 2007, Andrew Morton wrote: > > +extern void arch_randomize_brk(void); > > #include "../../../fs/binfmt_elf.c" > Is this sinful extern-decl-in-C acually needed? Some time passed since I have written the patch, but I remember that this was needed, otherwise under some circumstance

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> wrote: > i386 and x86_64: randomize brk() > > ... > > --- a/arch/x86_64/ia32/ia32_binfmt.c > +++ b/arch/x86_64/ia32/ia32_binfmt.c > @@ -262,6 +262,7 @@ static void elf32_init(struct pt_regs *); > #define ARCH_HAS_SETUP_ADD

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Sam Ravnborg
On Thu, Sep 27, 2007 at 10:13:42AM -0700, Andrew Morton wrote: > On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> > wrote: > > > On Thu, 27 Sep 2007, Andy Whitcroft wrote: > > > > > Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we > > > have three

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Thu, 27 Sep 2007, Andy Whitcroft wrote: > > > Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we > > have three options from here: > > 1) update the compiler support list to exclude these c

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Jiri Kosina
On Thu, 27 Sep 2007, Andy Whitcroft wrote: > Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we > have three options from here: > 1) update the compiler support list to exclude these compilers, or > 2) back this change out, or > 3) switch to the version not using __weak. > Th

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Andy Whitcroft
> actually, my first patch wasn't using weak symbols, but I have been > convinced that it's the way to go(tm). Please see > http://lkml.org/lkml/2007/9/1/131 and the ongoing thread. > > I am fine with replacing the brk randomization patch with the one that > wasn't using weak symbols (posted in

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-25 Thread Jiri Kosina
On Tue, 25 Sep 2007, Andy Whitcroft wrote: > As suggested elsewhere I have had a go at tracking this down. Previous > problems of this kind were introduced as a result of using 'weak' > declarations to provide default implementations. This investigation led > me to the following commit: > c

2.6.23-rc8-mm1 -- powerpc link failure

2007-09-25 Thread Andy Whitcroft
2.6.23-rc6-mm1, 2.6.23-rc7-mm1 and 2.6.23-rc8-mm1 all fail to link correctly on a powerpc machine (elm3b19) in our test grid. It fails as below: LD vmlinux.o ld: dynreloc miscount for fs/built-in.o, section .opd ld: can not edit opd Bad value make: *** [vmlinux.o] Error 1 Compiler