Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-17 Thread Balbir Singh
Benjamin Herrenschmidt wrote: > On Sat, 2007-09-15 at 11:00 -0400, Mathieu Desnoyers wrote: >> * Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: >>> On Thu, 2007-09-13 at 15:17 -0700, Andrew Morton wrote: >>> Like this? --- a/include/asm-powerpc/bitops.h~powerpc-lock-bitops-fix >>>

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-17 Thread Benjamin Herrenschmidt
On Sat, 2007-09-15 at 11:00 -0400, Mathieu Desnoyers wrote: > * Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: > > On Thu, 2007-09-13 at 15:17 -0700, Andrew Morton wrote: > > > > > Like this? > > > > > > --- a/include/asm-powerpc/bitops.h~powerpc-lock-bitops-fix > > > +++ a/include/asm-powerpc

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-15 Thread Mathieu Desnoyers
* Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: > On Thu, 2007-09-13 at 15:17 -0700, Andrew Morton wrote: > > > Like this? > > > > --- a/include/asm-powerpc/bitops.h~powerpc-lock-bitops-fix > > +++ a/include/asm-powerpc/bitops.h > > @@ -226,7 +226,7 @@ static __inline__ void set_bits(unsigned

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-15 Thread Benjamin Herrenschmidt
On Thu, 2007-09-13 at 15:17 -0700, Andrew Morton wrote: > Like this? > > --- a/include/asm-powerpc/bitops.h~powerpc-lock-bitops-fix > +++ a/include/asm-powerpc/bitops.h > @@ -226,7 +226,7 @@ static __inline__ void set_bits(unsigned > > static __inline__ void __clear_bit_unlock(int nr, volatile

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-13 Thread Andrew Morton
On Sat, 08 Sep 2007 18:42:10 +0200 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > If so, the finger points at this: > > > > > > static __inline__ void __clear_bit_unlock(int nr, volatile unsigned long > > > *addr) { > > > __asm__ __volatile__(LWSYNC_ON_SMP ::: "memory"); > > > __cl

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-08 Thread Benjamin Herrenschmidt
> > If so, the finger points at this: > > > > static __inline__ void __clear_bit_unlock(int nr, volatile unsigned long > > *addr) { > > __asm__ __volatile__(LWSYNC_ON_SMP ::: "memory"); > > __clear_bit(nr, addr); > > } > > > > which was added by Nick's powerpc-lock-bitops.patch. I am susp

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-07 Thread Nick Piggin
On Friday 07 September 2007 09:00, Andrew Morton wrote: > > On Thu, 6 Sep 2007 14:40:11 -0400 Mathieu Desnoyers > > <[EMAIL PROTECTED]> wrote: Hi Andrew, > > > > Guess what, another one ;) > > > > > > /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-linux-gnu/bin/powerpc-40 > >5-linux-gnu-gcc -m3

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-06 Thread Andrew Morton
> On Thu, 6 Sep 2007 14:40:11 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > Guess what, another one ;) > > > /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-linux-gnu/bin/powerpc-405-linux-gnu-gcc > -m32 -Wp,-MD,arch/ppc/kernel/.asm-offsets.s.d -nostdinc -isystem > /o

2.6.23-rc4-mm1 compile error for ppc 32

2007-09-06 Thread Mathieu Desnoyers
Hi Andrew, Guess what, another one ;) /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-linux-gnu/bin/powerpc-405-linux-gnu-gcc -m32 -Wp,-MD,arch/ppc/kernel/.asm-offsets.s.d -nostdinc -isystem /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-linux-gnu/lib/gcc/powerpc-405-linux-gnu/4.1.1/incl