Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-11 Thread Tony Breeds
On Fri, Mar 09, 2007 at 09:14:29AM -0800, Randy Dunlap wrote: > Good to use FIELD_SIZEOF(), Thanks. > but in general, we prefer to use it > directly, not in yet another wrapper. I left the item_{size,addr} in place as it seemed to make the item[] more compact. I'm

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-09 Thread Randy Dunlap
On Fri, 9 Mar 2007 09:19:07 -0500 John W. Linville wrote: > Probably should copy me and [EMAIL PROTECTED] Other than > that, this looks fine to me. I'll queue it up shortly. > > John > > On Fri, Mar 09, 2007 at 01:11:46PM +1100, Tony Breeds wrote: > > On Wed, Mar 07, 2007 at 03:00:57PM -0800,

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-09 Thread John W. Linville
Probably should copy me and [EMAIL PROTECTED] Other than that, this looks fine to me. I'll queue it up shortly. John On Fri, Mar 09, 2007 at 01:11:46PM +1100, Tony Breeds wrote: > On Wed, Mar 07, 2007 at 03:00:57PM -0800, Andrew Morton wrote: > > On Wed, 7 Mar 2007 23:41:16 +0100 > > Adrian Bun

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-08 Thread Tony Breeds
On Wed, Mar 07, 2007 at 03:00:57PM -0800, Andrew Morton wrote: > On Wed, 7 Mar 2007 23:41:16 +0100 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote: > > >... > > > Changes since 2.6.20-rc2-mm1: > > >... > > > git-netdev-all.patch > > >..

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-08 Thread Adrian Bunk
On Wed, Mar 07, 2007 at 03:00:57PM -0800, Andrew Morton wrote: > On Wed, 7 Mar 2007 23:41:16 +0100 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote: > > >... > > > Changes since 2.6.20-rc2-mm1: > > >... > > > git-netdev-all.patch > > >..

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-07 Thread Andrew Morton
On Wed, 7 Mar 2007 23:41:16 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote: > >... > > Changes since 2.6.20-rc2-mm1: > >... > > git-netdev-all.patch > >... > > git trees > >... > > drivers/net/wireless/libertas/debugfs.c contains: >

2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-07 Thread Adrian Bunk
On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote: >... > Changes since 2.6.20-rc2-mm1: >... > git-netdev-all.patch >... > git trees >... drivers/net/wireless/libertas/debugfs.c contains: #define item_addr(n) ((u32) &((wlan_adapter *)0)->n) This is wrong on 64bit architectures. c