Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Miquel van Smoorenburg
In article <[EMAIL PROTECTED]>, Timur Tabi <[EMAIL PROTECTED]> wrote: >** Reply to message from Peter Samuelson <[EMAIL PROTECTED]> on Mon, 18 Dec >2000 09:03:00 -0600 (CST) >> Not a compiler bug, a source bug of assuming a C header file can be >> included by a C++ program. The right solution, a

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Alan Cox
> programmer for a C++ programmer. All the C programmer needs to do is > acknowledge that someone might want to use a C++ compiler on the code, and just > make a few minor changes that have no negative affect at all. All C++ folks need to do is to use extern "C" { #include "macrosforthestuffthe

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Timur Tabi
** Reply to message from Peter Samuelson <[EMAIL PROTECTED]> on Mon, 18 Dec 2000 09:03:00 -0600 (CST) > Not a compiler bug, a source bug of assuming a C header file can be > included by a C++ program. The right solution, as always, is to make a > copy of the header (assuming you really do need

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Andrea Arcangeli
On Mon, Dec 18, 2000 at 09:24:17AM -0600, Peter Samuelson wrote: > Sure it does when they are language keywords. In this case he is > trying to change the parameter name "new". Ok ;) Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EM

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Peter Samuelson
[Andrea Arcangeli] > C++ obviously doesn't care about the name of parameters in a function > too. Sure it does when they are language keywords. In this case he is trying to change the parameter name "new". Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Andrea Arcangeli
On Mon, Dec 18, 2000 at 09:03:00AM -0600, Peter Samuelson wrote: > Not a compiler bug, a source bug of assuming a C header file can be > included by a C++ program. [..] C++ obviously doesn't care about the name of parameters in a function too. Andrea - To unsubscribe from this list: send the lin

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Peter Samuelson
[Peter Samuelson] > > You are changing perfectly legal C. [Andrea Arcangeli] > You're right that's not kernel issue and patch can be rejected, but > he's not really changing anything :). If changing that helps then > it's a compiler bug. Not a compiler bug, a source bug of assuming a C header

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Andrea Arcangeli
On Mon, Dec 18, 2000 at 03:31:54AM -0600, Peter Samuelson wrote: > directly. You are changing perfectly legal C. You're right that's not kernel issue and patch can be rejected, but he's not really changing anything :). If changing that helps then it's a compiler bug. Andrea - To unsubscribe fro

Re: 2.2.18 asm-alpha/system.h has a problem

2000-12-18 Thread Peter Samuelson
[Daiki Matsuda] > I encounterd the problem that 'cdrdao' is not compilable in 2.2.18 on > Alpha. And I researched a little. Then cdrdao has a problem. It should not be including kernel headers directly. You are changing perfectly legal C. Peter - To unsubscribe from this list: send the line

2.2.18 asm-alpha/system.h has a problem

2000-12-17 Thread Daiki Matsuda
Hi, all. I encounterd the problem that 'cdrdao' is not compilable in 2.2.18 on Alpha. And I researched a little. So, then new code added in include/asm-alpha/system.h on 2.2.18 has a problem in C++. The 'new' may be the reserved word in C++. And I send its patch. Regards Daiki Matsuda --- linu